1599641 - Un-formatted stack traces for event-emitter errors in Browser Console

Status: RESOLVED FIXED

(DevTools :: General, defect, P2)

Description

[:Harald Kirschner :digitarald]

Saw this while looking at logs for bug 1599635. Seems mostly errors logged from console.error, which Console has been improving but still seems to struggle with even for Firefox code.

https://www.loom.com/share/81b676987d95419a8b25067a498768b2

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

This is because we are logging a string in devtools/shared/event-emitter.js#193-195 :

const msg = ex + ": " + ex.stack;
// For us it's a simple string here.
console.error(msg);

A simple fix, for us, would be to directly use ex, which should render a proper error in the console.

We have Bug 1046256 to parse those and render them as the other stacks (it might be perf sensitive though).

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1599641 - Directly log an exception in event emitter. r=jdescottes.

We were logging a concatenated string of the
exception and its stack trace, which means
that it would show up in the console as a simple
string (i.e. without clickable links).
Logging the exception should make it more readable
in the browser console.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a9fe3f170934
Directly log an exception in event emitter. r=jdescottes.

Comment 4

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/a9fe3f170934