1599745 - Opening remote profiling panel throws some preference related errors on debuggee

Status: RESOLVED FIXED

(Core :: Gecko Profiler, defect, P2)

Description

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Encountered this while I was testing another feature. Opening the remote profiling panel throws some errors.

STR:

• Fire up a second Firefox with --start-debugger-server 1234.
• Open about:debugging on the first Firefox and add locahost:1234 .
• Open the performance panel by clicking "Profile Performance" button.
• See the errors on browser console.

Console output:

console.error: "Error while calling actor 'preference's method 'getIntPref'" "preference is not of the right type: devtools.performance.recording.entries"
console.error: "ensurePrefType@resource://devtools/server/actors/preference.js:16:11\ngetIntPref@resource://devtools/server/actors/preference.js:44:19\nhandler@resource://devtools/shared/protocol/Actor.js:154:37\nonPacket@resource://devtools/server/debugger-server-connection.js:378:58\n_onJSONObjectReady/<@resource://devtools/shared/transport/transport.js:464:22\nexports.makeInfallible/<@resource://devtools/shared/ThreadSafeDevToolsUtils.js:111:22\nexports.makeInfallible/<@resource://devtools/shared/ThreadSafeDevToolsUtils.js:111:22\n"
console.error: "Error while calling actor 'preference's method 'getIntPref'" "preference is not of the right type: devtools.performance.recording.interval"
console.error: "ensurePrefType@resource://devtools/server/actors/preference.js:16:11\ngetIntPref@resource://devtools/server/actors/preference.js:44:19\nhandler@resource://devtools/shared/protocol/Actor.js:154:37\nonPacket@resource://devtools/server/debugger-server-connection.js:378:58\n_onJSONObjectReady/<@resource://devtools/shared/transport/transport.js:464:22\nexports.makeInfallible/<@resource://devtools/shared/ThreadSafeDevToolsUtils.js:111:22\nexports.makeInfallible/<@resource://devtools/shared/ThreadSafeDevToolsUtils.js:111:22\n"
console.error: "Error while calling actor 'preference's method 'getCharPref'" "preference is not of the right type: devtools.performance.recording.features"
console.error: "ensurePrefType@resource://devtools/server/actors/preference.js:16:11\ngetCharPref@resource://devtools/server/actors/preference.js:39:19\nhandler@resource://devtools/shared/protocol/Actor.js:154:37\nonPacket@resource://devtools/server/debugger-server-connection.js:378:58\n_onJSONObjectReady/<@resource://devtools/shared/transport/transport.js:464:22\nexports.makeInfallible/<@resource://devtools/shared/ThreadSafeDevToolsUtils.js:111:22\nexports.makeInfallible/<@resource://devtools/shared/ThreadSafeDevToolsUtils.js:111:22\n"
console.error: "Error while calling actor 'preference's method 'getCharPref'" "preference is not of the right type: devtools.performance.recording.threads"
console.error: "ensurePrefType@resource://devtools/server/actors/preference.js:16:11\ngetCharPref@resource://devtools/server/actors/preference.js:39:19\nhandler@resource://devtools/shared/protocol/Actor.js:154:37\nonPacket@resource://devtools/server/debugger-server-connection.js:378:58\n_onJSONObjectReady/<@resource://devtools/shared/transport/transport.js:464:22\nexports.makeInfallible/<@resource://devtools/shared/ThreadSafeDevToolsUtils.js:111:22\nexports.makeInfallible/<@resource://devtools/shared/ThreadSafeDevToolsUtils.js:111:22\n"

Comment 1

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Attachment: Bug 1599745 - Fix the profiler popup panel preference test. r?julienw

Comment 2

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Attachment: Bug 1599745 - Register all performance panel recording preferences and move their default values there. r?julienw

Depends on D55101

Comment 3

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Attachment: Bug 1599745 - Use the constant pref variables inside the file instead of hardcoding them. r?julienw

Depends on D55102

Comment 4

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Attachment: Bug 1599745 - Update default values of profiler recording preferences. r?julienw

This patch:

• Removes the responsiveness feature from the default features since we don't
  have it anymore.
• Adds "Renderer" thread to the default threads list. That is needed to capture
  screenshots with webrender.

Depends on D55103

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8eec098bba7e
Fix the profiler popup panel preference test. r=julienw
https://hg.mozilla.org/integration/autoland/rev/08aa2c9f03ec
Register all performance panel recording preferences and move their default values there. r=julienw
https://hg.mozilla.org/integration/autoland/rev/6ca132d40e7e
Use the constant pref variables inside the file instead of hardcoding them. r=julienw
https://hg.mozilla.org/integration/autoland/rev/5312121b8b32
Update default values of profiler recording preferences. r=julienw

Comment 6

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/8eec098bba7e
https://hg.mozilla.org/mozilla-central/rev/08aa2c9f03ec
https://hg.mozilla.org/mozilla-central/rev/6ca132d40e7e
https://hg.mozilla.org/mozilla-central/rev/5312121b8b32

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/2328b40f1537
Port bug 1599745 - Register all performance panel recording preferences and move their default values there. rs=bustage-fix DONTBUILD