1599750 - The “Take Your Settings with You” card should not be displayed if the `identity.fxaccounts.enabled` preference is set to `false`

Status: RESOLVED INVALID

(Firefox :: Messaging System, enhancement)

Description

[Andreea Cupsa [:acupsa], Experiments QA]

Attachment: Sign in to sync card displayed if fxa is disabled.gif

[Notes]:

• If the user clicks the “Sign in to Sync” button from the “Take Your Settings with You” and they try to log in to sync the firefox accounts page will remain in a loop after adding an email and clicking the “Continue” button.
• However, having the “Take Your Settings with You” option displayed to users who have the identity.fxaccounts.enabled preference set to false might influence them into changing the preference into true in order to be able to sign in to sync and benefit from the products linked to it.

[Affected versions]:

• Firefox Nightly 72.0a1, Build ID: 20191126212708

[Affected Platforms]:

• All Windows
• All Mac
• All Linux

[Prerequisites]:

• Have the following settings:
  • identity.fxaccounts.enabled preference set to false
  • trailhead.firstrun.branches preference set to join-dynamic value.

[Steps to reproduce]:

1. Open the browser from the prerequisites.
2. Open a new tab and observe the displayed cards.

[Expected result]:

• The “Stay Alert to Data Breaches”, “Browse Privately”, and “Instantly Send Yourself Tabs” cards are displayed.

[Actual result]:

• The “Take Your Settings with You”, “Stay Alert to Data Breaches”, and “Instantly Send Yourself Tabs” cards are displayed.

[Additional Notes]:

• Attached a screen recording of the issue.

Comment 1

[Punam Dahiya [:pdahiya]]

As of now the skip condition for Sync card checks if user has sync enabled and uses firefox Sync and has pref "services.sync.username" set. https://searchfox.org/mozilla-central/source/browser/components/newtab/lib/OnboardingMessageProvider.jsm#271

It will be easy to include an additional check to skip Sync card if user has disabled firefox account i.e pref 'identity.fxaccounts.enabled' to false. NI Jim to weigh in adding fxaccounts disabled in skip condition.

From looking at the code by default 'identity.fxaccounts.enabled' is true and only false for enterprise. Not sure about various usecases when fx accounts are disabled?
https://searchfox.org/mozilla-central/source/browser/components/enterprisepolicies/Policies.jsm#416

Comment 2

[Jim T]

Yes, suppressing the sync card if identity.fxaccounts.enabled=false is fine. I'm not sure exactly when else accounts are disabled, but with enterprise builds as an example it can be skipped in our targeting for sync-related messages.

Comment 3

[Kate Hudson :k88hudson]

This is working as expected.