Closed Bug 1599772 Opened 5 years ago Closed 4 years ago

[wpt-sync] Sync PR 20479 - Move `Sec-Fetch-User` to SetSecFetchMetadataHeaders.

Categories

(Core :: DOM: Networking, task, P5)

Product:
Core
Component:
DOM: Networking
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla73
Tracking Flags:
Tracking Status
firefox73 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [necko-triaged][wptsync downstream])

Sync web-platform-tests PR 20479 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/20479
Details from upstream follow.

Yifan Luo <lyf@google.com> wrote:

Move Sec-Fetch-User to SetSecFetchMetadataHeaders.

Rather than setting Sec-Fetch-User in
NavigationRequest::AddAdditionalRequestHeaders, it should be set in
SetFetchMetadataHeaders along with the others.

Bug: 1027528
Change-Id: I42c16dadceb7b4e69165bab67734a09747eb35a7
Reviewed-on: https://chromium-review.googlesource.com/1930742
WPT-Export-Revision: 8554ba174c1c4068ed1740f761ac53056d4ade99

Component: web-platform-tests → DOM: Networking
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream][necko-triaged]
Whiteboard: [wptsync downstream][necko-triaged] → [wptsync downstream]
Priority: P4 → P5
Whiteboard: [wptsync downstream] → [necko-triaged][wptsync downstream]

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 30 subtests

Status Summary

Firefox

OK : 1
PASS : 9
FAIL : 21

Chrome

PASS : 25
TIMEOUT: 2

Safari

PASS : 6
FAIL : 9
TIMEOUT: 4

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/fetch/metadata/form.tentative.https.sub.html
web-platform.test -> www.web-platform.test:8443 iframe: forced: sec-fetch-site: FAIL (Chrome: PASS, Safari: FAIL)
web-platform.test -> www.not-web-platform.test:8443 iframe: user-activated: sec-fetch-mode: FAIL
web-platform.test -> web-platform.test:8443 iframe: forced: sec-fetch-dest: FAIL (Chrome: PASS, Safari: FAIL)
web-platform.test -> www.not-web-platform.test:8443 iframe: forced: sec-fetch-mode: FAIL (Chrome: PASS, Safari: FAIL)
web-platform.test -> web-platform.test:8443 iframe: forced: sec-fetch-site: FAIL (Chrome: PASS, Safari: FAIL)
web-platform.test -> www.not-web-platform.test:8443 iframe: user-activated: sec-fetch-dest: FAIL
web-platform.test -> web-platform.test:8443 iframe: user-activated: sec-fetch-user: FAIL (Chrome: PASS)
web-platform.test -> www.not-web-platform.test:8443 iframe: user-activated: sec-fetch-site: FAIL
web-platform.test -> www.web-platform.test:8443 iframe: user-activated: sec-fetch-mode: FAIL (Chrome: PASS)
web-platform.test -> web-platform.test:8443 iframe: user-activated: sec-fetch-dest: FAIL (Chrome: PASS)
web-platform.test -> web-platform.test:8443 iframe: user-activated: sec-fetch-mode: FAIL (Chrome: PASS)
web-platform.test -> web-platform.test:8443 iframe: forced: sec-fetch-mode: FAIL (Chrome: PASS, Safari: FAIL)
web-platform.test -> www.not-web-platform.test:8443 iframe: forced: sec-fetch-dest: FAIL (Chrome: PASS, Safari: FAIL)
web-platform.test -> www.not-web-platform.test:8443 iframe: forced: sec-fetch-site: FAIL (Chrome: PASS, Safari: FAIL)
web-platform.test -> www.web-platform.test:8443 iframe: forced: sec-fetch-dest: FAIL (Chrome: PASS, Safari: FAIL)
web-platform.test -> www.web-platform.test:8443 iframe: forced: sec-fetch-mode: FAIL (Chrome: PASS, Safari: FAIL)
web-platform.test -> www.web-platform.test:8443 iframe: user-activated: sec-fetch-user: FAIL (Chrome: PASS)
web-platform.test -> www.web-platform.test:8443 iframe: user-activated: sec-fetch-dest: FAIL (Chrome: PASS)
web-platform.test -> www.not-web-platform.test:8443 iframe: user-activated: sec-fetch-user: FAIL
web-platform.test -> www.web-platform.test:8443 iframe: user-activated: sec-fetch-site: FAIL (Chrome: PASS)
web-platform.test -> web-platform.test:8443 iframe: user-activated: sec-fetch-site: FAIL (Chrome: PASS)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/07c742184fc2
[wpt PR 20479] - Move `Sec-Fetch-User` to SetSecFetchMetadataHeaders., a=testonly
https://hg.mozilla.org/integration/autoland/rev/9acf2557573b
[wpt PR 20479] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/07c742184fc2
https://hg.mozilla.org/mozilla-central/rev/9acf2557573b

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox73: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
You need to log in before you can comment on or make changes to this bug.