Implement Page.frameDetached
Categories
(Remote Protocol :: CDP, task, P1)
Tracking
(firefox78 fixed)
Tracking | Status | |
---|---|---|
firefox78 | --- | fixed |
People
(Reporter: whimboo, Assigned: whimboo)
References
()
Details
(Whiteboard: [puppeteer-beta-mvp])
Attachments
(1 file)
This is the implementation bug for bug 1549513. Moving over the puppeteer-alpha whiteboard entry.
Updated•5 years ago
|
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 1•5 years ago
|
||
After some investigation yesterday we can actually go ahead without the JSWindowActor implemenation (bug 1565162).
Assignee | ||
Comment 2•5 years ago
|
||
Depends on D71292
Comment 5•5 years ago
|
||
Backed out for mochitest failure on browser_frameAttached.js
Backout link: https://hg.mozilla.org/integration/autoland/rev/a17f298dd7885dd6eb6bc558ce15e65a1395e461
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=302816840&repo=autoland&lineNumber=4719
Assignee | ||
Updated•5 years ago
|
Comment 7•5 years ago
|
||
Backed out 2 changesets (bug 1599773, bug 1599413) for browser_frameAttached.js failures.
Backout link: https://hg.mozilla.org/integration/autoland/rev/0f440282ada89ad47b96c81b541e52259bd7eb20
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=302874776&repo=autoland&lineNumber=4711
...
[task 2020-05-19T09:23:48.098Z] 09:23:48 INFO - Leaving test bound eventWhenNavigatingWithFrames
[task 2020-05-19T09:23:48.099Z] 09:23:48 INFO - Entering test bound eventWhenNavigatingWithNestedFrames
[task 2020-05-19T09:23:48.099Z] 09:23:48 INFO - CDP server started
[task 2020-05-19T09:23:48.100Z] 09:23:48 INFO - Buffered messages logged at 09:23:47
[task 2020-05-19T09:23:48.100Z] 09:23:48 INFO - CDP client instantiated
[task 2020-05-19T09:23:48.101Z] 09:23:48 INFO - Navigate to a page with nested iframes
[task 2020-05-19T09:23:48.102Z] 09:23:48 INFO - TEST-PASS | remote/test/browser/page/browser_frameAttached.js | Expected amount of frames added -
[task 2020-05-19T09:23:48.102Z] 09:23:48 INFO - TEST-PASS | remote/test/browser/page/browser_frameAttached.js | Received the expected amount of frameAttached events -
[task 2020-05-19T09:23:48.103Z] 09:23:48 INFO - TEST-PASS | remote/test/browser/page/browser_frameAttached.js | Found expected frame with id 2147483653 -
[task 2020-05-19T09:23:48.104Z] 09:23:48 INFO - TEST-PASS | remote/test/browser/page/browser_frameAttached.js | Got expected frame id for frameAttached event -
[task 2020-05-19T09:23:48.104Z] 09:23:48 INFO - TEST-PASS | remote/test/browser/page/browser_frameAttached.js | Got expected parent frame id for frameAttached event -
[task 2020-05-19T09:23:48.105Z] 09:23:48 INFO - TEST-PASS | remote/test/browser/page/browser_frameAttached.js | Found expected frame with id 2147483654 -
[task 2020-05-19T09:23:48.105Z] 09:23:48 INFO - TEST-PASS | remote/test/browser/page/browser_frameAttached.js | Got expected frame id for frameAttached event -
[task 2020-05-19T09:23:48.106Z] 09:23:48 INFO - TEST-PASS | remote/test/browser/page/browser_frameAttached.js | Got expected parent frame id for frameAttached event -
[task 2020-05-19T09:23:48.107Z] 09:23:48 INFO - CDP client closed
[task 2020-05-19T09:23:48.108Z] 09:23:48 INFO - CDP server stopped
[task 2020-05-19T09:23:48.108Z] 09:23:48 INFO - Leaving test bound eventWhenNavigatingWithNestedFrames
[task 2020-05-19T09:23:48.109Z] 09:23:48 INFO - Entering test bound eventWhenAttachingFrame
[task 2020-05-19T09:23:48.109Z] 09:23:48 INFO - CDP server started
[task 2020-05-19T09:23:48.110Z] 09:23:48 INFO - CDP client instantiated
[task 2020-05-19T09:23:48.110Z] 09:23:48 INFO - TEST-PASS | remote/test/browser/page/browser_frameAttached.js | Expected amount of frames added -
[task 2020-05-19T09:23:48.111Z] 09:23:48 INFO - Buffered messages finished
[task 2020-05-19T09:23:48.112Z] 09:23:48 INFO - TEST-UNEXPECTED-FAIL | remote/test/browser/page/browser_frameAttached.js | Received the expected amount of frameAttached events - Got 0, expected 1
[task 2020-05-19T09:23:48.112Z] 09:23:48 INFO - Stack trace:
[task 2020-05-19T09:23:48.112Z] 09:23:48 INFO - chrome://mochikit/content/browser-test.js:test_is:1327
[task 2020-05-19T09:23:48.113Z] 09:23:48 INFO - chrome://mochitests/content/browser/remote/test/browser/page/browser_frameAttached.js:runFrameAttachedTest:107
[task 2020-05-19T09:23:48.113Z] 09:23:48 INFO - chrome://mochitests/content/browser/remote/test/browser/page/browser_frameAttached.js:eventWhenAttachingFrame:76
[task 2020-05-19T09:23:48.113Z] 09:23:48 INFO - chrome://mochitests/content/browser/remote/test/browser/head.js:fn:69
[task 2020-05-19T09:23:48.114Z] 09:23:48 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1064
[task 2020-05-19T09:23:48.114Z] 09:23:48 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1104
[task 2020-05-19T09:23:48.114Z] 09:23:48 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:927
[task 2020-05-19T09:23:48.114Z] 09:23:48 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:918
[task 2020-05-19T09:23:48.114Z] 09:23:48 INFO - GECKO(4280) | 1589880227766 RemoteAgent TRACE <-(connection {4c88504c-5e50-4f6f-ae65-c42b306ee92d}) {"method":"Target.targetDestroyed","params":{"targetId":"a7e2e8fd-6524-4a30-9fdf-cbf24dfe397c"}}
[task 2020-05-19T09:23:48.114Z] 09:23:48 INFO - CDP client closed
[task 2020-05-19T09:23:48.115Z] 09:23:48 INFO - GECKO(4280) | 1589880227799 RemoteAgent TRACE <-(connection {4c88504c-5e50-4f6f-ae65-c42b306ee92d}) {"method":"Target.targetDestroyed","params":{"targetId":"abca3ca7-0def-4be5-a6ca-adbc9766fde1"}}
[task 2020-05-19T09:23:48.116Z] 09:23:48 INFO - GECKO(4280) | 1589880227799 RemoteAgent TRACE <-(connection {4c88504c-5e50-4f6f-ae65-c42b306ee92d}) {"method":"Target.targetDestroyed","params":{"targetId":"456997c5-37c2-42ea-a74d-e837968a6891"}}
[task 2020-05-19T09:23:48.116Z] 09:23:48 INFO - CDP server stopped
[task 2020-05-19T09:23:48.116Z] 09:23:48 INFO - Leaving test bound eventWhenAttachingFrame
[task 2020-05-19T09:23:48.114Z] 09:23:48 INFO - CDP client closed
[task 2020-05-19T09:23:48.115Z] 09:23:48 INFO - GECKO(4280) | 1589880227799 RemoteAgent TRACE <-(connection {4c88504c-5e50-4f6f-ae65-c42b306ee92d}) {"method":"Target.targetDestroyed","params":{"targetId":"abca3ca7-0def-4be5-a6ca-adbc9766fde1"}}
[task 2020-05-19T09:23:48.116Z] 09:23:48 INFO - GECKO(4280) | 1589880227799 RemoteAgent TRACE <-(connection {4c88504c-5e50-4f6f-ae65-c42b306ee92d}) {"method":"Target.targetDestroyed","params":{"targetId":"456997c5-37c2-42ea-a74d-e837968a6891"}}
[task 2020-05-19T09:23:48.116Z] 09:23:48 INFO - CDP server stopped
[task 2020-05-19T09:23:48.116Z] 09:23:48 INFO - Leaving test bound eventWhenAttachingFrame
[task 2020-05-19T09:23:48.117Z] 09:23:48 INFO - GECKO(4280) | MEMORY STAT | vsize 3234MB | residentFast 409MB | heapAllocated 160MB
[task 2020-05-19T09:23:48.118Z] 09:23:48 INFO - TEST-OK | remote/test/browser/page/browser_frameAttached.js | took 3206ms
Assignee | ||
Comment 8•5 years ago
|
||
As you can see the problem is not with this patch but with frameAttached
which is bug 1599413. Remaining work will happen there.
Comment 10•5 years ago
|
||
bugherder |
Updated•4 years ago
|
Description
•