Closed Bug 1599802 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 20482 - Always update intervals using the "latest update time"

Categories

(Core :: SVG, task, P4)

task

Tracking

()

RESOLVED FIXED
mozilla73
Tracking Status
firefox73 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 20482 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/20482
Details from upstream follow.

Fredrik Söderquist <fs@opera.com> wrote:

Always update intervals using the "latest update time"

For interval updates performed "outside" of the regular flow in
SMILTimeContainer, we would use the "previous" presentation - i.e the
time just before the time we latest updated timing to. This could cause
elements to resolve intervals in the past - for example when the latest
update time was at the end of an interval it could discard the current
interval and resolve an interval in the past, which could then be
propagated to its dependents. When these elements were later updated by
the main update loop they would again discard the current (in the past)
interval and resolve a new one, notifying its dependents. Repeat.

Instead always use the "latest update time" (the same is used by
SMILTimeContainer::UpdateIntervals) as the argument to Updateinterval(),
and only use the "previous" presentation time when checking if the
active state may have changed in a relevant way and for rescheduling.

Bug: 1021630, 1028839
Change-Id: Ibe691ae336df51a36626fdd800e5ddc2303aee5a

Reviewed-on: https://chromium-review.googlesource.com/1939788
WPT-Export-Revision: bed13403223978019288045164fde5ea4574b3e5

Component: web-platform-tests → SVG
Product: Testing → Core

GitHub CI Results

wpt.fyi PR Results Base Results

Ran 2 tests and 2 subtests

Firefox

OK : 2
PASS: 2

Chrome

CRASH : 1
TIMEOUT: 1

Safari

OK : 1
PASS : 1
TIMEOUT: 2

Gecko CI Results

Ran 2 tests and 2 subtests
OK : 2
PASS : 2

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1252da20333a [wpt PR 20482] - Always update intervals using the "latest update time", a=testonly
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
You need to log in before you can comment on or make changes to this bug.