Closed Bug 1599843 Opened 10 months ago Closed 10 months ago

Make more functions that are really infallible not return an nsresult.

Categories

(Core :: General, task, P3)

task

Tracking

()

RESOLVED FIXED

People

(Reporter: emilio, Assigned: emilio)

References

(Blocks 1 open bug)

Details

Attachments

(19 files)

47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
No description provided.
Assignee: nobody → emilio

And is not virtual, so has no point in existing.

Depends on D54982

This one is a bit debatable. It seems one of the callers wanted to, but it may
be better to just simplify the code like this?

Depends on D54986

And should take Element, not nsIContent pointers.

Depends on D54993

And clean-up surrounding code by removing useless namespace qualification.

It seems like the first call to Broadcast is useless? Or am I missing something?

Attachment #9112017 - Attachment description: Bug 1599843 - nsJSProtocolHandler should be simpler. r=bzbarsky → Bug 1599843 - nsJSProtocolHandler construction should be simpler. r=bzbarsky
Keywords: leave-open
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d23626613180
nsJSProtocolHandler construction should be simpler. r=bzbarsky
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0ee583d8d3ec
nsBaseChannel::Init does nothing. r=valentin
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0367f510e5b6
Element::SetSMILOverrideStyleDeclaration is infallible. r=boris
https://hg.mozilla.org/integration/autoland/rev/758b24645eb1
Element::SetEventHandler is infallible. r=bzbarsky
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/96262ed235b7
BlobURLProtocolHandler::AddDataEntryInternal is infallible. r=baku
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/63ac52e30a0e
DOMSecurityManager::EnforeXFrameOptionsCheck is infallible. r=baku
https://hg.mozilla.org/integration/autoland/rev/676aefeaec6f
FileReader::OnLoadEnd is infallible. r=baku
https://hg.mozilla.org/integration/autoland/rev/81206cd8323e
FetchDriver::FinishOnStopRequest is infallible. r=baku
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/656cbf0f5324
nsDOMOfflineResourceList::SendEvent is infallible. r=smaug
https://hg.mozilla.org/integration/autoland/rev/bab326fa8876
nsDOMOfflineResourceList::UpdateCompleted is infallible. r=smaug
https://hg.mozilla.org/integration/autoland/rev/3a6fdb73e7ed
Nobody checks the result of nsDOMOfflineResourceList::AddUpdate. r=smaug
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/095d3360761b
Document::RemoteFrameFullscreen* are infallible. r=smaug
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c06b98b7957b
WebMDemuxer::Reset is infallible. r=jya
https://hg.mozilla.org/integration/autoland/rev/ffa6c0cc686e
VorbisState::ReconstructVorbisGranulepos is infallible. r=jya
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9ca0dfa0e6e6
GMPParent::CloneFrom is infallible. r=jya
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e72d0964995f
nsCommandManager::CommandStatusChanged is infallible. r=masayuki
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/114768b3f2b6
Document::ChangeContentEditableCount is infallible. r=masayuki
https://hg.mozilla.org/integration/autoland/rev/50ed857452ef
Document::SetEditingState is infallible. r=masayuki
Priority: -- → P3
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d046d735eccc
Make one variant of BlobURLProtocolHandler::AddDataEntry infallible. r=baku

Let's call this fixed, we can file more dependent bugs if needed.

Status: NEW → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.