1599843 - Make more functions that are really infallible not return an nsresult.

Status: RESOLVED FIXED

(Core :: General, task, P3)

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1599843 - nsCommandManager::CommandStatusChanged is infallible. r=masayuki

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1599843 - nsJSProtocolHandler construction should be simpler. r=bzbarsky

Depends on D54980

Comment 3

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1599843 - GMPParent::CloneFrom is infallible. r=jya

Depends on D54981

Comment 4

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1599843 - nsBaseChannel::Init does nothing. r=valentin

And is not virtual, so has no point in existing.

Depends on D54982

Comment 5

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1599843 - BlobURLProtocolHandler::AddDataEntryInternal is infallible. r=baku

Depends on D54983

Comment 6

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1599843 - nsDOMOfflineResourceList::SendEvent is infallible. r=smaug

Depends on D54984

Comment 7

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1599843 - nsDOMOfflineResourceList::UpdateCompleted is infallible. r=smaug

Depends on D54985

Comment 8

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1599843 - Nobody checks the result of nsDOMOfflineResourceList::AddUpdate. r=smaug

This one is a bit debatable. It seems one of the callers wanted to, but it may
be better to just simplify the code like this?

Depends on D54986

Comment 9

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1599843 - WebMDemuxer::Reset is infallible. r=jya

Depends on D54987

Comment 10

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1599843 - VorbisState::ReconstructVorbisGranulepos is infallible. r=jya

Depends on D54988

Comment 11

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1599843 - Document::RemoteFrameFullscreen* are infallible. r=smaug

Depends on D54989

Comment 12

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1599843 - DOMSecurityManager::EnforeXFrameOptionsCheck is infallible. r=baku

(and has a typo)

Depends on D54990

Comment 13

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1599843 - FileReader::OnLoadEnd is infallible. r=baku

Depends on D54991

Comment 14

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1599843 - FetchDriver::FinishOnStopRequest is infallible. r=baku

Depends on D54992

Comment 15

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1599843 - Document::ChangeContentEditableCount is infallible. r=masayuki

And should take Element, not nsIContent pointers.

Depends on D54993

Comment 16

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1599843 - Document::SetEditingState is infallible. r=masayuki

Depends on D54994

Comment 17

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1599843 - Element::SetSMILOverrideStyleDeclaration is infallible. r=boris

Depends on D54995

Comment 18

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1599843 - Element::SetEventHandler is infallible. r=bzbarsky

Depends on D54996

Comment 19

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1599843 - Make one variant of BlobURLProtocolHandler::AddDataEntry infallible. r=baku

And clean-up surrounding code by removing useless namespace qualification.

It seems like the first call to Broadcast is useless? Or am I missing something?

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d23626613180
nsJSProtocolHandler construction should be simpler. r=bzbarsky

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0ee583d8d3ec
nsBaseChannel::Init does nothing. r=valentin

Comment 22

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0367f510e5b6
Element::SetSMILOverrideStyleDeclaration is infallible. r=boris
https://hg.mozilla.org/integration/autoland/rev/758b24645eb1
Element::SetEventHandler is infallible. r=bzbarsky

Comment 23

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/96262ed235b7
BlobURLProtocolHandler::AddDataEntryInternal is infallible. r=baku

Comment 24

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/63ac52e30a0e
DOMSecurityManager::EnforeXFrameOptionsCheck is infallible. r=baku
https://hg.mozilla.org/integration/autoland/rev/676aefeaec6f
FileReader::OnLoadEnd is infallible. r=baku
https://hg.mozilla.org/integration/autoland/rev/81206cd8323e
FetchDriver::FinishOnStopRequest is infallible. r=baku

Comment 25

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/656cbf0f5324
nsDOMOfflineResourceList::SendEvent is infallible. r=smaug
https://hg.mozilla.org/integration/autoland/rev/bab326fa8876
nsDOMOfflineResourceList::UpdateCompleted is infallible. r=smaug
https://hg.mozilla.org/integration/autoland/rev/3a6fdb73e7ed
Nobody checks the result of nsDOMOfflineResourceList::AddUpdate. r=smaug

Comment 26

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/095d3360761b
Document::RemoteFrameFullscreen* are infallible. r=smaug

Comment 27

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c06b98b7957b
WebMDemuxer::Reset is infallible. r=jya
https://hg.mozilla.org/integration/autoland/rev/ffa6c0cc686e
VorbisState::ReconstructVorbisGranulepos is infallible. r=jya

Comment 28

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9ca0dfa0e6e6
GMPParent::CloneFrom is infallible. r=jya

Comment 29

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/d23626613180
https://hg.mozilla.org/mozilla-central/rev/0ee583d8d3ec
https://hg.mozilla.org/mozilla-central/rev/0367f510e5b6
https://hg.mozilla.org/mozilla-central/rev/758b24645eb1
https://hg.mozilla.org/mozilla-central/rev/96262ed235b7
https://hg.mozilla.org/mozilla-central/rev/63ac52e30a0e
https://hg.mozilla.org/mozilla-central/rev/676aefeaec6f
https://hg.mozilla.org/mozilla-central/rev/81206cd8323e
https://hg.mozilla.org/mozilla-central/rev/656cbf0f5324
https://hg.mozilla.org/mozilla-central/rev/bab326fa8876
https://hg.mozilla.org/mozilla-central/rev/3a6fdb73e7ed
https://hg.mozilla.org/mozilla-central/rev/095d3360761b
https://hg.mozilla.org/mozilla-central/rev/c06b98b7957b
https://hg.mozilla.org/mozilla-central/rev/ffa6c0cc686e
https://hg.mozilla.org/mozilla-central/rev/9ca0dfa0e6e6

Comment 30

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e72d0964995f
nsCommandManager::CommandStatusChanged is infallible. r=masayuki

Comment 31

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/114768b3f2b6
Document::ChangeContentEditableCount is infallible. r=masayuki
https://hg.mozilla.org/integration/autoland/rev/50ed857452ef
Document::SetEditingState is infallible. r=masayuki

Comment 32

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d046d735eccc
Make one variant of BlobURLProtocolHandler::AddDataEntry infallible. r=baku

Comment 33

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/e72d0964995f

Comment 34

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/114768b3f2b6
https://hg.mozilla.org/mozilla-central/rev/50ed857452ef
https://hg.mozilla.org/mozilla-central/rev/d046d735eccc

Comment 35

[Emilio Cobos Álvarez [:emilio]]

Let's call this fixed, we can file more dependent bugs if needed.