1599864 - when title has html tag doesn't shown on taskbar

Status: RESOLVED FIXED

(Firefox :: General, defect, P1)

Description

[ramazan.aktolu]

Attachment: 69551924-36681500-0fa6-11ea-9951-d1a95fd8b0f5.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:72.0) Gecko/20100101 Firefox/72.0

Steps to reproduce:

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/number

In link above, title contains HTML tag.
Title is not shown correct on the taskbar when contains HTML tag.

Expected results:

title on taskbar should show html taks in like title bar.

Comment 1

[Gingerbread Man]

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:72.0) Gecko/20100101 Firefox/72.0
20191125214644

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=eb874118621070fa4ef69cb951b2dd7a51f93d66&tochange=bff9eef8191f12cee9af275966a563517dcdf429

Comment 2

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: Bug 1599864 - Escape HTML tags when localizing window title.

Comment 3

[:Gijs (he/him)]

[Tracking Requested - why for this release]:
Broken primary UI on some pages.

(We should make sure this makes it to beta.)

Comment 4

[Staś Małolepszy :stas]

Attachment: Bug 1599864 - Ignore markup when localizing <title>. r?zbraniecki

Comment 5

[Zibi Braniecki [:zbraniecki][:gandalf]]

corresponding upstream change - https://github.com/projectfluent/fluent.js/pull/438

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c21f94d31eb5
Ignore markup when localizing <title>. r=zbraniecki

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/c21f94d31eb5

Comment 8

[Julien Cristau [:jcristau]]

Please request beta uplift when you get a chance.

Comment 9

[Julien Cristau [:jcristau]]

oops, set the wrong flag...

Comment 11

[Staś Małolepszy :stas]

Comment on attachment 9113422 [details]
Bug 1599864 - Ignore markup when localizing <title>. r?zbraniecki

Beta/Release Uplift Approval Request

• User impact if declined: Broken window title (in the title bar, the taskbar, the task switcher etc.) when the current page's title includes the < character. Examples of affected websites:

• documentation of HTML elements,
• documentation of React components,
• when < is used to indicate hierarchy,
• when < is used for stylized punctuation.

• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The fix special-cases the HTML <title> element, without affecting any other elements.
• String changes made/needed:

Comment 12

[Julien Cristau [:jcristau]]

Comment on attachment 9113422 [details]
Bug 1599864 - Ignore markup when localizing <title>. r?zbraniecki

i18n regression fix, approved for 72.0b5

Comment 13

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/releases/mozilla-beta/rev/dc96a8aa9952