1599879 - [Automated review] Reviewbot found 0 defects and gave me an empty patch to fix them

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, defect)

Description

[Markus Stange [:mstange]]

Phabricator URL: https://phabricator.services.mozilla.com/D54858#1668540

I had a build error in an earlier patch in the stack.

Comment 1

[Sylvestre Ledru [:Sylvestre]]

As we discussed earlier, we should disable this

Comment 2

[Marco Castelluccio [:marco]]

(In reply to Sylvestre Ledru [:Sylvestre] from comment #1)

As we discussed earlier, we should disable this

It might be related (maybe caused by the same patch?), but this looks like a different bug: the clang-format task was successful, produced an empty patch and the bot published that empty patch.
So simply disabling the notification of task failures won't fix this.

Bastien, could you check if https://github.com/mozilla/code-review/commit/7765e892736d227e2936cf4a6f2a74e69b61e81a is the cause?

Comment 3

[Bastien Abadie [:bastien]]

I'm on it: https://github.com/mozilla/code-review/issues/280

Comment 4

[Marco Bonardo [:mak]]

same thing happened to me here https://phabricator.services.mozilla.com/D55289

Comment 6

[Marco Castelluccio [:marco]]

This is fixed, the fix will likely be deployed on Monday.

Comment 8

[Marco Castelluccio [:marco]]

The fix has been deployed (with a little delay).