Closed Bug 1599913 Opened 2 years ago Closed 4 months ago

Audit usage of nsLayoutUtils::GetCrossDocParentFrame

Categories

(Core :: Layout, task, P2)

task

Tracking

()

RESOLVED FIXED
Fission Milestone Future
Tracking Status
firefox92 --- affected

People

(Reporter: hiro, Assigned: hiro)

References

(Depends on 2 open bugs, Blocks 1 open bug, )

Details

It just works fine in the same process, it doesn't mean GetCrossDocParentFrameCrossProcess, we might want to rename the original one to GetCrosssDocParentFrameInProcess.

Hiro, do you know who can work on this to audit the usages to ensure they are not expected to work cross-processes, and also rename the method for clarity?

Fission Milestone: --- → ?
Flags: needinfo?(hikezoe.birchill)

I believe everyone in our layout team should be able to work on this. I will recruit a volunteer on this tomorrow in Matrix.

Depends on: 1698680

I can take a look at auditing some of the callers tomorrow.

Flags: needinfo?(dholbert)
Depends on: 1698693
Depends on: 1698989
Depends on: 1699000
Depends on: 1699029
Depends on: 1699031
Depends on: 1699302
Depends on: 1699354
Depends on: 1699810
See Also: → 1699846
Depends on: 1699853
See Also: → 1699902

tnikkel, which Fission milestone should this bug block: Fission Beta or Release?

Should bug 1699902 also block Fission?

Flags: needinfo?(tnikkel)

(In reply to Chris Peterson [:cpeterson] from comment #4)

tnikkel, which Fission milestone should this bug block: Fission Beta or Release?

That's hard to say because we don't know what issues the audit would uncover, but it seems like if there were significant issues they would have come up already, so release seems okay.

Should bug 1699902 also block Fission?

Yes.

Flags: needinfo?(tnikkel)

(In reply to Timothy Nikkel (:tnikkel) from comment #5)

(In reply to Chris Peterson [:cpeterson] from comment #4)

tnikkel, which Fission milestone should this bug block: Fission Beta or Release?

That's hard to say because we don't know what issues the audit would uncover, but it seems like if there were significant issues they would have come up already, so release seems okay.

Since we won't know if there are significant issues until we audit the code, let's try to audit the code before our next Fission Beta milestone (M7a). If there are serious issues found, we'll then have time to fix them for M7a.

Fission Milestone: ? → M7a
Depends on: 1700245
Flags: needinfo?(hikezoe.birchill)
Flags: needinfo?(dholbert)

Daniel, I see that you created multiple sub-bugs, most of which are now fixed - thank you!
Is the audit complete at this point or are there callers still left to be accounted for?

Flags: needinfo?(dholbert)

It's not complete.

Depends on: 1706516
Depends on: 1649440

Note, the calls in nsDOMWindowUtils.cpp (for nsDOMWindowUtils::ZoomToFocusedInput and its helper CollectScrollableAncestors) are basically covered by bug 1649440.

Depends on: 1698987
Depends on: 1707964
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Flags: needinfo?(dholbert)

Rolling over the remaining Fission M7a bugs to the Fission M8 milestone.

Fission Milestone: M7a → M8
Priority: P3 → P2

This bug is a soft blocker for Fission M8. We'd like to fix it before our M8 Release experiment, but we won't delay the experiment waiting for it.

Whiteboard: fission-soft-blocker

For reference, the remaining callsites here are https://searchfox.org/mozilla-central/search?q=GetCrossDocParentFrame(&path=

(Ideally all of those will eventually move to this list, if they all pass the audit:
https://searchfox.org/mozilla-central/search?q=GetCrossDocParentFrameInProcess%28&path= )

Taking over.

Assignee: dholbert → hikezoe.birchill

Thanks Hiro!

Depends on: 1724327

The two calls in nsDOMWindowUtils.cpp, this and this should be handled in bug 1649440, a mobile specific one. That said, I believe those two can be replaced with the in-process version, since for bug 1649440 we'll have to take a different route to handle the cases across process boundaries.

Depends on: 1725548
Depends on: 1725549
Depends on: 1725893
Depends on: 1726081
Depends on: 1726261
Depends on: 1727229

Deferring this bug from Fission Milestone M8 to MVP. This bug doesn't need to block our Release channel experiment (M8) and we wouldn't uplift a fix to Beta 92 this late in the beta cycle.

Fission Milestone: M8 → MVP
Depends on: 1727431
Depends on: 1727434
Depends on: 1727674

Now I've filed bugs for all call sites of GetCrossDocParentFrame.

Setting Fission Milestone to Future because we don't need to track this meta bug as a Fission MVP blocker. All bugs blocking this meta bug have their own Fission Milestone flags set to Future or MVP.

Fission Milestone: MVP → Future
Whiteboard: fission-soft-blocker

Closing since we've already audited all call sites of the function.

Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.