Closed Bug 1599934 Opened 5 years ago Closed 4 years ago

[wpt-sync] Sync PR 20492 - Fix play controls for composited animations.

Categories

(Core :: DOM: Animation, task, P4)

Product:
Core
Component:
DOM: Animation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla73
Tracking Flags:
Tracking Status
firefox73 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 20492 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/20492
Details from upstream follow.

Kevin Ellis <kevers@chromium.org> wrote:

Fix play controls for composited animations.

Play controls recently broke for composited animations due to timing
differences on when variables are changes. Per spec, the start time is
not cleared when pausing an animation until after the animation is
ready. This discrepancy lead to a case when PreCommit would not get
called when pausing a composited animation.

Reverse and updatePlaybackRate were also broken for composited
animations. We cannot composite infinite duration animations in the
reverse direction. We were using playback rate instead of
EffectivePlaybackRate in one of our checks for compositor eligibility,
and falling to catch this case.

Finally, with changes to when start time is cleared, we can be in a
case where it is important to preserve the start time or the current
time when starting a composited animation. Fortunately, we can
determine when start time is the important factor based in whether the
animation is pending.

Next step: Add WPT tests that would have caught the regressions. Filed
as issue 1029123.

Bug: 1028985, 1028986
Change-Id: I4edf851790a860d20962df84944558e7dbc1863a
Reviewed-on: https://chromium-review.googlesource.com/1940885
WPT-Export-Revision: 18aa9610358cb465460c63a8136fc88a4948169c

Component: web-platform-tests → DOM: Animation
Product: Testing → Core
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → INVALID
Status: RESOLVED → REOPENED
Resolution: INVALID → ---
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1c07c74ffa24
[wpt PR 20492] - Fix play controls for composited animations., a=testonly
https://hg.mozilla.org/integration/autoland/rev/652d5fae96e8
[wpt PR 20492] - Update wpt metadata, a=testonly
Test result changes from PR not available.

https://hg.mozilla.org/mozilla-central/rev/1c07c74ffa24
https://hg.mozilla.org/mozilla-central/rev/652d5fae96e8

Status: REOPENED → RESOLVED
Closed: 5 years ago → 4 years ago
status-firefox73: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
You need to log in before you can comment on or make changes to this bug.