Closed Bug 1599947 Opened 5 years ago Closed 4 years ago

ubuntu1804 - editor/libeditor/tests/test_password_per_word_operation.html | Double clicking on the anonymous div element in a password field should select the last word - got +0, expected 7

Categories

(Core :: DOM: Editor, defect, P5)

Product:
Core
Component:
DOM: Editor
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla73
Tracking Flags:
Tracking Status
firefox73 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: masayuki)

References

Details

Attachments

(1 file)

Bug 1599947 - Make test_password_per_word_operation.html compute click position from editor root element rect and its text node rect r=smaug!
47 bytes, text/x-phabricator-request
Details | Review

Filed by: egao [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=278536353&repo=try
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/M3iHYB-dQqibGUCmlUcQ8A/runs/0/artifacts/public/logs/live_backing.log

suite: mochitest
chunk: 4

context:
[task 2019-11-27T23:50:33.897Z] 23:50:33 INFO - TEST-START | editor/libeditor/tests/test_password_per_word_operation.html
[task 2019-11-27T23:50:34.015Z] 23:50:34 INFO - Not taking screenshot here: see the one that was previously logged
[task 2019-11-27T23:50:34.015Z] 23:50:34 INFO - Buffered messages logged at 23:50:33
[task 2019-11-27T23:50:34.015Z] 23:50:34 INFO - must wait for load
[task 2019-11-27T23:50:34.015Z] 23:50:34 INFO - TEST-PASS | editor/libeditor/tests/test_password_per_word_operation.html | Double clicking on the anonymous text node in a password field should select all
[task 2019-11-27T23:50:34.015Z] 23:50:34 INFO - TEST-PASS | editor/libeditor/tests/test_password_per_word_operation.html | Double clicking on the anonymous text node in a password field should select all
[task 2019-11-27T23:50:34.015Z] 23:50:34 INFO - TEST-PASS | editor/libeditor/tests/test_password_per_word_operation.html | Double clicking on the anonymous div element in a password field should select all
[task 2019-11-27T23:50:34.015Z] 23:50:34 INFO - TEST-PASS | editor/libeditor/tests/test_password_per_word_operation.html | Double clicking on the anonymous div element in a password field should select all
[task 2019-11-27T23:50:34.015Z] 23:50:34 INFO - TEST-PASS | editor/libeditor/tests/test_password_per_word_operation.html | Moving caret one word from the end should move caret to the start
[task 2019-11-27T23:50:34.015Z] 23:50:34 INFO - TEST-PASS | editor/libeditor/tests/test_password_per_word_operation.html | Moving caret one word from the start should move caret to the end
[task 2019-11-27T23:50:34.015Z] 23:50:34 INFO - TEST-PASS | editor/libeditor/tests/test_password_per_word_operation.html | Selecting one word from the end should move selection start to the start
[task 2019-11-27T23:50:34.015Z] 23:50:34 INFO - TEST-PASS | editor/libeditor/tests/test_password_per_word_operation.html | Selecting one word from the start should move selection end to the end
[task 2019-11-27T23:50:34.016Z] 23:50:34 INFO - TEST-PASS | editor/libeditor/tests/test_password_per_word_operation.html | Deleting one word from the end should delete all characters
[task 2019-11-27T23:50:34.016Z] 23:50:34 INFO - TEST-PASS | editor/libeditor/tests/test_password_per_word_operation.html | Deleting one word from the start should delete all characters
[task 2019-11-27T23:50:34.016Z] 23:50:34 INFO - TEST-PASS | editor/libeditor/tests/test_password_per_word_operation.html | Double clicking on the first word should select it
[task 2019-11-27T23:50:34.016Z] 23:50:34 INFO - TEST-PASS | editor/libeditor/tests/test_password_per_word_operation.html | Double clicking on the first word should select it
[task 2019-11-27T23:50:34.017Z] 23:50:34 INFO - Buffered messages finished
[task 2019-11-27T23:50:34.017Z] 23:50:34 INFO - TEST-UNEXPECTED-FAIL | editor/libeditor/tests/test_password_per_word_operation.html | Double clicking on the anonymous div element in a password field should select the last word - got +0, expected 7
[task 2019-11-27T23:50:34.017Z] 23:50:34 INFO - SimpleTest.is@SimpleTest/SimpleTest.js:322:16
[task 2019-11-27T23:50:34.018Z] 23:50:34 INFO - @editor/libeditor/tests/test_password_per_word_operation.html:88:5
[task 2019-11-27T23:50:34.018Z] 23:50:34 INFO - asyncfocusedOrLoaded/<@SimpleTest/SimpleTest.js:805:67
[task 2019-11-27T23:50:34.019Z] 23:50:34 INFO - Not taking screenshot here: see the one that was previously logged
[task 2019-11-27T23:50:34.020Z] 23:50:34 INFO - TEST-UNEXPECTED-FAIL | editor/libeditor/tests/test_password_per_word_operation.html | Double clicking on the anonymous div element in a password field should select the last word - got 6, expected 12
[task 2019-11-27T23:50:34.020Z] 23:50:34 INFO - SimpleTest.is@SimpleTest/SimpleTest.js:322:16
[task 2019-11-27T23:50:34.020Z] 23:50:34 INFO - @editor/libeditor/tests/test_password_per_word_operation.html:90:5
[task 2019-11-27T23:50:34.020Z] 23:50:34 INFO - asyncfocusedOrLoaded/<@SimpleTest/SimpleTest.js:805:67
[task 2019-11-27T23:50:34.021Z] 23:50:34 INFO - TEST-PASS | editor/libeditor/tests/test_password_per_word_operation.html | Moving caret one word from the end should move caret to end of the first word
[task 2019-11-27T23:50:34.021Z] 23:50:34 INFO - TEST-PASS | editor/libeditor/tests/test_password_per_word_operation.html | Moving caret one word from the start should move caret to start of the last word
[task 2019-11-27T23:50:34.022Z] 23:50:34 INFO - TEST-PASS | editor/libeditor/tests/test_password_per_word_operation.html | Selecting one word from the end should move selection start to end of the first word
[task 2019-11-27T23:50:34.023Z] 23:50:34 INFO - TEST-PASS | editor/libeditor/tests/test_password_per_word_operation.html | Selecting one word from the start should move selection end to start of the last word
[task 2019-11-27T23:50:34.023Z] 23:50:34 INFO - TEST-PASS | editor/libeditor/tests/test_password_per_word_operation.html | Deleting one word from the end should delete the last word
[task 2019-11-27T23:50:34.025Z] 23:50:34 INFO - TEST-PASS | editor/libeditor/tests/test_password_per_word_operation.html | Deleting one word from the start should delete the first word
[task 2019-11-27T23:50:34.029Z] 23:50:34 INFO - GECKO(5899) | MEMORY STAT | vsize 2620MB | residentFast 195MB | heapAllocated 28MB
[task 2019-11-27T23:50:34.038Z] 23:50:34 INFO - TEST-OK | editor/libeditor/tests/test_password_per_word_operation.html | took 143ms

:masayuki - I am observing a consistent failure of this test under ubuntu1804 test environment.

Would you be able to take a look, or redirect the ni to someone who may be able to comment, thanks!

Flags: needinfo?(masayuki)

As commented in bug 1599946, looks like the clicked point is not on the anonymous div element due to font size difference (the result means double click occurred on first word rather than the black area after the second (last) word). First I need the detail of the new environment.

Flags: needinfo?(masayuki) → needinfo?(egao)

I've noted some screen and font related details of the new environment in bug 1599946 as requested.

Flags: needinfo?(egao)
Assignee: nobody → masayuki
Status: NEW → ASSIGNED

test_password_per_word_operation.html uses magic number to consider
click point in <input> element. However, that causes permanent
failure on Ubuntu 18.04. Ideally, the click positions should be
computed dynamically. Therefore, this patch makes it use rect of
anonymous <div> element and rect of its child text node which can
be computed with Range.getBoundingClientRect().

Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/44082bd5bbbd
Make test_password_per_word_operation.html compute click position from editor root element rect and its text node rect r=smaug

https://hg.mozilla.org/mozilla-central/rev/44082bd5bbbd

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox73: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: