Closed Bug 1599986 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 20496 - [webnfc] Remove NDEFErrorEvent

Categories

(Core :: DOM: Device Interfaces, task, P4)

task

Tracking

()

RESOLVED FIXED
mozilla73
Tracking Status
firefox73 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 20496 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/20496
Details from upstream follow.

Leon Han <leon.han@intel.com> wrote:

[webnfc] Remove NDEFErrorEvent

It's recommended to use the generice ErrorEvent rather than creating
unnecessary custom error event types.

The spec change:
https://github.com/w3c/web-nfc/pull/398

BUG=520391

Change-Id: Id8e02ed16d87d67fe36b6df4340a930893ca3b20

Reviewed-on: https://chromium-review.googlesource.com/1940814
WPT-Export-Revision: b2f5b906c5cb7cecb5757208e4fa8cdc60cd0d85

Component: web-platform-tests → DOM: Device Interfaces
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Test result changes from PR not available.

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 3 tests and 72 subtests

Status Summary

Firefox

OK : 3
PASS: 2
FAIL: 121

Chrome

OK : 3
PASS: 85
FAIL: 38

Safari

OK : 3
PASS: 2
FAIL: 121

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/web-nfc/NDEFWriter_push.https.html
Check that default NDEFPushOptions values are correctly set.: FAIL (Chrome: FAIL, Safari: FAIL)
NDEFWriter.push should fail when the NFC device does not expose NDEF technology.: FAIL (Chrome: FAIL, Safari: FAIL)
NDEFWriter.push should fail if user permission is not granted.: FAIL (Chrome: PASS, Safari: FAIL)
Test that NDEFWriter.push succeeds when message is ArrayBuffer.: FAIL (Chrome: FAIL, Safari: FAIL)
Reject promise with SyntaxError if WebNFC Id cannot be created from provided URL.: FAIL (Chrome: PASS, Safari: FAIL)
Test that recordType should be set to 'text' if NDEFRecordInit.record's recordType is undefined and NDEFRecordInit.record's data is DOMString.: FAIL (Chrome: FAIL, Safari: FAIL)
Test that NDEFWriter.push succeeds when message is DOMString.: FAIL (Chrome: FAIL, Safari: FAIL)
Test that promise is rejected with TypeError if NDEFMessageSource is invalid.: FAIL (Chrome: PASS, Safari: FAIL)
NDEFWriter.push should replace all previously configured push operations.: FAIL (Chrome: FAIL, Safari: FAIL)
NDEFWriter.push should succeed when NFC HW is enabled: FAIL (Chrome: FAIL, Safari: FAIL)
Test that recordType should be set to 'mime' if NDEFRecordInit.record's recordType is undefined and NDEFRecordInit.record's data is not DOMString.: FAIL (Chrome: FAIL, Safari: FAIL)
NDEFWriter.push should fail when NFC HW is not supported.: FAIL (Chrome: FAIL, Safari: FAIL)
NDEFWriter.push should fail when NFC HW is disabled.: FAIL (Chrome: FAIL, Safari: FAIL)
NDEFWriter.push NDEFMessage containing text, mime, unknown, url, absolute-url and external records with default NDEFPushOptions.: FAIL (Chrome: FAIL, Safari: FAIL)
NDEFWriter.push should fail if signal is not an AbortSignal.: FAIL (Chrome: PASS, Safari: FAIL)
NDEFWriter.push should fail if abort push request before push happends.: FAIL (Chrome: FAIL, Safari: FAIL)
Synchronously signaled abort.: FAIL (Chrome: FAIL, Safari: FAIL)
NDEFWriter.push should fail when there are NDEF records on the NFC device and NDEFPushOptions.overwrite is false.: FAIL (Chrome: FAIL, Safari: FAIL)
NDEFWriter.push should succeed to push data to an unformatted NFC device when the NDEFPushOptions.overwrite is false.: FAIL (Chrome: FAIL, Safari: FAIL)
Test that mediaType should be set to 'application/octet-stream' if NDEFRecordInit.record's recordType is 'mime' and NDEFRecordInit.record's mediaType is undefined.: FAIL (Chrome: FAIL, Safari: FAIL)
Test that promise is rejected with SyntaxError if NDEFMessageSource contains invalid records.: FAIL (Chrome: PASS, Safari: FAIL)
NDEFWriter.push should ignore reading data when ignoreRead is true.: FAIL (Chrome: FAIL, Safari: FAIL)
Test that WebNFC API is not accessible from iframe context.: FAIL (Chrome: PASS, Safari: FAIL)
Test that NDEFWriter.push succeeds when message is ArrayBufferView.: FAIL (Chrome: FAIL, Safari: FAIL)
NDEFWriter.push should read data when ignoreRead is false.: FAIL (Chrome: FAIL, Safari: FAIL)
NDEFWriter.push should fail with TypeError when invalid target value is provided.: FAIL (Chrome: PASS, Safari: FAIL)
NDEFWriter.push should fail if signal's aborted flag is set.: FAIL (Chrome: PASS, Safari: FAIL)
NDEFWriter.push should succeed to overwrite the existing data when the NDEFPushOptions.overwrite is true.: FAIL (Chrome: FAIL, Safari: FAIL)
NDEFWriter.push should fail if no implementation for NFC Mojo interface is available.: FAIL (Chrome: FAIL, Safari: FAIL)
Reject promise with NotSupportedError if NFC message size exceeds 32KB.: FAIL (Chrome: PASS, Safari: FAIL)
Check that provided NDEFPushOptions values are correctly converted.: FAIL (Chrome: FAIL, Safari: FAIL)
NDEFWriter.push with 'empty' record should succeed.: FAIL (Chrome: FAIL, Safari: FAIL)
/web-nfc/NDEFReader_scan.https.html
Test that NDEFReader.onreading should be fired on an unformatted NFC tag with empty records array for NDEFMessage.: FAIL (Chrome: FAIL, Safari: FAIL)
Test that nfc watch success if NFC HW is enabled.: FAIL (Chrome: FAIL, Safari: FAIL)
Test that NDEFReader.scan rejects if signal is not an AbortSignal.: FAIL (Chrome: PASS, Safari: FAIL)
NDEFRecord.toRecords returns its embedded records correctly.: FAIL (Chrome: FAIL, Safari: FAIL)
Test that NDEFReader.scan rejects if NDEFScanOptions.id is invalid.: FAIL (Chrome: PASS, Safari: FAIL)
Test that NDEFReader can not get any reading events once the signal aborts.: FAIL (Chrome: FAIL, Safari: FAIL)
Test that an error event happens if no implementation for NFC Mojo interface is available.: FAIL (Chrome: FAIL, Safari: FAIL)
Test that NDEFReader.scan rejects if NDEFScanOptions.signal is already aborted.: FAIL (Chrome: FAIL, Safari: FAIL)
Test that NDEFReader.scan rejects if NDEFScanOptions.signal aborts right after the scan invocation.: FAIL (Chrome: FAIL, Safari: FAIL)
Test that NDEFReader.onreading should not be fired if the NFC tag does not expose NDEF technology.: FAIL (Chrome: FAIL, Safari: FAIL)
Test that NDEFReader.scan succeeds if NDEFScanOptions.url is valid URL with '' wildcard character in the beginning of path component followed by subpath.: FAIL (Chrome: FAIL, Safari: FAIL)
NDEFReader.scan should fail if NFC HW is disabled.: FAIL (Chrome: FAIL, Safari: FAIL)
Test that NDEFReader.scan succeeds if NDEFScanOptions.url is valid URL with '
' wildcard character in path.: FAIL (Chrome: FAIL, Safari: FAIL)
NDEFReader.scan should fail if user permission is not granted.: FAIL (Chrome: PASS, Safari: FAIL)
Test that NDEFReader.scan succeeds if NDEFScanOptions.url is empty.: FAIL (Chrome: FAIL, Safari: FAIL)
Test that NDEFReader.scan rejects if NDEFScanOptions.id is missing components.: FAIL (Chrome: PASS, Safari: FAIL)
Test that NDEFReader.scan succeeds if NDEFScanOptions.url is valid URL.: FAIL (Chrome: FAIL, Safari: FAIL)
Test that NDEFReader.scan rejects if NDEFScanOptions.id has wrong protocol.: FAIL (Chrome: PASS, Safari: FAIL)
NDEFReader.scan should fail if NFC HW is not supported.: FAIL (Chrome: FAIL, Safari: FAIL)
/web-nfc/idlharness.https.window.html
NDEFReadingEvent interface: new NDEFReadingEvent("reading", { message: {"url":"/custom/path","records":[{"recordType":"text","data":"Hello World","id":"/custom/path"}]} }) must inherit property "serialNumber" with the proper type: FAIL (Chrome: PASS, Safari: FAIL)
NDEFReader must be primary interface of new NDEFReader();: FAIL (Chrome: PASS, Safari: FAIL)
NDEFRecord interface: existence and properties of interface object: FAIL (Chrome: PASS, Safari: FAIL)
NDEFMessage interface object length: FAIL (Chrome: PASS, Safari: FAIL)
NDEFReader interface object length: FAIL (Chrome: PASS, Safari: FAIL)
NDEFReader interface: attribute onerror: FAIL (Chrome: PASS, Safari: FAIL)
NDEFRecord interface: attribute id: FAIL (Chrome: PASS, Safari: FAIL)
NDEFWriter must be primary interface of new NDEFWriter();: FAIL (Chrome: PASS, Safari: FAIL)
NDEFReadingEvent interface: existence and properties of interface prototype object's @@unscopables property: FAIL (Chrome: PASS, Safari: FAIL)
NDEFRecord interface: new NDEFRecord({"recordType":"text","data":"Hello World","id":"/custom/path"}); must inherit property "mediaType" with the proper type: FAIL (Chrome: PASS, Safari: FAIL)
NDEFRecord interface: new NDEFRecord({"recordType":"text","data":"Hello World","id":"/custom/path"}); must inherit property "lang" with the proper type: FAIL (Chrome: PASS, Safari: FAIL)
NDEFRecord interface: new NDEFRecord({"recordType":"text","data":"Hello World","id":"/custom/path"}); must inherit property "toRecords()" with the proper type: FAIL (Chrome: PASS, Safari: FAIL)
NDEFReadingEvent interface: new NDEFReadingEvent("reading", { message: {"url":"/custom/path","records":[{"recordType":"text","data":"Hello World","id":"/custom/path"}]} }) must inherit property "message" with the proper type: FAIL (Chrome: PASS, Safari: FAIL)
NDEFRecord interface: existence and properties of interface prototype object's @@unscopables property: FAIL (Chrome: PASS, Safari: FAIL)
NDEFWriter interface: existence and properties of interface prototype object's "constructor" property: FAIL (Chrome: PASS, Safari: FAIL)
NDEFMessage interface: existence and properties of interface prototype object's "constructor" property: FAIL (Chrome: PASS, Safari: FAIL)
NDEFMessage interface: existence and properties of interface prototype object's @@unscopables property: FAIL (Chrome: PASS, Safari: FAIL)
NDEFReadingEvent must be primary interface of new NDEFReadingEvent("reading", { message: {"url":"/custom/path","records":[{"recordType":"text","data":"Hello World","id":"/custom/path"}]} }): FAIL (Chrome: PASS, Safari: FAIL)
NDEFRecord interface: attribute recordType: FAIL (Chrome: PASS, Safari: FAIL)
NDEFReadingEvent interface: existence and properties of interface prototype object's "constructor" property: FAIL (Chrome: PASS, Safari: FAIL)
NDEFReader interface: new NDEFReader(); must inherit property "onreading" with the proper type: FAIL (Chrome: PASS, Safari: FAIL)
Stringification of new NDEFWriter();: FAIL (Chrome: PASS, Safari: FAIL)
NDEFMessage interface object name: FAIL (Chrome: PASS, Safari: FAIL)
NDEFRecord interface: operation toRecords(): FAIL (Chrome: PASS, Safari: FAIL)
NDEFReadingEvent interface: attribute message: FAIL (Chrome: PASS, Safari: FAIL)
NDEFMessage interface: existence and properties of interface prototype object: FAIL (Chrome: PASS, Safari: FAIL)
NDEFWriter interface: existence and properties of interface prototype object: FAIL (Chrome: PASS, Safari: FAIL)
NDEFWriter interface: calling push(NDEFMessageSource, NDEFPushOptions) on new NDEFWriter(); with too few arguments must throw TypeError: FAIL (Chrome: PASS, Safari: FAIL)
NDEFRecord interface: new NDEFRecord({"recordType":"text","data":"Hello World","id":"/custom/path"}); must inherit property "recordType" with the proper type: FAIL (Chrome: PASS, Safari: FAIL)
NDEFReader interface: new NDEFReader(); must inherit property "scan(NDEFScanOptions)" with the proper type: FAIL (Chrome: PASS, Safari: FAIL)
NDEFWriter interface object name: FAIL (Chrome: PASS, Safari: FAIL)
NDEFRecord interface: new NDEFRecord({"recordType":"text","data":"Hello World","id":"/custom/path"}); must inherit property "id" with the proper type: FAIL (Chrome: PASS, Safari: FAIL)
NDEFReadingEvent interface object length: FAIL (Chrome: PASS, Safari: FAIL)
Stringification of new NDEFRecord({"recordType":"text","data":"Hello World","id":"/custom/path"});: FAIL (Chrome: PASS, Safari: FAIL)
NDEFRecord interface: attribute encoding: FAIL (Chrome: PASS, Safari: FAIL)
NDEFReadingEvent interface: existence and properties of interface object: FAIL (Chrome: PASS, Safari: FAIL)
NDEFRecord interface object length: FAIL (Chrome: PASS, Safari: FAIL)
NDEFMessage must be primary interface of new NDEFMessage({"url":"/custom/path","records":[{"recordType":"text","data":"Hello World","id":"/custom/path"}]});: FAIL (Chrome: PASS, Safari: FAIL)
NDEFReader interface object name: FAIL (Chrome: PASS, Safari: FAIL)
NDEFWriter interface: new NDEFWriter(); must inherit property "push(NDEFMessageSource, NDEFPushOptions)" with the proper type: FAIL (Chrome: PASS, Safari: FAIL)
NDEFMessage interface: new NDEFMessage({"url":"/custom/path","records":[{"recordType":"text","data":"Hello World","id":"/custom/path"}]}); must inherit property "records" with the proper type: FAIL (Chrome: PASS, Safari: FAIL)
NDEFReader interface: existence and properties of interface prototype object's @@unscopables property: FAIL (Chrome: PASS, Safari: FAIL)
NDEFReader interface: existence and properties of interface prototype object's "constructor" property: FAIL (Chrome: PASS, Safari: FAIL)
NDEFRecord interface: new NDEFRecord({"recordType":"text","data":"Hello World","id":"/custom/path"}); must inherit property "data" with the proper type: FAIL (Chrome: FAIL, Safari: FAIL)
NDEFWriter interface object length: FAIL (Chrome: PASS, Safari: FAIL)
NDEFRecord interface: attribute data: FAIL (Chrome: PASS, Safari: FAIL)
NDEFReader interface: new NDEFReader(); must inherit property "onerror" with the proper type: FAIL (Chrome: PASS, Safari: FAIL)
NDEFMessage interface: attribute records: FAIL (Chrome: PASS, Safari: FAIL)
NDEFRecord interface: attribute mediaType: FAIL (Chrome: PASS, Safari: FAIL)
NDEFReader interface: existence and properties of interface object: FAIL (Chrome: PASS, Safari: FAIL)
NDEFRecord interface: existence and properties of interface prototype object: FAIL (Chrome: PASS, Safari: FAIL)
NDEFReadingEvent interface: existence and properties of interface prototype object: FAIL (Chrome: PASS, Safari: FAIL)
NDEFReader interface: attribute onreading: FAIL (Chrome: PASS, Safari: FAIL)
NDEFReader interface: operation scan(NDEFScanOptions): FAIL (Chrome: PASS, Safari: FAIL)
NDEFMessage interface: existence and properties of interface object: FAIL (Chrome: PASS, Safari: FAIL)
NDEFRecord must be primary interface of new NDEFRecord({"recordType":"text","data":"Hello World","id":"/custom/path"});: FAIL (Chrome: PASS, Safari: FAIL)
NDEFWriter interface: operation push(NDEFMessageSource, NDEFPushOptions): FAIL (Chrome: PASS, Safari: FAIL)
NDEFReadingEvent interface object name: FAIL (Chrome: PASS, Safari: FAIL)
NDEFReader interface: existence and properties of interface prototype object: FAIL (Chrome: PASS, Safari: FAIL)
NDEFRecord interface: attribute lang: FAIL (Chrome: PASS, Safari: FAIL)
Stringification of new NDEFReader();: FAIL (Chrome: PASS, Safari: FAIL)
Stringification of new NDEFMessage({"url":"/custom/path","records":[{"recordType":"text","data":"Hello World","id":"/custom/path"}]});: FAIL (Chrome: PASS, Safari: FAIL)
NDEFReader interface: calling scan(NDEFScanOptions) on new NDEFReader(); with too few arguments must throw TypeError: FAIL (Chrome: PASS, Safari: FAIL)
NDEFReadingEvent interface: attribute serialNumber: FAIL (Chrome: PASS, Safari: FAIL)
NDEFRecord interface object name: FAIL (Chrome: PASS, Safari: FAIL)
NDEFRecord interface: existence and properties of interface prototype object's "constructor" property: FAIL (Chrome: PASS, Safari: FAIL)
NDEFWriter interface: existence and properties of interface prototype object's @@unscopables property: FAIL (Chrome: PASS, Safari: FAIL)
Stringification of new NDEFReadingEvent("reading", { message: {"url":"/custom/path","records":[{"recordType":"text","data":"Hello World","id":"/custom/path"}]} }): FAIL (Chrome: PASS, Safari: FAIL)
NDEFWriter interface: existence and properties of interface object: FAIL (Chrome: PASS, Safari: FAIL)
NDEFRecord interface: new NDEFRecord({"recordType":"text","data":"Hello World","id":"/custom/path"}); must inherit property "encoding" with the proper type: FAIL (Chrome: PASS, Safari: FAIL)

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
You need to log in before you can comment on or make changes to this bug.