Closed Bug 1600012 Opened 5 years ago Closed 10 months ago

[wpt-sync] Sync PR 20498 - Service Worker: Correct the evaluation order in wait_for_state()

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(Not tracked)

RESOLVED INVALID

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 20498 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/20498
Details from upstream follow.

Yuta Kasai <yutakasai@google.com> wrote:

Service Worker: Correct the evaluation order in wait_for_state()

Currently, wait_for_state() in test-helpers.sub.js for a service worker only
checks equivalence of the state to the specific state, so it can wait forever if
the worker unexpectedly skip the state or it's unexpectedly evicted. This patch
changes the evaluation order properly by replaceing this checking equivalence of
the state after adding the event handler.

Change-Id: I0bc90cc92b1ab2eca92872c9199c5a500e23734c
Bug: 1000544
Reviewed-on: https://chromium-review.googlesource.com/1941729
WPT-Export-Revision: b655a589b2bf57abe207895ccc6dd6348fec8fe1

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → INVALID
Status: RESOLVED → REOPENED
Resolution: INVALID → ---
Severity: normal → S3
Status: REOPENED → RESOLVED
Closed: 5 years ago10 months ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.