Closed Bug 1600058 Opened 3 years ago Closed 3 years ago

Implement IO.close

Categories

(Remote Protocol :: CDP, task, P1)

Product:
Remote Protocol
Component:
CDP
Type:
task

Tracking

(firefox73 fixed)

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
firefox73 --- fixed

People

(Reporter: whimboo, Assigned: whimboo)

References

(Blocks 1 open bug,
URL
)

Details

(Whiteboard: [puppeteer-beta-mvp])

Attachments

(1 file)

Bug 1600058 - [remote] Implement IO.close. r=#remote!
47 bytes, text/x-phabricator-request
Details | Review

This bug covers the implementation of the IO.close method. By definition it closes the stream, and discards any temporary backing storage. This method is needed for Page.printToPDF.

I just gave an update on bug 1600053. A patch is upcoming soon for this particular method. It only needs polishing and tests.

Whiteboard: [puppeteer-alpha-reserve] → [puppeteer-beta-mvp]
Keywords: meta
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0d87151679c2
[remote] Implement IO.close. r=remote-protocol-reviewers,ato,maja_zf

https://hg.mozilla.org/mozilla-central/rev/0d87151679c2

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox73: --- → fixed
Resolution: --- → FIXED
Component: CDP: IO → CDP
You need to log in before you can comment on or make changes to this bug.