1600127 - Can't revert secret after saving it without reloading the page

Status: RESOLVED FIXED

(Taskcluster :: UI, defect)

Description

[Marco Castelluccio [:marco]]

STR:

1. Open a secret's page;
2. Make some modification;
3. Save the modification;
4. Undo the modification.

Now, the "Save Secret" button is greyed out and it can't be clicked, so you can't really revert the secret to the old state unless you reload the page.

I'm guessing the page is storing the original value of the secret and greying out the button when the content of the textarea is the same as the original value. I guess the page should update the "original value" of the secret when it gets saved (indeed, I would expect the "Save Secret" button to get greyed out after you save, but it doesn't happen).

Comment 1

[Hassan Ali (:hassan)]

https://github.com/taskcluster/taskcluster/pull/2118

Comment 2

[Hassan Ali (:hassan)]

Resolved in https://github.com/taskcluster/taskcluster/commit/065b42e64f08f3ef3e7cbb1f8a868ecfc7aaa0ab. It will be deployed in Taskcluster v24.0.0.