Remove almost-dead-code Linux/Android content process niceness pref/env var code for single-core machines
Categories
(Core :: DOM: Content Processes, defect)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox73 | --- | fixed |
People
(Reporter: Gijs, Assigned: Gijs)
References
Details
(Whiteboard: [fxperf:p3])
Attachments
(1 file)
We look this up here:
The funny thing is, we probably don't ever need it on desktop (as it's only used if cpucount is 1, which I expect to be basically never on modern machines - it'll be 2 for anything with hyperthreading) and we also override it with an env var if set. We might want it on android still.
In any case, we should probably cache the result of whether we want to do this somewhere, rather than doing all the work every time.
|
Assignee | |
Comment 2•5 years ago
|
||
Oh, bonus, this was added in https://bugzilla.mozilla.org/show_bug.cgi?id=633986 for Maemo. Which I think was XUL fennec? Anyway, the pref is gone on android, AFAICT (this code getting it is the only hit), and isn't set on desktop, which means the value is 0 anyway so we never do anything. We should just rip this out.
|
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Comment 3•5 years ago
|
||
This was added for XUL fennec, which was dropped at the time of Firefox 7.
But we're still reading this pref and env var and system info data, so let's
stop doing that (also because 'cpucount' is unlikely to be 1 on modern
desktop machines, we're dropping arbitrary user pref sets for geckoview,
and I don't think it's even possible to set an env var for app execution
on android as a user - certainly not easy).
Depends on D55265
Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/autoland/rev/b45f47bb9911 rip out unused 'nice' handling for child processes on Linux/Android, r=mconley
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
Description
•