1600228 - Move the star ui edit bookmark panel to be lazy loaded

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, task, P2)

Description

[Zibi Braniecki [:zbraniecki][:gandalf]]

Spin-off from bug 1599303. It would be nice to lazify bookmark panel. It may require bug 1584189.

Comment 1

[:Gijs (he/him)]

This is the bookmark creation panel in the URL bar, so I think this goes in bookmarks & history. :-)

Comment 2

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Could you please be more specific about what you want to make lazy in the title? Is this just about Fluent?

Comment 3

[Zibi Braniecki [:zbraniecki][:gandalf]]

The idea was raised in bug 1599303 by Gijs to move the whole DOM to <template/> and only delazify it if needed, so no, it's not Fluent only. It's about not loading the DOM for pieces of UI that are lazily activated, eagerly.

Comment 4

[Mike Conley (:mconley) (:⚙️)]

This has the potential to save some time when parsing and laying out the initial window during startup, so making this an fxperf:p2.

Comment 5

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Adding bug 1612653 just for code bitrotting reasons...

Comment 6

[Emma Malysz]

Attachment: Bug 1600228, lazy load the edit bookmark panel by storing in an HTML template

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2befc9d57826
lazy load the edit bookmark panel by storing in an HTML template r=Gijs

Comment 8

[Cosmin Sabou [:CosminS]]

Backed out changeset 2befc9d57826 (Bug 1600228) for bc failures on browser_asrouter_bookmarkpanel.

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=2befc9d5782631501b25b1d8f3cd616fbdcd8221&selectedJob=292953812&searchStr=Linux%2C18.04%2Cx64%2Cdebug%2CMochitests%2Ctest-linux1804-64%2Fdebug-mochitest-browser-chrome-e10s-9%2CM%28bc9%29

Failure logs: https://treeherder.mozilla.org/logviewer.html#?job_id=292953812&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/646cac4be14fb75dd759ad0f1fbc97c097702921

[task 2020-03-13T00:47:27.321Z] 00:47:27 INFO - TEST-UNEXPECTED-FAIL | browser/components/newtab/test/browser/browser_asrouter_bookmarkpanel.js | Uncaught exception - at resource://activity-stream/lib/BookmarkPanelHub.jsm:132 - TypeError: can't access property "querySelector", target.container is null
[task 2020-03-13T00:47:27.321Z] 00:47:27 INFO - Stack trace:
[task 2020-03-13T00:47:27.321Z] 00:47:27 INFO - showMessage@resource://activity-stream/lib/BookmarkPanelHub.jsm:132:26
[task 2020-03-13T00:47:27.321Z] 00:47:27 INFO - onResponse@resource://activity-stream/lib/BookmarkPanelHub.jsm:112:12
[task 2020-03-13T00:47:27.321Z] 00:47:27 INFO - test_fxa_message_shown@chrome://mochitests/content/browser/browser/components/newtab/test/browser/browser_asrouter_bookmarkpanel.js:23:37
[task 2020-03-13T00:47:27.321Z] 00:47:27 INFO - Async*Tester_execTest/<@chrome://mochikit/content/browser-test.js:1062:34
[task 2020-03-13T00:47:27.321Z] 00:47:27 INFO - Tester_execTest@chrome://mochikit/content/browser-test.js:1097:11
[task 2020-03-13T00:47:27.321Z] 00:47:27 INFO - nextTest/<@chrome://mochikit/content/browser-test.js:925:14
[task 2020-03-13T00:47:27.322Z] 00:47:27 INFO - SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:918:23
[task 2020-03-13T00:47:27.322Z] 00:47:27 INFO - Leaving test bound test_fxa_message_shown
[task 2020-03-13T00:47:27.322Z] 00:47:27 INFO - GECKO(4551) | [Child 4842: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 0x7f831b11c800 == 0 [pid = 4842] [id = {d784e8dd-5d7a-43dd-a413-1784a78f7581}] [url = about:blank]
[task 2020-03-13T00:47:27.322Z] 00:47:27 INFO - Console message: [JavaScript Error: "The character encoding of the plain text document was not declared. The document will render with garbled text in some browser configurations if the document contains characters from outside the US-ASCII range. The character encoding of the file needs to be declared in the transfer protocol or file needs to use a byte order mark as an encoding signature." {file: "data:text/plain,test cfr fxa bookmark panel message" line: 0}]
[task 2020-03-13T00:47:27.511Z] 00:47:27 INFO - GECKO(4551) | [Child 4781: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 29 (0x7fd679e6f260) [pid = 4781] [serial = 45] [outer = (nil)] [url = about:newtab]
[task 2020-03-13T00:47:27.512Z] 00:47:27 INFO - GECKO(4551) | [Child 4781: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 0x7fd673e26000 == 10 [pid = 4781] [id = {6994e85b-2211-414e-8620-bc271ac59540}] [url = about:newtab]
[task 2020-03-13T00:47:27.512Z] 00:47:27 INFO - GECKO(4551) | [Child 4781: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 0x7fd6766f3000 == 9 [pid = 4781] [id = {da504012-039a-46fe-8122-830a831a702e}] [url = about:newtab]
[task 2020-03-13T00:47:27.512Z] 00:47:27 INFO - GECKO(4551) | [Child 4781: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 0x7fd6806f0000 == 8 [pid = 4781] [id = {3c778101-351c-48c4-a511-dcea7545233b}] [url = about:newtab]
[task 2020-03-13T00:47:27.512Z] 00:47:27 INFO - GECKO(4551) | [Child 4781: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 0x7fd673e1a000 == 7 [pid = 4781] [id = {0c83f25b-50b6-442c-bd47-fd429e5f77ae}] [url = about:welcome]
[task 2020-03-13T00:47:27.512Z] 00:47:27 INFO - GECKO(4551) | [Child 4781: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 0x7fd673e1d800 == 6 [pid = 4781] [id = {be6dd5c0-41b3-4310-baa9-7f6c2f54d9b0}] [url = about:welcome]
[task 2020-03-13T00:47:27.512Z] 00:47:27 INFO - GECKO(4551) | [Child 4781: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 28 (0x7fd679e72350) [pid = 4781] [serial = 37] [outer = (nil)] [url = about:welcome]
[task 2020-03-13T00:47:27.512Z] 00:47:27 INFO - GECKO(4551) | [Child 4781: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 27 (0x7fd679e728c0) [pid = 4781] [serial = 40] [outer = (nil)] [url = about:welcome]
[task 2020-03-13T00:47:27.512Z] 00:47:27 INFO - GECKO(4551) | [Child 4781: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 26 (0x7fd69b893520) [pid = 4781] [serial = 1] [outer = (nil)] [url = about:newtab]
[task 2020-03-13T00:47:27.512Z] 00:47:27 INFO - GECKO(4551) | [Child 4781: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 25 (0x7fd679e6f090) [pid = 4781] [serial = 43] [outer = (nil)] [url = about:newtab]
[task 2020-03-13T00:47:27.814Z] 00:47:27 INFO - GECKO(4551) | [Parent 4551, Main Thread] WARNING: Suboptimal indexes for the SQL statement 0x7f25c2152840 (http://mzl.la/1FuID0j).: file /builds/worker/checkouts/gecko/storage/mozStoragePrivateHelpers.cpp, line 106
[task 2020-03-13T00:47:27.914Z] 00:47:27 INFO - GECKO(4551) | MEMORY STAT | vsize 3019MB | residentFast 355MB | heapAllocated 121MB
[task 2020-03-13T00:47:27.914Z] 00:47:27 INFO - TEST-OK | browser/components/newtab/test/browser/browser_asrouter_bookmarkpanel.js | took 2200ms

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1dde34e3f385
lazy load the edit bookmark panel by storing in an HTML template r=Gijs

Comment 10

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/1dde34e3f385