1600267 - Adapt `nsContentUtils::ComparePoints` to return `Maybe<int32_t>`

Status: RESOLVED FIXED

(Core :: DOM: Selection, enhancement, P2)

Description

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

This allows to drop the aDisconnected argument and forces callers to handle that case.

Comment 1

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1600267: part 1) Rename `nsContentUtils::ComparePoints` to `ComparePoints_Deprecated`. r=smaug

In a follow-up commit a new ComparePoints method with cleaner
arguments and return value will be added.

Comment 2

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1600267: part 2) Add `Maybe<int32_t> nsContentUtils::ComparePoints`. r=smaug

Enforces callers to handle the case when the points are incomparable.

Depends on D55295

Comment 3

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1600267: part 3) Call `ComparePoints` instead of `ComparePoints_Deprecated` in `Abstractrange::SetStartAndEndInternal`. r=smaug

Depends on D55296

Comment 4

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1600267: part 4) Call `ComparePoints` instead of `ComparePoints_Deprecated` in FilteredContentIterator. r=smaug

Depends on D55297

Comment 5

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1600267: part 5) Call `ComparePoints` instead of `ComparePoints_Deprecated` in HyperTextAccessible. r=smaug

Depends on D55298

Comment 6

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1600267: part 6) Call `ComparePoints` instead of `ComparePoints_Deprecated` in ContentIterator. r=smaug

Depends on D55299

Comment 7

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1600267: part 7) Call `ComparePoints` instead of `ComparePoints_Deprecated` in RangeUtils. r=smaug

Depends on D55300

Comment 8

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1600267: part 8) Call `ComparePoints` instead of `ComparePoints_Deprecated` in Selection. r=smaug

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bf11fb46bd73
part 1) Rename `nsContentUtils::ComparePoints` to `ComparePoints_Deprecated`. r=smaug
https://hg.mozilla.org/integration/autoland/rev/bfc2e43909cd
part 2) Add `Maybe<int32_t> nsContentUtils::ComparePoints`. r=smaug
https://hg.mozilla.org/integration/autoland/rev/4459ef04ad8e
part 3) Call `ComparePoints` instead of `ComparePoints_Deprecated` in `Abstractrange::SetStartAndEndInternal`. r=smaug
https://hg.mozilla.org/integration/autoland/rev/2434dce2e742
part 4) Call `ComparePoints` instead of `ComparePoints_Deprecated` in FilteredContentIterator. r=smaug
https://hg.mozilla.org/integration/autoland/rev/71b50a4b6a86
part 5) Call `ComparePoints` instead of `ComparePoints_Deprecated` in HyperTextAccessible. r=smaug
https://hg.mozilla.org/integration/autoland/rev/cc05e6b3edd9
part 6) Call `ComparePoints` instead of `ComparePoints_Deprecated` in ContentIterator. r=smaug
https://hg.mozilla.org/integration/autoland/rev/a054102f2019
part 7) Call `ComparePoints` instead of `ComparePoints_Deprecated` in RangeUtils. r=smaug

Comment 10

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/bf11fb46bd73
https://hg.mozilla.org/mozilla-central/rev/bfc2e43909cd
https://hg.mozilla.org/mozilla-central/rev/4459ef04ad8e
https://hg.mozilla.org/mozilla-central/rev/2434dce2e742
https://hg.mozilla.org/mozilla-central/rev/71b50a4b6a86
https://hg.mozilla.org/mozilla-central/rev/cc05e6b3edd9
https://hg.mozilla.org/mozilla-central/rev/a054102f2019

Comment 11

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1600267: part 9) Call `ComparePoints` instead of `ComparePoints_Deprecated` in parts of `nsRange`. r=smaug

The remaining callers of ComparePoints_Deprecated in nsRange
presumably require changing the semantics of ComparePoints to support
comparison across Shadow DOM boundary.

Depends on D57615

Comment 12

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1600267: part 10) Call `ComparePoints` instead of `ComparePoints_Deprecated` in `ContentEventHandler`. r=masayuki

Depends on D57959

Comment 13

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1600267: part 11) Call `ComparePoints` instead of `ComparePoints_Deprecated` in `TextComposition`. r=masayuki

Comment 14

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1600267: part 12) Call `ComparePoints` instead of `ComparePoints_Deprecated` in `EditorBase`. r=masayuki

Depends on D57967

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ec5181104e87
part 8) Call `ComparePoints` instead of `ComparePoints_Deprecated` in Selection. r=smaug

Comment 16

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/ec5181104e87

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/655c310bdfe0
part 9) Call `ComparePoints` instead of `ComparePoints_Deprecated` in parts of `nsRange`. r=smaug
https://hg.mozilla.org/integration/autoland/rev/053e37a2547f
part 10) Call `ComparePoints` instead of `ComparePoints_Deprecated` in `ContentEventHandler`. r=masayuki
https://hg.mozilla.org/integration/autoland/rev/f6d4c4f8fca3
part 11) Call `ComparePoints` instead of `ComparePoints_Deprecated` in `TextComposition`. r=masayuki
https://hg.mozilla.org/integration/autoland/rev/c1747d1fcad0
part 12) Call `ComparePoints` instead of `ComparePoints_Deprecated` in `EditorBase`. r=masayuki

Comment 18

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1600267: part 13) Call `ComparePoints` instead of `ComparePoints_Deprecated` in `HTMLEditor`. r=masayuki

Comment 19

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1600267: part 14) Call `ComparePoints` instead of `ComparePoints_Deprecated` in `WSRunScanner`. r=masayuki

Comment 20

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1600267: part 15) Call `ComparePoints` instead of `ComparePoints_Deprecated` in `TextServicesDocument`. r=masayuki

Depends on D58912

Comment 21

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1600267: part 16) Call `ComparePoints` instead of `ComparePoints_Deprecated` in `AccessibleCaretManager`. r=emilio

Comment 22

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1600267: part 17) Call `ComparePoints` instead of `ComparePoints_Deprecated` in `nsFrameSelection`. r=emilio

Depends on D58915

Comment 23

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/655c310bdfe0
https://hg.mozilla.org/mozilla-central/rev/053e37a2547f
https://hg.mozilla.org/mozilla-central/rev/f6d4c4f8fca3
https://hg.mozilla.org/mozilla-central/rev/c1747d1fcad0

Comment 24

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/62e8c57a960a
part 13) Call `ComparePoints` instead of `ComparePoints_Deprecated` in `HTMLEditor`. r=masayuki
https://hg.mozilla.org/integration/autoland/rev/9bae40cbd9f5
part 14) Call `ComparePoints` instead of `ComparePoints_Deprecated` in `WSRunScanner`. r=masayuki

Comment 25

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7dd17065086d
part 15) Call `ComparePoints` instead of `ComparePoints_Deprecated` in `TextServicesDocument`. r=masayuki
https://hg.mozilla.org/integration/autoland/rev/f24ecfbfbc12
part 16) Call `ComparePoints` instead of `ComparePoints_Deprecated` in `AccessibleCaretManager`. r=emilio
https://hg.mozilla.org/integration/autoland/rev/2ab2b8aef97d
part 17) Call `ComparePoints` instead of `ComparePoints_Deprecated` in `nsFrameSelection`. r=emilio

Comment 26

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/62e8c57a960a
https://hg.mozilla.org/mozilla-central/rev/9bae40cbd9f5
https://hg.mozilla.org/mozilla-central/rev/7dd17065086d
https://hg.mozilla.org/mozilla-central/rev/f24ecfbfbc12
https://hg.mozilla.org/mozilla-central/rev/2ab2b8aef97d

Comment 27

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1600267: part 18) Remove remaining `ComparePoints_Deprecated` calls in Selection. r=smaug

Comment 28

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8bbcbc15b9c3
part 18) Remove remaining `ComparePoints_Deprecated` calls in Selection. r=smaug

Comment 29

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/8bbcbc15b9c3

Comment 30

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1600267: part 19) Emit warnings when `Selection` couldn't compare nodes and pretends some order. r=smaug

Comment 31

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e5dfbbf7d29d
part 19) Emit warnings when `Selection` couldn't compare nodes and pretends some order. r=smaug

Comment 32

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/e5dfbbf7d29d

Comment 33

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:mbrodesser, maybe it's time to close this bug?

Comment 34

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

No, this will still be implemented, sometime.

Comment 35

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:mbrodesser, maybe it's time to close this bug?

Comment 36

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

No, this will still be implemented, sometime.

Comment 37

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:mbrodesser, maybe it's time to close this bug?

Comment 38

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

I'll open a new ticket when I finally get to this.