1600279 - Adding gecko profile jobs using "Create Gecko Profile" UI entrypoint on treeherder produces failing jobs without gecko profiles on try (for windows 10 talos o(ther) and g5 jobs)

Status: RESOLVED DUPLICATE of bug 1594330

(Testing :: Talos, defect, P1)

Description

[:Gijs (he/him)]

(This is probably the wrong product/component but I don't know what the right one is, and can't find other bugs about these task definitions.)

I tried to add profiling jobs for g5 and o(ther) talos jobs on https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=278688874&revision=d38fedeef55ae9bfc47d158b8881aa77977c6340 and https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=278688504&revision=661462f1ffe46316f80a62f2343048d6535b8dff and all of them failed.

The tasks ran, but without profiling, and with the following error at the end:

[taskcluster 2019-11-28T23:35:30.084Z] Executing command 1: --geckoProfile
C:\Users\task_1574980246>--geckoProfile
'--geckoProfile' is not recognized as an internal or external command,
operable program or batch file.

It seems the commandline flag isn't passed correctly (maybe just on Windows) ?

The config for the jobs also has:

[task 2019-11-28T23:27:50.275Z] 23:27:50     INFO -  'gecko_profile': False,

which also seems wrong.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Hey rwood, do you know if this bug is in the right place? If not, where's the best place for it?

Comment 2

[Robert Wood [:rwood]]

(In reply to Mike Conley (:mconley) (:⚙️) (Wayyyy behind on needinfos) from comment #1)

Hey rwood, do you know if this bug is in the right place? If not, where's the best place for it?

Hey, moved to Testing => Talos.

:Gijs, please try '--gecko-profile', I believe that is the syntax that can be used with try.

Comment 3

[:Gijs (he/him)]

(In reply to Robert Wood [:rwood] from comment #2)

(In reply to Mike Conley (:mconley) (:⚙️) (Wayyyy behind on needinfos) from comment #1)

Hey rwood, do you know if this bug is in the right place? If not, where's the best place for it?

Hey, moved to Testing => Talos.

:Gijs, please try '--gecko-profile', I believe that is the syntax that can be used with try.

I don't understand. I just press a button on treeherder. I'm not talking about a mach command. This is all happening inside automation.

Comment 4

[Robert Wood [:rwood]]

(In reply to :Gijs (he/him) from comment #3)

(In reply to Robert Wood [:rwood] from comment #2)

(In reply to Mike Conley (:mconley) (:⚙️) (Wayyyy behind on needinfos) from comment #1)

Hey rwood, do you know if this bug is in the right place? If not, where's the best place for it?

Hey, moved to Testing => Talos.

:Gijs, please try '--gecko-profile', I believe that is the syntax that can be used with try.

I don't understand. I just press a button on treeherder. I'm not talking about a mach command. This is all happening inside automation.

Ah, I assumed 'try to add' meant pushing to try, but you're using the UI ok good to know! I'll have a look when I get a chance thanks.

Comment 5

[Ionuț Goldan [:igoldan]]

This should have been fixed by bug 1594330, which landed around Nov 13.

Gijs, I looked over the 2 Try pushes from comment 0. They both seem to be based on a revision from around Nov 12, which doesn't include bug 1594330's fix. Do you have Try pushes based on more recent revision and still experience this problem?

Comment 6

[:Gijs (he/him)]

(In reply to Ionuț Goldan [:igoldan], Performance Sheriff from comment #5)

This should have been fixed by bug 1594330, which landed around Nov 13.

Gijs, I looked over the 2 Try pushes from comment 0. They both seem to be based on a revision from around Nov 12, which doesn't include bug 1594330's fix. Do you have Try pushes based on more recent revision and still experience this problem?

FWIW I submitted trypushes to check this shortly after your question but the talos jobs have just sat there being pending. So I can't say yet. Maybe tomorrow. Keeping ni.

Comment 7

[:Gijs (he/him)]

Hm, talos has been a bit clogged up the past few days, but this does appear to work now. Thanks!

Comment 8

[Mike Conley (:mconley) (:⚙️)]

I'm starting to experience this now on this try push:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=db7bfe0de89e85ef0536227958cdfa3992cd6f64

Try as I might, I'm not able to trigger any profiles here. Any idea what's going on here, igoldan?

Comment 9

[:Gijs (he/him)]

(In reply to Mike Conley (:mconley) (:⚙️) (Wayyyy behind on needinfos) from comment #8)

I'm starting to experience this now on this try push:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=db7bfe0de89e85ef0536227958cdfa3992cd6f64

Try as I might, I'm not able to trigger any profiles here. Any idea what's going on here, igoldan?

It looks like this is based on a revision from November 13, and bug 1594330 landed on November 14 (see comment #5). The task uses code that's in central, so any pushes from older revisions (or release/esr, I expect?) would break like this. I would expect that importing https://hg.mozilla.org/mozilla-central/rev/1936d7a01173 would fix it, if you must get a profile from that specific old revision for a comparison.

Comment 10

[Ionuț Goldan [:igoldan]]

You're experiencing the same issue Gijs had. Just rebase your patch on a mozilla-central revision more recent than Nov 14.

If you require to test your changes on that specific old revision, you could apply this patch, on top of it, so your Try push has working gecko profiles.

Comment 11

[Dave Hunt [:davehunt] [he/him] ⌚BST]

:mconley please reopen this if you're able to reproduce since Nov 14th or after a rebase for patches prior to this date.

Comment 12

[Mike Conley (:mconley) (:⚙️)]

I think I'm okay now, thanks all!