Closed Bug 1600283 Opened 6 months ago Closed 6 months ago

Harmonize pointer usage in IndexedDB code

Categories

(Core :: Storage: IndexedDB, task, P3)

task

Tracking

()

RESOLVED FIXED
mozilla73
Tracking Status
firefox73 --- fixed

People

(Reporter: sg, Assigned: sg)

Details

Attachments

(42 files)

47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review

In particular:

  • use regular move semantics instead of forget/swap/already_AddRefed (in particular in connection with return values)
  • reduce the use of raw pointers as parameters
Attachment #9112928 - Attachment description: Bug 1600283 - Remove uses of already_AddRefed. → Bug 1600283 - Remove uses of already_AddRefed. r=#dom-workers-and-storage
Attachment #9112929 - Attachment description: Bug 1600283 - Remove uses of already_AddRefed. → Bug 1600283 - Remove uses of already_AddRefed. r=#dom-workers-and-storage
Attachment #9112930 - Attachment description: Bug 1600283 - Remove uses of already_AddRefed. → Bug 1600283 - Remove uses of already_AddRefed. r=#dom-workers-and-storage
Attachment #9112931 - Attachment description: Bug 1600283 - Remove uses of plain pointers. → Bug 1600283 - Remove uses of plain pointers. r=#dom-workers-and-storage
Attachment #9112932 - Attachment description: Bug 1600283 - Remove uses of already_AddRefed. → Bug 1600283 - Remove uses of already_AddRefed. r=#dom-workers-and-storage
Attachment #9112933 - Attachment description: Bug 1600283 - Remove uses of already_AddRefed. → Bug 1600283 - Remove uses of already_AddRefed. r=#dom-workers-and-storage
Attachment #9112934 - Attachment description: Bug 1600283 - Remove uses of already_AddRefed. → Bug 1600283 - Remove uses of already_AddRefed. r=#dom-workers-and-storage
Attachment #9112935 - Attachment description: Bug 1600283 - Remove uses of already_AddRefed. → Bug 1600283 - Remove uses of already_AddRefed. r=#dom-workers-and-storage
Attachment #9112936 - Attachment description: Bug 1600283 - Remove uses of already_AddRefed. → Bug 1600283 - Remove uses of already_AddRefed. r=#dom-workers-and-storage
Attachment #9112937 - Attachment description: Bug 1600283 - Remove uses of already_AddRefed. → Bug 1600283 - Remove uses of already_AddRefed. r=#dom-workers-and-storage
Attachment #9112938 - Attachment description: Bug 1600283 - Remove uses of already_AddRefed. → Bug 1600283 - Remove uses of already_AddRefed. r=#dom-workers-and-storage
Attachment #9112940 - Attachment description: Bug 1600283 - Remove uses of already_AddRefed. → Bug 1600283 - Remove uses of already_AddRefed. r=#dom-workers-and-storage
Attachment #9112941 - Attachment description: Bug 1600283 - Remove uses of already_AddRefed. → Bug 1600283 - Remove uses of already_AddRefed. r=#dom-workers-and-storage
Attachment #9112942 - Attachment description: Bug 1600283 - Remove uses of already_AddRefed. → Bug 1600283 - Remove uses of already_AddRefed. r=#dom-workers-and-storage
Attachment #9112943 - Attachment description: Bug 1600283 - Remove uses of already_AddRefed. → Bug 1600283 - Remove uses of already_AddRefed. r=#dom-workers-and-storage
Attachment #9112944 - Attachment description: Bug 1600283 - Remove uses of already_AddRefed. → Bug 1600283 - Remove uses of already_AddRefed. r=#dom-workers-and-storage
Attachment #9112945 - Attachment description: Bug 1600283 - Removed uses of plain pointers. → Bug 1600283 - Removed uses of plain pointers. r=#dom-workers-and-storage
Attachment #9112946 - Attachment description: Bug 1600283 - Remove uses of already_AddRefed. → Bug 1600283 - Remove uses of already_AddRefed. r=#dom-workers-and-storage
Attachment #9112947 - Attachment description: Bug 1600283 - Remove uses of plain pointers and already_AddRefed. → Bug 1600283 - Remove uses of plain pointers and already_AddRefed. r=#dom-workers-and-storage
Attachment #9112948 - Attachment description: Bug 1600283 - Remove uses of already_AddRefed. → Bug 1600283 - Remove uses of already_AddRefed. r=#dom-workers-and-storage
Attachment #9112952 - Attachment description: Bug 1600283 - Remove uses of already_AddRefed. → Bug 1600283 - Remove uses of already_AddRefed. r=#dom-workers-and-storage
Attachment #9112953 - Attachment description: Bug 1600283 - Remove uses of plain pointers. → Bug 1600283 - Remove uses of plain pointers. r=#dom-workers-and-storage
Attachment #9112954 - Attachment description: Bug 1600283 - Remove uses of plain pointers. → Bug 1600283 - Remove uses of plain pointers. r=#dom-workers-and-storage
Attachment #9112955 - Attachment description: Bug 1600283 - Remove uses of plain pointers. → Bug 1600283 - Remove uses of plain pointers. r=#dom-workers-and-storage
Attachment #9112956 - Attachment description: Bug 1600283 - Remove uses of plain pointers. → Bug 1600283 - Remove uses of plain pointers. r=#dom-workers-and-storage
Attachment #9112957 - Attachment description: Bug 1600283 - Remove uses of plain pointers. → Bug 1600283 - Remove uses of plain pointers. r=#dom-workers-and-storage
Attachment #9112958 - Attachment description: Bug 1600283 - Use std::move instead of forget/swap. → Bug 1600283 - Use std::move instead of forget/swap. r=#dom-workers-and-storage
Attachment #9112959 - Attachment description: Bug 1600283 - Remove uses of plain pointers. → Bug 1600283 - Remove uses of plain pointers. r=#dom-workers-and-storage
Attachment #9112961 - Attachment description: Bug 1600283 - Remove uses of plain pointers. → Bug 1600283 - Remove uses of plain pointers. r=#dom-workers-and-storage
Attachment #9112963 - Attachment description: Bug 1600283 - Use std::move instead of forget. → Bug 1600283 - Use std::move instead of forget. r=#dom-workers-and-storage
Attachment #9112964 - Attachment description: Bug 1600283 - Replaced use of nsAutoPtr by UniquePtr. → Bug 1600283 - Replaced use of nsAutoPtr by UniquePtr. r=#dom-workers-and-storage
Attachment #9112965 - Attachment description: Bug 1600283 - Replaced use of nsAutoPtr by UniquePtr. → Bug 1600283 - Replaced use of nsAutoPtr by UniquePtr. r=#dom-workers-and-storage
Attachment #9112966 - Attachment description: Bug 1600283 - Removed unused include directives. → Bug 1600283 - Removed unused include directives. r=#dom-workers-and-storage
Attachment #9112968 - Attachment description: Bug 1600283 - Replaced use of nsAutoPtr by UniquePtr. → Bug 1600283 - Replaced use of nsAutoPtr by UniquePtr. r=#dom-workers-and-storage
Attachment #9112969 - Attachment description: Bug 1600283 - Replaced use of nsAutoPtr by UniquePtr. → Bug 1600283 - Replaced use of nsAutoPtr by UniquePtr. r=#dom-workers-and-storage
Attachment #9112970 - Attachment description: Bug 1600283 - Replaced use of nsAutoPtr by UniquePtr. → Bug 1600283 - Replaced use of nsAutoPtr by UniquePtr. r=#dom-workers-and-storage
Attachment #9112971 - Attachment description: Bug 1600283 - Replaced use of nsAutoPtr by UniquePtr. → Bug 1600283 - Replaced use of nsAutoPtr by UniquePtr. r=#dom-workers-and-storage
Attachment #9112972 - Attachment description: Bug 1600283 - Removed uses of already_AddRefed. → Bug 1600283 - Removed uses of already_AddRefed. r=#dom-workers-and-storage
Pushed by sgiesecke@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/11739efe0b49
Reduce uses of plain pointers. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/3c2e9e525f68
Remove uses of already_AddRefed. r=dom-workers-and-storage-reviewers,janv
Pushed by sgiesecke@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bbf2f47ef9f5
Remove uses of already_AddRefed. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/85af7371d686
Remove uses of already_AddRefed. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/29ab0c6fb048
Remove uses of already_AddRefed. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/56ab1907ac8a
Remove uses of already_AddRefed. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/ade74090bb23
Remove uses of already_AddRefed. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/4fe17aa380dc
Remove uses of plain pointers. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/7691e6abf306
Remove uses of already_AddRefed. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/a8d986fc5678
Remove uses of already_AddRefed. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/e0e2cb6fa2ac
Remove uses of already_AddRefed. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/cb0d23d69fd2
Remove uses of already_AddRefed. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/ea17496f741b
Remove uses of already_AddRefed. r=dom-workers-and-storage-reviewers,janv
Pushed by sgiesecke@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5bcadc4a1fee
Remove uses of already_AddRefed. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/9970b85a4825
Remove uses of already_AddRefed. r=dom-workers-and-storage-reviewers,janv
Pushed by sgiesecke@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1bde7faf5195
Remove uses of already_AddRefed. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/8b8ef40ded7b
Remove uses of already_AddRefed. r=dom-workers-and-storage-reviewers,ytausky
https://hg.mozilla.org/integration/autoland/rev/b5f2b0967971
Remove uses of already_AddRefed. r=dom-workers-and-storage-reviewers,ytausky
https://hg.mozilla.org/integration/autoland/rev/4a71e8538f6d
Remove uses of already_AddRefed. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/a45077e41e99
Remove uses of already_AddRefed. r=dom-workers-and-storage-reviewers,ytausky
https://hg.mozilla.org/integration/autoland/rev/6c149520a4e9
Removed uses of plain pointers. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/663d202ffc51
Remove uses of already_AddRefed. r=dom-workers-and-storage-reviewers,ytausky
https://hg.mozilla.org/integration/autoland/rev/baea03ebf4ff
Remove uses of plain pointers and already_AddRefed. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/bbea72bf31a7
Remove uses of already_AddRefed. r=dom-workers-and-storage-reviewers,ytausky
https://hg.mozilla.org/integration/autoland/rev/8ba5b66792d5
Remove uses of already_AddRefed. r=dom-workers-and-storage-reviewers,ytausky
https://hg.mozilla.org/integration/autoland/rev/b64ca922fa44
Remove uses of plain pointers. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/e506b0fa871f
Remove uses of plain pointers. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/e1c5cc8967f2
Remove uses of plain pointers. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/361482b98e96
Remove uses of plain pointers. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/a9c47bbccf48
Remove uses of plain pointers. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/4c23b2ea6e12
Use std::move instead of forget/swap. r=dom-workers-and-storage-reviewers,ytausky
https://hg.mozilla.org/integration/autoland/rev/deaa7838424d
Remove uses of plain pointers. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/64d5fda1ad24
Remove uses of plain pointers. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/3c23b544f0dc
Use std::move instead of forget. r=dom-workers-and-storage-reviewers,ytausky
https://hg.mozilla.org/integration/autoland/rev/d6a04d7f6b47
Replaced use of nsAutoPtr by UniquePtr. r=dom-workers-and-storage-reviewers,ytausky
https://hg.mozilla.org/integration/autoland/rev/79b95b0f1e3b
Replaced use of nsAutoPtr by UniquePtr. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/4dd1e2510cb1
Removed unused include directives. r=dom-workers-and-storage-reviewers,ytausky
https://hg.mozilla.org/integration/autoland/rev/c55aebcb0f28
Replaced use of nsAutoPtr by UniquePtr. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/dead4740c4c7
Replaced use of nsAutoPtr by UniquePtr. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/27236ee379a4
Replaced use of nsAutoPtr by UniquePtr. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/3d3023354dcf
Replaced use of nsAutoPtr by UniquePtr. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/96b4fd2ee4bc
Removed uses of already_AddRefed. r=dom-workers-and-storage-reviewers,ytausky

https://hg.mozilla.org/mozilla-central/rev/1bde7faf5195
https://hg.mozilla.org/mozilla-central/rev/8b8ef40ded7b
https://hg.mozilla.org/mozilla-central/rev/b5f2b0967971
https://hg.mozilla.org/mozilla-central/rev/4a71e8538f6d
https://hg.mozilla.org/mozilla-central/rev/a45077e41e99
https://hg.mozilla.org/mozilla-central/rev/6c149520a4e9
https://hg.mozilla.org/mozilla-central/rev/663d202ffc51
https://hg.mozilla.org/mozilla-central/rev/baea03ebf4ff
https://hg.mozilla.org/mozilla-central/rev/bbea72bf31a7
https://hg.mozilla.org/mozilla-central/rev/8ba5b66792d5
https://hg.mozilla.org/mozilla-central/rev/b64ca922fa44
https://hg.mozilla.org/mozilla-central/rev/e506b0fa871f
https://hg.mozilla.org/mozilla-central/rev/e1c5cc8967f2
https://hg.mozilla.org/mozilla-central/rev/361482b98e96
https://hg.mozilla.org/mozilla-central/rev/a9c47bbccf48
https://hg.mozilla.org/mozilla-central/rev/4c23b2ea6e12
https://hg.mozilla.org/mozilla-central/rev/deaa7838424d
https://hg.mozilla.org/mozilla-central/rev/64d5fda1ad24
https://hg.mozilla.org/mozilla-central/rev/3c23b544f0dc
https://hg.mozilla.org/mozilla-central/rev/d6a04d7f6b47
https://hg.mozilla.org/mozilla-central/rev/79b95b0f1e3b
https://hg.mozilla.org/mozilla-central/rev/4dd1e2510cb1
https://hg.mozilla.org/mozilla-central/rev/c55aebcb0f28
https://hg.mozilla.org/mozilla-central/rev/dead4740c4c7
https://hg.mozilla.org/mozilla-central/rev/27236ee379a4
https://hg.mozilla.org/mozilla-central/rev/3d3023354dcf
https://hg.mozilla.org/mozilla-central/rev/96b4fd2ee4bc

You need to log in before you can comment on or make changes to this bug.