Harmonize pointer usage in IndexedDB code
Categories
(Core :: Storage: IndexedDB, task, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox73 | --- | fixed |
People
(Reporter: sg, Assigned: sg)
Details
Attachments
(42 files)
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review |
In particular:
- use regular move semantics instead of
forget
/swap
/already_AddRefed
(in particular in connection with return values) - reduce the use of raw pointers as parameters
Assignee | ||
Comment 1•1 year ago
|
||
Depends on D55141
Assignee | ||
Comment 2•1 year ago
|
||
Depends on D55477
Assignee | ||
Comment 3•1 year ago
|
||
Depends on D55478
Assignee | ||
Comment 4•1 year ago
|
||
Depends on D55479
Assignee | ||
Comment 5•1 year ago
|
||
Depends on D55480
Assignee | ||
Comment 6•1 year ago
|
||
Depends on D55482
Assignee | ||
Comment 7•1 year ago
|
||
Depends on D55483
Assignee | ||
Comment 8•1 year ago
|
||
Depends on D55484
Assignee | ||
Comment 9•1 year ago
|
||
Depends on D55485
Assignee | ||
Comment 10•1 year ago
|
||
Depends on D55486
Assignee | ||
Comment 11•1 year ago
|
||
Depends on D55487
Assignee | ||
Comment 12•1 year ago
|
||
Depends on D55488
Assignee | ||
Comment 13•1 year ago
|
||
Depends on D55489
Assignee | ||
Comment 14•1 year ago
|
||
Depends on D55490
Assignee | ||
Comment 15•1 year ago
|
||
Depends on D55491
Assignee | ||
Comment 16•1 year ago
|
||
Depends on D55492
Assignee | ||
Comment 17•1 year ago
|
||
Depends on D55494
Assignee | ||
Comment 18•1 year ago
|
||
Depends on D55495
Assignee | ||
Comment 19•1 year ago
|
||
Depends on D55496
Assignee | ||
Comment 20•1 year ago
|
||
Depends on D55497
Assignee | ||
Comment 21•1 year ago
|
||
Depends on D55498
Assignee | ||
Comment 22•1 year ago
|
||
Depends on D55499
Assignee | ||
Comment 23•1 year ago
|
||
Depends on D55500
Assignee | ||
Comment 24•1 year ago
|
||
Depends on D55501
Assignee | ||
Comment 25•1 year ago
|
||
Depends on D55502
Assignee | ||
Comment 26•1 year ago
|
||
Depends on D55504
Assignee | ||
Comment 27•1 year ago
|
||
Depends on D55505
Assignee | ||
Comment 28•1 year ago
|
||
Depends on D55506
Assignee | ||
Comment 29•1 year ago
|
||
Depends on D55507
Assignee | ||
Comment 30•1 year ago
|
||
Depends on D55508
Assignee | ||
Comment 31•1 year ago
|
||
Depends on D55509
Assignee | ||
Comment 32•1 year ago
|
||
Depends on D55510
Assignee | ||
Comment 33•1 year ago
|
||
Depends on D55511
Assignee | ||
Comment 34•1 year ago
|
||
Depends on D55512
Assignee | ||
Comment 35•1 year ago
|
||
Depends on D55513
Assignee | ||
Comment 36•1 year ago
|
||
Depends on D55514
Assignee | ||
Comment 37•1 year ago
|
||
Depends on D55515
Assignee | ||
Comment 38•1 year ago
|
||
Depends on D55516
Assignee | ||
Comment 39•1 year ago
|
||
Depends on D55517
Assignee | ||
Comment 40•1 year ago
|
||
Depends on D55518
Assignee | ||
Comment 41•1 year ago
|
||
Depends on D55519
Assignee | ||
Comment 42•1 year ago
|
||
Depends on D55520
Updated•1 year ago
|
Updated•1 year ago
|
Updated•1 year ago
|
Updated•1 year ago
|
Updated•1 year ago
|
Updated•1 year ago
|
Updated•1 year ago
|
Updated•1 year ago
|
Updated•1 year ago
|
Updated•1 year ago
|
Updated•1 year ago
|
Updated•1 year ago
|
Updated•1 year ago
|
Updated•1 year ago
|
Updated•1 year ago
|
Updated•1 year ago
|
Updated•1 year ago
|
Updated•1 year ago
|
Updated•1 year ago
|
Updated•1 year ago
|
Updated•1 year ago
|
Updated•1 year ago
|
Updated•1 year ago
|
Updated•1 year ago
|
Updated•1 year ago
|
Updated•1 year ago
|
Updated•1 year ago
|
Updated•1 year ago
|
Updated•1 year ago
|
Updated•1 year ago
|
Updated•1 year ago
|
Updated•1 year ago
|
Updated•1 year ago
|
Updated•1 year ago
|
Updated•1 year ago
|
Updated•1 year ago
|
Updated•1 year ago
|
Updated•1 year ago
|
Comment 43•1 year ago
|
||
Pushed by sgiesecke@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/11739efe0b49 Reduce uses of plain pointers. r=dom-workers-and-storage-reviewers,janv https://hg.mozilla.org/integration/autoland/rev/3c2e9e525f68 Remove uses of already_AddRefed. r=dom-workers-and-storage-reviewers,janv
Comment 44•1 year ago
|
||
Pushed by sgiesecke@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/bbf2f47ef9f5 Remove uses of already_AddRefed. r=dom-workers-and-storage-reviewers,janv https://hg.mozilla.org/integration/autoland/rev/85af7371d686 Remove uses of already_AddRefed. r=dom-workers-and-storage-reviewers,janv https://hg.mozilla.org/integration/autoland/rev/29ab0c6fb048 Remove uses of already_AddRefed. r=dom-workers-and-storage-reviewers,janv https://hg.mozilla.org/integration/autoland/rev/56ab1907ac8a Remove uses of already_AddRefed. r=dom-workers-and-storage-reviewers,janv https://hg.mozilla.org/integration/autoland/rev/ade74090bb23 Remove uses of already_AddRefed. r=dom-workers-and-storage-reviewers,janv https://hg.mozilla.org/integration/autoland/rev/4fe17aa380dc Remove uses of plain pointers. r=dom-workers-and-storage-reviewers,janv https://hg.mozilla.org/integration/autoland/rev/7691e6abf306 Remove uses of already_AddRefed. r=dom-workers-and-storage-reviewers,janv https://hg.mozilla.org/integration/autoland/rev/a8d986fc5678 Remove uses of already_AddRefed. r=dom-workers-and-storage-reviewers,janv https://hg.mozilla.org/integration/autoland/rev/e0e2cb6fa2ac Remove uses of already_AddRefed. r=dom-workers-and-storage-reviewers,janv https://hg.mozilla.org/integration/autoland/rev/cb0d23d69fd2 Remove uses of already_AddRefed. r=dom-workers-and-storage-reviewers,janv https://hg.mozilla.org/integration/autoland/rev/ea17496f741b Remove uses of already_AddRefed. r=dom-workers-and-storage-reviewers,janv
Comment 45•1 year ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/11739efe0b49
https://hg.mozilla.org/mozilla-central/rev/3c2e9e525f68
https://hg.mozilla.org/mozilla-central/rev/bbf2f47ef9f5
https://hg.mozilla.org/mozilla-central/rev/85af7371d686
https://hg.mozilla.org/mozilla-central/rev/29ab0c6fb048
https://hg.mozilla.org/mozilla-central/rev/56ab1907ac8a
https://hg.mozilla.org/mozilla-central/rev/ade74090bb23
https://hg.mozilla.org/mozilla-central/rev/4fe17aa380dc
https://hg.mozilla.org/mozilla-central/rev/7691e6abf306
https://hg.mozilla.org/mozilla-central/rev/a8d986fc5678
https://hg.mozilla.org/mozilla-central/rev/e0e2cb6fa2ac
https://hg.mozilla.org/mozilla-central/rev/cb0d23d69fd2
https://hg.mozilla.org/mozilla-central/rev/ea17496f741b
Comment 46•1 year ago
|
||
Pushed by sgiesecke@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5bcadc4a1fee Remove uses of already_AddRefed. r=dom-workers-and-storage-reviewers,janv https://hg.mozilla.org/integration/autoland/rev/9970b85a4825 Remove uses of already_AddRefed. r=dom-workers-and-storage-reviewers,janv
Comment 47•1 year ago
|
||
bugherder |
Comment 48•1 year ago
|
||
Pushed by sgiesecke@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1bde7faf5195 Remove uses of already_AddRefed. r=dom-workers-and-storage-reviewers,janv https://hg.mozilla.org/integration/autoland/rev/8b8ef40ded7b Remove uses of already_AddRefed. r=dom-workers-and-storage-reviewers,ytausky https://hg.mozilla.org/integration/autoland/rev/b5f2b0967971 Remove uses of already_AddRefed. r=dom-workers-and-storage-reviewers,ytausky https://hg.mozilla.org/integration/autoland/rev/4a71e8538f6d Remove uses of already_AddRefed. r=dom-workers-and-storage-reviewers,janv https://hg.mozilla.org/integration/autoland/rev/a45077e41e99 Remove uses of already_AddRefed. r=dom-workers-and-storage-reviewers,ytausky https://hg.mozilla.org/integration/autoland/rev/6c149520a4e9 Removed uses of plain pointers. r=dom-workers-and-storage-reviewers,janv https://hg.mozilla.org/integration/autoland/rev/663d202ffc51 Remove uses of already_AddRefed. r=dom-workers-and-storage-reviewers,ytausky https://hg.mozilla.org/integration/autoland/rev/baea03ebf4ff Remove uses of plain pointers and already_AddRefed. r=dom-workers-and-storage-reviewers,janv https://hg.mozilla.org/integration/autoland/rev/bbea72bf31a7 Remove uses of already_AddRefed. r=dom-workers-and-storage-reviewers,ytausky https://hg.mozilla.org/integration/autoland/rev/8ba5b66792d5 Remove uses of already_AddRefed. r=dom-workers-and-storage-reviewers,ytausky https://hg.mozilla.org/integration/autoland/rev/b64ca922fa44 Remove uses of plain pointers. r=dom-workers-and-storage-reviewers,janv https://hg.mozilla.org/integration/autoland/rev/e506b0fa871f Remove uses of plain pointers. r=dom-workers-and-storage-reviewers,janv https://hg.mozilla.org/integration/autoland/rev/e1c5cc8967f2 Remove uses of plain pointers. r=dom-workers-and-storage-reviewers,janv https://hg.mozilla.org/integration/autoland/rev/361482b98e96 Remove uses of plain pointers. r=dom-workers-and-storage-reviewers,janv https://hg.mozilla.org/integration/autoland/rev/a9c47bbccf48 Remove uses of plain pointers. r=dom-workers-and-storage-reviewers,ttung https://hg.mozilla.org/integration/autoland/rev/4c23b2ea6e12 Use std::move instead of forget/swap. r=dom-workers-and-storage-reviewers,ytausky https://hg.mozilla.org/integration/autoland/rev/deaa7838424d Remove uses of plain pointers. r=dom-workers-and-storage-reviewers,ttung https://hg.mozilla.org/integration/autoland/rev/64d5fda1ad24 Remove uses of plain pointers. r=dom-workers-and-storage-reviewers,ttung https://hg.mozilla.org/integration/autoland/rev/3c23b544f0dc Use std::move instead of forget. r=dom-workers-and-storage-reviewers,ytausky https://hg.mozilla.org/integration/autoland/rev/d6a04d7f6b47 Replaced use of nsAutoPtr by UniquePtr. r=dom-workers-and-storage-reviewers,ytausky https://hg.mozilla.org/integration/autoland/rev/79b95b0f1e3b Replaced use of nsAutoPtr by UniquePtr. r=dom-workers-and-storage-reviewers,janv https://hg.mozilla.org/integration/autoland/rev/4dd1e2510cb1 Removed unused include directives. r=dom-workers-and-storage-reviewers,ytausky https://hg.mozilla.org/integration/autoland/rev/c55aebcb0f28 Replaced use of nsAutoPtr by UniquePtr. r=dom-workers-and-storage-reviewers,janv https://hg.mozilla.org/integration/autoland/rev/dead4740c4c7 Replaced use of nsAutoPtr by UniquePtr. r=dom-workers-and-storage-reviewers,janv https://hg.mozilla.org/integration/autoland/rev/27236ee379a4 Replaced use of nsAutoPtr by UniquePtr. r=dom-workers-and-storage-reviewers,janv https://hg.mozilla.org/integration/autoland/rev/3d3023354dcf Replaced use of nsAutoPtr by UniquePtr. r=dom-workers-and-storage-reviewers,janv https://hg.mozilla.org/integration/autoland/rev/96b4fd2ee4bc Removed uses of already_AddRefed. r=dom-workers-and-storage-reviewers,ytausky
Comment 49•1 year ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/1bde7faf5195
https://hg.mozilla.org/mozilla-central/rev/8b8ef40ded7b
https://hg.mozilla.org/mozilla-central/rev/b5f2b0967971
https://hg.mozilla.org/mozilla-central/rev/4a71e8538f6d
https://hg.mozilla.org/mozilla-central/rev/a45077e41e99
https://hg.mozilla.org/mozilla-central/rev/6c149520a4e9
https://hg.mozilla.org/mozilla-central/rev/663d202ffc51
https://hg.mozilla.org/mozilla-central/rev/baea03ebf4ff
https://hg.mozilla.org/mozilla-central/rev/bbea72bf31a7
https://hg.mozilla.org/mozilla-central/rev/8ba5b66792d5
https://hg.mozilla.org/mozilla-central/rev/b64ca922fa44
https://hg.mozilla.org/mozilla-central/rev/e506b0fa871f
https://hg.mozilla.org/mozilla-central/rev/e1c5cc8967f2
https://hg.mozilla.org/mozilla-central/rev/361482b98e96
https://hg.mozilla.org/mozilla-central/rev/a9c47bbccf48
https://hg.mozilla.org/mozilla-central/rev/4c23b2ea6e12
https://hg.mozilla.org/mozilla-central/rev/deaa7838424d
https://hg.mozilla.org/mozilla-central/rev/64d5fda1ad24
https://hg.mozilla.org/mozilla-central/rev/3c23b544f0dc
https://hg.mozilla.org/mozilla-central/rev/d6a04d7f6b47
https://hg.mozilla.org/mozilla-central/rev/79b95b0f1e3b
https://hg.mozilla.org/mozilla-central/rev/4dd1e2510cb1
https://hg.mozilla.org/mozilla-central/rev/c55aebcb0f28
https://hg.mozilla.org/mozilla-central/rev/dead4740c4c7
https://hg.mozilla.org/mozilla-central/rev/27236ee379a4
https://hg.mozilla.org/mozilla-central/rev/3d3023354dcf
https://hg.mozilla.org/mozilla-central/rev/96b4fd2ee4bc
Description
•