1600283 - Harmonize pointer usage in IndexedDB code

Status: RESOLVED FIXED

(Core :: Storage: IndexedDB, task, P3)

Description

[Simon Giesecke [:sg] [he/him]]

In particular:

• use regular move semantics instead of forget/swap/already_AddRefed (in particular in connection with return values)
• reduce the use of raw pointers as parameters

Comment 1

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1600283 - Reduce uses of plain pointers. r=#dom-workers-and-storage

Depends on D55141

Comment 2

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1600283 - Remove uses of already_AddRefed. r=#dom-workers-and-storage

Depends on D55477

Comment 3

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1600283 - Remove uses of already_AddRefed. r=#dom-workers-and-storage

Depends on D55478

Comment 4

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1600283 - Remove uses of already_AddRefed. r=#dom-workers-and-storage

Depends on D55479

Comment 5

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1600283 - Remove uses of already_AddRefed. r=#dom-workers-and-storage

Depends on D55480

Comment 6

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1600283 - Remove uses of already_AddRefed. r=#dom-workers-and-storage

Depends on D55482

Comment 7

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1600283 - Remove uses of already_AddRefed. r=#dom-workers-and-storage

Depends on D55483

Comment 8

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1600283 - Remove uses of plain pointers. r=#dom-workers-and-storage

Depends on D55484

Comment 9

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1600283 - Remove uses of already_AddRefed. r=#dom-workers-and-storage

Depends on D55485

Comment 10

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1600283 - Remove uses of already_AddRefed. r=#dom-workers-and-storage

Depends on D55486

Comment 11

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1600283 - Remove uses of already_AddRefed. r=#dom-workers-and-storage

Depends on D55487

Comment 12

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1600283 - Remove uses of already_AddRefed. r=#dom-workers-and-storage

Depends on D55488

Comment 13

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1600283 - Remove uses of already_AddRefed. r=#dom-workers-and-storage

Depends on D55489

Comment 14

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1600283 - Remove uses of already_AddRefed. r=#dom-workers-and-storage

Depends on D55490

Comment 15

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1600283 - Remove uses of already_AddRefed. r=#dom-workers-and-storage

Depends on D55491

Comment 16

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1600283 - Remove uses of already_AddRefed. r=#dom-workers-and-storage

Depends on D55492

Comment 17

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1600283 - Remove uses of already_AddRefed. r=#dom-workers-and-storage

Depends on D55494

Comment 18

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1600283 - Remove uses of already_AddRefed. r=#dom-workers-and-storage

Depends on D55495

Comment 19

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1600283 - Remove uses of already_AddRefed. r=#dom-workers-and-storage

Depends on D55496

Comment 20

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1600283 - Remove uses of already_AddRefed. r=#dom-workers-and-storage

Depends on D55497

Comment 21

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1600283 - Removed uses of plain pointers. r=#dom-workers-and-storage

Depends on D55498

Comment 22

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1600283 - Remove uses of already_AddRefed. r=#dom-workers-and-storage

Depends on D55499

Comment 23

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1600283 - Remove uses of plain pointers and already_AddRefed. r=#dom-workers-and-storage

Depends on D55500

Comment 24

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1600283 - Remove uses of already_AddRefed. r=#dom-workers-and-storage

Depends on D55501

Comment 25

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1600283 - Remove uses of already_AddRefed. r=#dom-workers-and-storage

Depends on D55502

Comment 26

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1600283 - Remove uses of plain pointers. r=#dom-workers-and-storage

Depends on D55504

Comment 27

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1600283 - Remove uses of plain pointers. r=#dom-workers-and-storage

Depends on D55505

Comment 28

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1600283 - Remove uses of plain pointers. r=#dom-workers-and-storage

Depends on D55506

Comment 29

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1600283 - Remove uses of plain pointers. r=#dom-workers-and-storage

Depends on D55507

Comment 30

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1600283 - Remove uses of plain pointers. r=#dom-workers-and-storage

Depends on D55508

Comment 31

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1600283 - Use std::move instead of forget/swap. r=#dom-workers-and-storage

Depends on D55509

Comment 32

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1600283 - Remove uses of plain pointers. r=#dom-workers-and-storage

Depends on D55510

Comment 33

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1600283 - Remove uses of plain pointers. r=#dom-workers-and-storage

Depends on D55511

Comment 34

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1600283 - Use std::move instead of forget. r=#dom-workers-and-storage

Depends on D55512

Comment 35

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1600283 - Replaced use of nsAutoPtr by UniquePtr. r=#dom-workers-and-storage

Depends on D55513

Comment 36

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1600283 - Replaced use of nsAutoPtr by UniquePtr. r=#dom-workers-and-storage

Depends on D55514

Comment 37

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1600283 - Removed unused include directives. r=#dom-workers-and-storage

Depends on D55515

Comment 38

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1600283 - Replaced use of nsAutoPtr by UniquePtr. r=#dom-workers-and-storage

Depends on D55516

Comment 39

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1600283 - Replaced use of nsAutoPtr by UniquePtr. r=#dom-workers-and-storage

Depends on D55517

Comment 40

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1600283 - Replaced use of nsAutoPtr by UniquePtr. r=#dom-workers-and-storage

Depends on D55518

Comment 41

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1600283 - Replaced use of nsAutoPtr by UniquePtr. r=#dom-workers-and-storage

Depends on D55519

Comment 42

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1600283 - Removed uses of already_AddRefed. r=#dom-workers-and-storage

Depends on D55520

Comment 43

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/11739efe0b49
Reduce uses of plain pointers. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/3c2e9e525f68
Remove uses of already_AddRefed. r=dom-workers-and-storage-reviewers,janv

Comment 44

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bbf2f47ef9f5
Remove uses of already_AddRefed. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/85af7371d686
Remove uses of already_AddRefed. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/29ab0c6fb048
Remove uses of already_AddRefed. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/56ab1907ac8a
Remove uses of already_AddRefed. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/ade74090bb23
Remove uses of already_AddRefed. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/4fe17aa380dc
Remove uses of plain pointers. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/7691e6abf306
Remove uses of already_AddRefed. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/a8d986fc5678
Remove uses of already_AddRefed. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/e0e2cb6fa2ac
Remove uses of already_AddRefed. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/cb0d23d69fd2
Remove uses of already_AddRefed. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/ea17496f741b
Remove uses of already_AddRefed. r=dom-workers-and-storage-reviewers,janv

Comment 45

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/11739efe0b49
https://hg.mozilla.org/mozilla-central/rev/3c2e9e525f68
https://hg.mozilla.org/mozilla-central/rev/bbf2f47ef9f5
https://hg.mozilla.org/mozilla-central/rev/85af7371d686
https://hg.mozilla.org/mozilla-central/rev/29ab0c6fb048
https://hg.mozilla.org/mozilla-central/rev/56ab1907ac8a
https://hg.mozilla.org/mozilla-central/rev/ade74090bb23
https://hg.mozilla.org/mozilla-central/rev/4fe17aa380dc
https://hg.mozilla.org/mozilla-central/rev/7691e6abf306
https://hg.mozilla.org/mozilla-central/rev/a8d986fc5678
https://hg.mozilla.org/mozilla-central/rev/e0e2cb6fa2ac
https://hg.mozilla.org/mozilla-central/rev/cb0d23d69fd2
https://hg.mozilla.org/mozilla-central/rev/ea17496f741b

Comment 46

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5bcadc4a1fee
Remove uses of already_AddRefed. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/9970b85a4825
Remove uses of already_AddRefed. r=dom-workers-and-storage-reviewers,janv

Comment 47

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/5bcadc4a1fee
https://hg.mozilla.org/mozilla-central/rev/9970b85a4825

Comment 48

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1bde7faf5195
Remove uses of already_AddRefed. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/8b8ef40ded7b
Remove uses of already_AddRefed. r=dom-workers-and-storage-reviewers,ytausky
https://hg.mozilla.org/integration/autoland/rev/b5f2b0967971
Remove uses of already_AddRefed. r=dom-workers-and-storage-reviewers,ytausky
https://hg.mozilla.org/integration/autoland/rev/4a71e8538f6d
Remove uses of already_AddRefed. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/a45077e41e99
Remove uses of already_AddRefed. r=dom-workers-and-storage-reviewers,ytausky
https://hg.mozilla.org/integration/autoland/rev/6c149520a4e9
Removed uses of plain pointers. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/663d202ffc51
Remove uses of already_AddRefed. r=dom-workers-and-storage-reviewers,ytausky
https://hg.mozilla.org/integration/autoland/rev/baea03ebf4ff
Remove uses of plain pointers and already_AddRefed. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/bbea72bf31a7
Remove uses of already_AddRefed. r=dom-workers-and-storage-reviewers,ytausky
https://hg.mozilla.org/integration/autoland/rev/8ba5b66792d5
Remove uses of already_AddRefed. r=dom-workers-and-storage-reviewers,ytausky
https://hg.mozilla.org/integration/autoland/rev/b64ca922fa44
Remove uses of plain pointers. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/e506b0fa871f
Remove uses of plain pointers. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/e1c5cc8967f2
Remove uses of plain pointers. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/361482b98e96
Remove uses of plain pointers. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/a9c47bbccf48
Remove uses of plain pointers. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/4c23b2ea6e12
Use std::move instead of forget/swap. r=dom-workers-and-storage-reviewers,ytausky
https://hg.mozilla.org/integration/autoland/rev/deaa7838424d
Remove uses of plain pointers. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/64d5fda1ad24
Remove uses of plain pointers. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/3c23b544f0dc
Use std::move instead of forget. r=dom-workers-and-storage-reviewers,ytausky
https://hg.mozilla.org/integration/autoland/rev/d6a04d7f6b47
Replaced use of nsAutoPtr by UniquePtr. r=dom-workers-and-storage-reviewers,ytausky
https://hg.mozilla.org/integration/autoland/rev/79b95b0f1e3b
Replaced use of nsAutoPtr by UniquePtr. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/4dd1e2510cb1
Removed unused include directives. r=dom-workers-and-storage-reviewers,ytausky
https://hg.mozilla.org/integration/autoland/rev/c55aebcb0f28
Replaced use of nsAutoPtr by UniquePtr. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/dead4740c4c7
Replaced use of nsAutoPtr by UniquePtr. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/27236ee379a4
Replaced use of nsAutoPtr by UniquePtr. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/3d3023354dcf
Replaced use of nsAutoPtr by UniquePtr. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/96b4fd2ee4bc
Removed uses of already_AddRefed. r=dom-workers-and-storage-reviewers,ytausky

Comment 49

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/1bde7faf5195
https://hg.mozilla.org/mozilla-central/rev/8b8ef40ded7b
https://hg.mozilla.org/mozilla-central/rev/b5f2b0967971
https://hg.mozilla.org/mozilla-central/rev/4a71e8538f6d
https://hg.mozilla.org/mozilla-central/rev/a45077e41e99
https://hg.mozilla.org/mozilla-central/rev/6c149520a4e9
https://hg.mozilla.org/mozilla-central/rev/663d202ffc51
https://hg.mozilla.org/mozilla-central/rev/baea03ebf4ff
https://hg.mozilla.org/mozilla-central/rev/bbea72bf31a7
https://hg.mozilla.org/mozilla-central/rev/8ba5b66792d5
https://hg.mozilla.org/mozilla-central/rev/b64ca922fa44
https://hg.mozilla.org/mozilla-central/rev/e506b0fa871f
https://hg.mozilla.org/mozilla-central/rev/e1c5cc8967f2
https://hg.mozilla.org/mozilla-central/rev/361482b98e96
https://hg.mozilla.org/mozilla-central/rev/a9c47bbccf48
https://hg.mozilla.org/mozilla-central/rev/4c23b2ea6e12
https://hg.mozilla.org/mozilla-central/rev/deaa7838424d
https://hg.mozilla.org/mozilla-central/rev/64d5fda1ad24
https://hg.mozilla.org/mozilla-central/rev/3c23b544f0dc
https://hg.mozilla.org/mozilla-central/rev/d6a04d7f6b47
https://hg.mozilla.org/mozilla-central/rev/79b95b0f1e3b
https://hg.mozilla.org/mozilla-central/rev/4dd1e2510cb1
https://hg.mozilla.org/mozilla-central/rev/c55aebcb0f28
https://hg.mozilla.org/mozilla-central/rev/dead4740c4c7
https://hg.mozilla.org/mozilla-central/rev/27236ee379a4
https://hg.mozilla.org/mozilla-central/rev/3d3023354dcf
https://hg.mozilla.org/mozilla-central/rev/96b4fd2ee4bc