Closed Bug 1600324 Opened 5 years ago Closed 4 years ago

The UI of the "Onboarding" and "Redirect" tips doesn't correspond with the specifications

Categories

(Firefox :: Address Bar, defect)

72 Branch
Desktop
All
defect
Not set
normal

Tracking

()

RESOLVED WONTFIX
Tracking Status
firefox72 --- affected

People

(Reporter: srosu, Unassigned)

References

Details

Attachments

(1 file)

Attached image UI tip.jpg

[Affected versions]:

  • Latest Firefox Nightly 72.0a1 (Build ID: 20191128214853)

[Affected Platforms]:

  • Mac 10.14
  • Windows 10 x64
  • Ubuntu 16.04 x64

[Prerequisites]:

  • Have the latest Nightly installed.
  • Have the “devtools.chrome.enabled” pref set to “true”.
  • Run the “(async function() { let { ProfileAge } = ChromeUtils.import("resource://gre/modules/ProfileAge.jsm"); let age = await ProfileAge(); age._times = { firstUse: 1368255600000, created: 1368255600000 }; await age.writeTimes(); })();” code on the Browser Console.
  • Have access to the stage delivery console.
  • Have an active branched add-on recipe.
  • Have the “security.content.signature.root_hash” pref set to "DB:74:CE:58:E4:F9:D0:9E:E0:42:36:BE:6C:C5:C4:F6:6A:E7:74:7D:C0:21:42:7A:03:BC:2F:57:0C:8B:9B:90".
  • Have the "app.normandy.api_url" pref set to "https://stage.normandy.nonprod.cloudops.mozgcp.net/api/v1".
  • Have the "app.normandy.dev_mode" pref set to “true”.
  • Have the "app.normandy.logging.level" pref set to “0”.
  • Have the "services.settings.server" pref set to "https://settings.stage.mozaws.net/v1".
  • Have the "xpinstall.signatures.dev-root" pref set to “true”.
  • Create a new pref named “carmentips” and set it to “true”.

[Steps to reproduce]:

  1. Open the Firefox browser with the profile from prerequisites.
  2. Navigate to the “about:home” page.
  3. Observe the “Onboarding” tip.

[Expected result]:

  • The tip is displayed on the Address Bar dropdown.

[Actual result]:

  • The “Onboarding” tip overlaps the entire width of the page.

[Notes]:

  • Please see the UI specifications on this Invision document.
  • This issue is also reproducible for the “Redirect” tip.
  • Attached a screenshot with the issue.

The mock-ups have been done with the "megabar" design enabled, but the experiments will run without it. With the old design the urlbar panel takes full window width, while with the new design it is as large as the input field

Thanks for filing this, I should have mentioned it earlier. This is expected on 72 because the megabar is not enabled, as Marco said. The important thing is that the tip appears in the urlbar view with an icon, text, and button, as it does in your screenshot. (If you set the browser.urlbar.megabar pref to true, restart the browser, and then try again, you should see something much closer to the spec.)

I'll close this -- could be wontfix, invalid, or worksforme. It's not really important which.

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: