Closed Bug 1600372 Opened 5 years ago Closed 4 years ago

nsIDOMWindowUtils.nodesFromRect with aOnlyVisible sometimes includes non-visible items

Categories

(Core :: Layout, defect, P3)

Product:
Core
Component:
Layout
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla73
Tracking Flags:
Tracking Status
firefox73 --- fixed

People

(Reporter: mconley, Assigned: emilio)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1600372 - When hit-testing for visibility, do not return nodes in opacity: 0 subtrees. r=mattwoodrow!,mconley!
47 bytes, text/x-phabricator-request
Details | Review

This was first noticed in bug 1600302.

We use nodesFromRect here: https://searchfox.org/mozilla-central/rev/d69bff9bdb2dcf1788eec6232b21eb3eec342799/toolkit/actors/PictureInPictureChild.jsm#477-487

and we pass in true for aOnlyVisible, however, videos with opacity: 0 will still get returned. Seems broken.

emilio said he had a fix for this.

Flags: needinfo?(emilio)

But note that this is a bit arbitrary, maybe we should just make it a threshold
and the PiP stuff could pass 0.5 or something.

Assignee: nobody → emilio

(But note the commit message)

Flags: needinfo?(emilio)
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/72273ff23e61
When hit-testing for visibility, do not return nodes in opacity: 0 subtrees. r=mattwoodrow,mconley
Priority: -- → P3

https://hg.mozilla.org/mozilla-central/rev/72273ff23e61

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox73: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: