Closed Bug 1600383 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 20542 - Don't set taskcluster variables when we don't want to run the task

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox73 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla73
Tracking Flags:
Tracking Status
firefox73 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 20542 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/20542
Details from upstream follow.

James Graham <james@hoppipolla.co.uk> wrote:

Don't set taskcluster variables when we don't want to run the task

Previously we had a single let block setting all the variables for the
.taskcluster.yml file. But this was evaluated even on events for which
we don't run tasks. That caused bogus failures because the logic
didn't account for all the possible event types.

Instead only evaluate the variables used in the task definition in
a block guarded by "if run_task".

Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Test result changes from PR not available.
Test result changes from PR not available.
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8c41b12db448 [wpt PR 20542] - Don't set taskcluster variables when we don't want to run the task, a=testonly

https://hg.mozilla.org/mozilla-central/rev/8c41b12db448

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox73: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
You need to log in before you can comment on or make changes to this bug.