Closed
Bug 1600421
Opened 6 years ago
Closed 6 years ago
Bookmark Panel: Style attribute should be a CSS rule, not just a value
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 72
| Tracking | Status | |
|---|---|---|
| firefox72 | --- | fixed |
People
(Reporter: flod, Assigned: flod)
References
Details
Attachments
(1 file)
Bug 1599303 landed with
https://hg.mozilla.org/mozilla-central/rev/2b5cee228fca
bookmark-panel =
.style = 23em
Which results in compare-locales complaining, ERROR: reference is a CSS spec at line 152, column 1 for bookmark-panel.
More important, I think this is broken, because we moved from style="min-width: &editBookmark.panel.width;;"> to just have 23em as value of that attribute.
I'm going to flag several people for review, because we either fix this (and it's blocking me from pushing new strings), or I ask sheriffs to back out from mozilla-central directly before it moves to Beta.
|
Assignee | |
Comment 1•6 years ago
|
||
|
||
Updated•6 years ago
|
Assignee: nobody → francesco.lodolo
|
|
Assignee | |
Updated•6 years ago
|
Summary: Style attribute should be a CSS rule, not just a value → Bookmark Panel: Style attribute should be a CSS rule, not just a value
Pushed by axel@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4f0d850f94f1
Style attribute for bookmark-panel should include min-width r=Pike,fluent-reviewers
|
||
Comment 3•6 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox72:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 72
You need to log in
before you can comment on or make changes to this bug.
Description
•