Closed Bug 1600435 Opened 4 months ago Closed 4 months ago

Calendar "edit" icon looks inconsistent with the rest of Thunderbird

Categories

(Calendar :: General, defect)

Product:
Calendar
Component:
General
Type:
defect
Priority:
Not set

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
68.3.1

People

(Reporter: ntim, Assigned: Paenglab)

Details

Attachments

(4 files)

Calendar screenshot
23.43 KB, image/png
Details
Compose icon screenshot
16.99 KB, image/png
Details
1600435-calendar-edit-icon.patch
5.16 KB, patch
pmorris
: review+
pmorris
: approval-calendar-beta+
Details | Diff | Splinter Review
1600435-calendar-edit-icon-ESR.patch
5.71 KB, patch
pmorris
: approval-calendar-esr+
Details | Diff | Splinter Review
Attached image Calendar screenshot —

It should be using the same icon as the compose icon.

Attached image Compose icon screenshot —

The same icon as the TB newmsg icon. Only a bit optimised through SVGOMG to not be a duplicate.

Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9112742 - Flags: review?(paul)
Component: Theme → General
Product: Thunderbird → Calendar

Patch for ESR.

Attachment #9112743 - Flags: approval-calendar-esr?(paul)
Attachment #9112742 - Flags: approval-calendar-beta?(paul)
Comment on attachment 9112742 [details] [diff] [review]
1600435-calendar-edit-icon.patch

Review of attachment 9112742 [details] [diff] [review]:
-----------------------------------------------------------------

Changes look fine, and the new icon looks great when I checked it.
Attachment #9112742 - Flags: review?(paul)
Attachment #9112742 - Flags: review+
Attachment #9112742 - Flags: approval-calendar-beta?(paul)
Attachment #9112742 - Flags: approval-calendar-beta+
Attachment #9112743 - Flags: approval-calendar-esr?(paul) → approval-calendar-esr+
Keywords: checkin-needed-tb

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/9bb60ca53c7b
Use the newmsg icon as the edit icon in calendar. r=pmorris

Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Keywords: checkin-needed-tb
Resolution: --- → FIXED

73

Flags: needinfo?(philipp)
Target Milestone: --- → 72
Flags: needinfo?(philipp)
Target Milestone: 72 → 73
Target Milestone: 72 → 68.3.1
You need to log in before you can comment on or make changes to this bug.