1600448 - Clean up SeaMonkey module import and loading

Status: RESOLVED FIXED

(SeaMonkey :: General, enhancement)

Description

[Frank-Rainer Grahl (:frg)]

Bug 1434737 switched the imports to ChromeUtils.import or XPCOMUtils.defineLazyModuleGetters. Since then some inconstencies crept in. 2.53.1 also has not yet switched to XPCOMUtils.defineLazyModuleGetters making backports harder.
Lets clean up here and align 2.53 and up.

Comment 1

[Frank-Rainer Grahl (:frg)]

Attachment: 1600448-257.patch

Minor cleanups and alignments with 2.53.

Comment 2

[Frank-Rainer Grahl (:frg)]

Attachment: 1600448-253.patch

[Approval Request Comment]
Regression caused by (bug #): --
User impact if declined: SeaMonkey is 0.01% slower
Testing completed (on m-c, etc.): 2.53.1
Risk to taking this patch (and alternatives if risky): moderate. The XPCOMUtils removal might trigger errors in rare cases when modules are loaded via overlays. So far none found.
String changes made by this patch: --

PlacesUtils.jsm can always be loaded with ChromeUtils.import in 2.57 but not in 2.53 so there is some difference left in places code between the two releases. Will go away if/when we backport.
Incorporates the XPCOMUtils.defineLazyModuleGetters changes from various patches. Would have been too time consuming to untangle this.

Comment 3

[Ian Neal]

Comment on attachment 9112689 [details] [diff] [review]
1600448-257.patch

LGTM r/a=me

Comment 4

[Ian Neal]

Comment on attachment 9112690 [details] [diff] [review]
1600448-253.patch

[Triage Comment]
LGTM a=me

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/8ef25eb8c092
Follow-up for Bug 1434737. Replace ChromeUtils.import() part 2 in suite. r=IanN

Comment 6

[Frank-Rainer Grahl (:frg)]

Patches for c-c and esr60 got some rebasing for check-in. Discussed via irc.
https://hg.mozilla.org/releases/comm-esr60/rev/f103e65e5a6e2a02fe1b8b1f3bd9df9d025e6ef8