1600451 - Port bug 1600362 - add namespace to Element class

Status: RESOLVED FIXED

(MailNews Core :: General, defect)

Description

[:aceman]

On trunk we get compile errors like mailnews/base/src/nsMsgContentPolicy.cpp:715:16: error: unknown type name 'Element' .
It seems after m-c bug 1600362 Element class is now namespaced in mozilla::dom. I'll add that.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

It was namespaced before, fwiw, but there was some using directive in the top level which effectively wallpapered those errors. But yeah, adding the namespace is the right thing to do.

Comment 2

[:aceman]

Attachment: 1600451.patch

Yes, we only have a few occurrences of Element and some files use using namespace mozilla::dom. Some don't so I add the explicit namespace there as other classes already use.

Try run: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=8f36966d8f4093abaea57c749427979dbe931929

Comment 3

[Jorg K (CEST = GMT+2)]

Can you turn the second dash in the commit message into a colon.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/5f1b51ad26ef
Port bug 1600362: add namespace to Element class. r=KaiE

Comment 5

[:aceman]

(In reply to Jorg K (GMT+1) (PTO to 15th Dec 2019, sporadically reading bugmail) from comment #3)

Can you turn the second dash in the commit message into a colon.

Thanks, done.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/fe7a42d2ace3
Follow-up: Reformat. rs=reformat