1600554 - Remove a nested redundant #if

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, task, P3)

Description

[Sylvestre Ledru [:Sylvestre]]

Filling as a good first bug to learn workflows.

MOZ_WIDGET_GTK is checked twice and we are in the same block
https://searchfox.org/mozilla-central/source/toolkit/xre/nsAppRunner.cpp#2702

As the change is trivial, it is just to learn how to contribute to Firefox.

Found by http://clang.llvm.org/extra/clang-tidy/checks/readability-redundant-preprocessor.html

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/tools/docs/contribute/how_to_contribute_firefox.html

Comment 1

[crasmarurobert]

Hi, I would like to assign to this bug.

Comment 2

[Sylvestre Ledru [:Sylvestre]]

Please submit a patch, i will assign once you have done it

Comment 3

[man.god96]

Attachment: Bug 1600554 - Remove a nested redundant if.cpp

This is a patch for https://searchfox.org/mozilla-central/source/toolkit/xre/nsAppRunner.cpp .

The check for "if defined(MOZ_WIDGET_GTK)" at line 3744 is redundant because that is checked at line 3729 also which is the parent "if".

Differences:
(Old) Line 3744: # if defined(MOZ_WIDGET_GTK) && defined(MOZ_X11)
(New) Line 3744: # if defined(MOZ_X11)

Comment 4

[Sylvestre Ledru [:Sylvestre]]

man.god96, please follow the documentation mentioned in comment #0
We don't use bugzilla for development

Comment 5

[dawiha79]

Attachment: Bug 1600554 Removed nested redundant #if r?froydnj

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/39b62e08daa0
Removed nested redundant #if r=froydnj

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/39b62e08daa0