Closed Bug 1600555 Opened 4 months ago Closed 4 months ago

Remove a nested redundant #if

Categories

(Firefox Build System :: Lint and Formatting, task, P3, minor)

task

Tracking

(firefox73 fixed)

RESOLVED FIXED
mozilla73
Tracking Status
firefox73 --- fixed

People

(Reporter: Sylvestre, Assigned: nooffence7100, Mentored)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug, Whiteboard: [lang=C++])

Attachments

(1 file, 1 obsolete file)

Filling as a good first bug to learn workflows.

XP_UNIX is checked twice and we are in the same block
https://searchfox.org/mozilla-central/source/dom/system/OSFileConstants.cpp#534

As the change is trivial, it is just to learn how to contribute to Firefox.

Found by http://clang.llvm.org/extra/clang-tidy/checks/readability-redundant-preprocessor.html

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/tools/docs/contribute/how_to_contribute_firefox.html

How do i get started. What things (tools and repositories) do i need to download?

Flags: needinfo?(sledru)

I will attempt to fix this bug for my university module. I will try to finish this in the next few hours.

(In reply to abhinavk.grd from comment #1)

How do i get started. What things (tools and repositories) do i need to download?

Please read comment #0, you will find all the info that you need

Flags: needinfo?(sledru)
Assignee: nobody → nooffence7100
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/006b8b1bb7e4
removed a nested redundant #if r=sylvestre

(In reply to Pulsebot from comment #7)

Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0e8ea46ef18c
excludes => exclude r=marco

My bad, sorry

Attachment #9113204 - Attachment is obsolete: true

Bravo for your patch!

Thank you, great first experience!

Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
You need to log in before you can comment on or make changes to this bug.