Closed Bug 1600582 Opened 4 years ago Closed 3 years ago

Maximized window titlebar extends underneath Windows 10 taskbar

Categories

(Core :: Widget: Win32, defect, P1)

68 Branch
Unspecified
Windows 10
defect

Tracking

()

RESOLVED DUPLICATE of bug 1614218
Tracking Status
firefox-esr68 --- wontfix
firefox70 --- wontfix
firefox71 --- wontfix
firefox72 --- wontfix
firefox73 --- fix-optional

People

(Reporter: ke5trel, Unassigned)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

STR:

  1. On Windows 10 1909, move the taskbar to the top edge of the screen.
  2. Use a third party tool to increase taskbar transparency without a blur effect, in this case we are going to install Classic Shell 4.3.1 (http://classicshell.net/)
  3. Open Classic Shell's Start Menu Settings.
  4. Tick "Show all settings".
  5. Taskbar tab >> Customize taskbar >> Taskbar Opacity = 20.
  6. Maximize Firefox.

Expectation:

The titlebar should rest hard up against the taskbar like other applications.

Actual:

The titlebar extends underneath the taskbar by 8px.

Setting gfx.direct3d11.use-double-buffering = false avoids the issue.

Regression range:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=e8aebe488b2f2e567940577de25013d00e818f7c&tochange=e8d2d9aff5026ef1f1777b781b47fdcbdb9d8f20

Regressed by Bug 1547775.

Flags: needinfo?(bas)

Seeeems like P1: We should figure out what's up sooner rather than later. We can revisit prioritization when we know more.

Priority: -- → P1

I believe after my original patch was backed out, someone on the graphics team figured out most of the bugs left.

Fwiw, there's no bug with 1903 and no 3rd party shell modifiers. TBH, I don't really think this is terribly high priority considering this seems to only be a bug when using third party shell modifiers. In the worst case it may be fine to just blacklist double buffering when these types of modifiers are running. Since I believe 1909 is not released publically yet, it may also be that ClassicShell will fix this themselves.

Flags: needinfo?(bas)

The overlap can be measured using the browser inspector without any shell modifications. The #titlebar accounts for it with 8px top padding from -moz-appearance: -moz-window-titlebar-maximized so tabs don't appear under the taskbar or off the edge of the screen. Double buffering simply makes this padding visible under taskbars with transparency (whether it be Classic Shell, Open Shell or TranslucentTB).

Why are maximized windows being drawn 8px taller than they need to be?

Component: Graphics: Layers → Widget: Win32
See Also: → 1249496, 1403153
Blocks: 1580222

This bug affects all users using #titlebar {display:none}, to hide the tab bar and to replace them with extensions vertical tabbed .
We have to use @media(-moz-windows-default-theme) {[sizemode="maximized"] #nav-bar {margin-top: 8px}} for fix the shift of a part of the nav-bar beyond the screen.

See Also: → 1614218
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → DUPLICATE
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: