Closed Bug 1600593 Opened 3 months ago Closed 3 months ago

Remove generic snap offset references from shaders

Categories

(Core :: Graphics: WebRender, task, P3)

task

Tracking

()

RESOLVED FIXED
mozilla73
Tracking Status
firefox73 --- fixed

People

(Reporter: aosmond, Assigned: aosmond)

Details

Attachments

(1 file)

We no longer do post-snapping in the shaders. The inherent assumption is that most points and rects should already be snapped. There are exceptions, such as text, but it now follows the same model as everything else -- it pre-snaps first, and then can interact with other rects (such as clips) in the system. This was replaced by pre-snapping during scene building.

We now assume that most snapping is done during scene building. This
means that nearly every point and rect used in the shaders are
pre-snapped and nothing more need be done. The text shader is an
exception, but it also effectively pre-snaps because when it calculates
its local rect for a glyph, it takes into account any snapping
requirements, rather than adjusting for snapping after its local rect
interacts with other elements.

As such, we can remove any need for generic snap offsets from the
shaders.

Pushed by aosmond@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/984c5853985b
Remove snap offset references from the shaders. r=kvark
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
You need to log in before you can comment on or make changes to this bug.