1600606 - port changes from "Bug 1493292 - Remove aDataLen parameters from nsITransferable" and bug 1503588 to Thunderbird

Status: RESOLVED FIXED

(Thunderbird :: General, task)

Description

[Magnus Melin [:mkmelin]]

nsITransferable doesn't use the length param anymore, we have some left in tb:
https://searchfox.org/comm-central/search?q=getAnyTransferData&path=

Bug 1503588 and Bug 1493292 removed them.
https://hg.mozilla.org/mozilla-central/log/tip/widget/nsITransferable.idl

• nsITransferable.setTransferData
• nsITransferable.getTransferData
• nsITranserfable.getFlavorData
• nsITransferable.getAnyTransferData

Comment 1

[Khushil Mistry [:khushil324]]

Attachment: Bug-1600606_remove-length-nsITransferable-0.patch

https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=fdb0c4f8d81cbebe3f7110e643fc613ee9a0cb56

Comment 2

[Magnus Melin [:mkmelin]]

Comment on attachment 9113588 [details] [diff] [review]
Bug-1600606_remove-length-nsITransferable-0.patch

Review of attachment 9113588 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thx! r=mkmelin

::: calendar/base/content/calendar-clipboard.js
@@ +114,5 @@
>  
>      // Add data objects to transferable
>      // Both Outlook 2000 client and Lotus Organizer use text/unicode
>      // when pasting iCalendar data.
> +    trans.setTransferData("text/calendar", icsWrapper); // double byte data

you can remove this comment as there's not the *2 anymore

Comment 3

[Khushil Mistry [:khushil324]]

Attachment: Bug-1600606_remove-length-nsITransferable-1.patch

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/ea36e46709b5
Remove length parameter from nsITransferable methods. r=mkmelin

Comment 5

[Jorg K (CEST = GMT+2)]

Try to do a push after each M-C merge. You've already missed a merge today. Makes it harder to find the cause of bustages.