Closed Bug 1600671 Opened 4 years ago Closed 4 years ago

Doc for onLoadRequest mentions boolean even though it returns a `AllowOrDeny`

Categories

(GeckoView :: General, task, P3)

Unspecified
All

Tracking

(firefox73 fixed)

RESOLVED FIXED
mozilla73
Tracking Status
firefox73 --- fixed

People

(Reporter: agi, Assigned: agi)

Details

Attachments

(1 file)

The doc for onLoadRequest reads:

A GeckoResult with a AllowOrDeny value which indicates whether or not the load was
handled. If unhandled, Gecko will continue the load as normal. If handled (true value),
Gecko will abandon the load. A null return value is interpreted as false (unhandled).

true value should be replaced with DENY or something like that, since this method doesn't return a boolean.

https://mozilla.github.io/geckoview/javadoc/mozilla-central/org/mozilla/geckoview/GeckoSession.NavigationDelegate.html#onLoadRequest-org.mozilla.geckoview.GeckoSession-org.mozilla.geckoview.GeckoSession.NavigationDelegate.LoadRequest-

Assignee: nobody → agi
Pushed by asferro@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0080edc36b33
Improve doc for onLoadRequest. r=droeh
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: