1600715 - searchUrlGetParams in the modern configuration does not specify the parameter order

Status: RESOLVED FIXED

(Firefox :: Search, task, P1)

Description

[Mark Banner (:standard8)]

I've just noticed that with the modern configuration, searchUrlGetParams is an object with indeterminate order of the keys.

This is effectively a regression with the modern configuration - bug 1484232 intentionally changed the order of our parameters to better serve people using Google.

We need to be able to specify the order, like we can do with the current legacy configuration and WebExtensions.

Realistically, this probably means switching searchUrlGetParams and related items to be arrays of objects.

Ideally we should do this before landing bug 1542269, as it'll make it slightly simpler overall.

Comment 1

[Mark Banner (:standard8)]

Note: I picked this up as some of our tests currently break with modern configuration turned on due to the wrong order of keys.

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1600715 - Change the searchUrlParams in the modern config to be an ordered array of objects. r?mikedeboer

Comment 3

[Mark Banner (:standard8)]

Attachment: Bug 1600715 - Match the order of the extraParams for search engines to the existing lists. r?mikedeboer

We might as well do this for now to keep the tests passing when modern config is turned on. It doesn't actually matter what order these particular parameers are listed in.

Depends on D55640

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/67a38267ec0b
Change the searchUrlParams in the modern config to be an ordered array of objects. r=mikedeboer
https://hg.mozilla.org/integration/autoland/rev/f25b6b1800eb
Match the order of the extraParams for search engines to the existing lists. r=mikedeboer

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/67a38267ec0b
https://hg.mozilla.org/mozilla-central/rev/f25b6b1800eb