1600717 - Various webrtc wpt disabled on Fission

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, task, P2)

Description

[Byron Campen [:bwc]]

Need to figure out what is happening here.

Comment 1

[Chris Peterson [:cpeterson]]

Tracking test crashes for Fission's test-fixing milestone (M4.1)

Comment 2

[Chris Peterson [:cpeterson]]

Byron, this bug is a blocker for Fission's current milestone (M4.1 aka "fix all the mochitests"), but it's currently unassigned. How should I mark this bug so your team will investigate it for 73 or 74 Nightly? If you don't think these mochitest crashes should block shipping Fission, just let me know.

Comment 3

[Chris Peterson [:cpeterson]]

I see this is a WPT test, not a mochitest, and that failure is only expected for Fission on Linux without WebRender:

if (os == "linux") and fission and not debug and not webrender: ["OK", "TIMEOUT", "CRASH"]

https://searchfox.org/mozilla-central/rev/6305f6935f496b3a302c7afcc579399a4217729c/testing/web-platform/meta/webrtc/RTCRtpTransceiver-direction.html.ini#3

FWIW, the Fission team plans to require WebRender, so if these WPT crashes are non-WebRender only, then you can probably WONTFIX this bug.

Comment 4

[Byron Campen [:bwc]]

All of our wpt are failing intermittently on fission it seems. I have not had time to determine why. I can look into it once I'm done with bug 1591199.

Comment 5

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=350a742a38ec677bafb3507c37e36e535b234534&selectedJob=281957851

Comment 6

[Byron Campen [:bwc]]

I don't see any sign of these crashes on try, even with more than 100 retriggers. I do see the occasional "Executor hit external timeout" error (in tests that I didn't touch the ini file for), but that's happening all over the tree.

I have a feeling these ini file modifications are spurious.

Comment 7

[Byron Campen [:bwc]]

Trying a run with all of the web-platform-tests, to see if that makes any difference.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6f556d8097ad2edd380ce5e6f427d83de353c014

Comment 8

[Byron Campen [:bwc]]

"-u all" apparently doesn't run the fission wpt. Here's another go.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7d2af9870f21de8ab24699fcf16a4ca4e42eae14

Comment 9

[Byron Campen [:bwc]]

Yeah, these tests seem to be fine on fission. Not sure why they were disabled.

Comment 10

[Byron Campen [:bwc]]

Attachment: Bug 1600717: Re-enable these tests on fission. r?jib

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/09971aef170f
Re-enable these tests on fission. r=jib

Comment 12

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/09971aef170f