Closed Bug 1600809 Opened 4 years ago Closed 4 years ago

ubuntu1804 - devtools/client/shared/test/browser_html_tooltip_screen_edge.js | The tooltip panel is over (ie intersects) the anchor horizontally: 1270 < 1137 and 935 < 1280 -

Categories

(DevTools :: General, defect, P5)

defect

Tracking

(firefox73 fixed)

RESOLVED FIXED
Firefox 73
Tracking Status
firefox73 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: jdescottes)

References

Details

Attachments

(1 file)

Filed by: egao [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=279110104&repo=try
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/Wi7Xvj7ATjGVTv0isa-qhA/runs/0/artifacts/public/logs/live_backing.log


suite: mochitest-devtools-chrome
chunk: 2

context:
[task 2019-12-02T17:58:25.105Z] 17:58:25 INFO - TEST-START | devtools/client/shared/test/browser_html_tooltip_rtl.js
[task 2019-12-02T17:58:25.302Z] 17:58:25 INFO - GECKO(5896) | MEMORY STAT | vsize 3263MB | residentFast 434MB | heapAllocated 157MB
[task 2019-12-02T17:58:25.303Z] 17:58:25 INFO - TEST-OK | devtools/client/shared/test/browser_html_tooltip_rtl.js | took 199ms
[task 2019-12-02T17:58:25.326Z] 17:58:25 INFO - checking window state
[task 2019-12-02T17:58:25.346Z] 17:58:25 INFO - TEST-START | devtools/client/shared/test/browser_html_tooltip_screen_edge.js
[task 2019-12-02T17:58:25.463Z] 17:58:25 INFO - TEST-INFO | started process screentopng
[task 2019-12-02T17:58:25.827Z] 17:58:25 INFO - TEST-INFO | screentopng: exit 0
[task 2019-12-02T17:58:25.827Z] 17:58:25 INFO - Buffered messages logged at 17:58:25
[task 2019-12-02T17:58:25.827Z] 17:58:25 INFO - Entering test bound
[task 2019-12-02T17:58:25.827Z] 17:58:25 INFO - Create a doorhanger HTML tooltip with XULPanel
[task 2019-12-02T17:58:25.827Z] 17:58:25 INFO - Display the tooltip on an anchor.
[task 2019-12-02T17:58:25.828Z] 17:58:25 INFO - TEST-PASS | devtools/client/shared/test/browser_html_tooltip_screen_edge.js | Tooltip has an arrow -
[task 2019-12-02T17:58:25.829Z] 17:58:25 INFO - Buffered messages finished
[task 2019-12-02T17:58:25.830Z] 17:58:25 INFO - TEST-UNEXPECTED-FAIL | devtools/client/shared/test/browser_html_tooltip_screen_edge.js | The tooltip panel is over (ie intersects) the anchor horizontally: 1270 < 1137 and 935 < 1280 -
[task 2019-12-02T17:58:25.830Z] 17:58:25 INFO - Stack trace:
[task 2019-12-02T17:58:25.830Z] 17:58:25 INFO - chrome://mochikit/content/browser-test.js:test_ok:1299
[task 2019-12-02T17:58:25.831Z] 17:58:25 INFO - chrome://mochitests/content/browser/devtools/client/shared/test/browser_html_tooltip_screen_edge.js:null:63
[task 2019-12-02T17:58:25.831Z] 17:58:25 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1069
[task 2019-12-02T17:58:25.832Z] 17:58:25 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1104
[task 2019-12-02T17:58:25.832Z] 17:58:25 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:932
[task 2019-12-02T17:58:25.832Z] 17:58:25 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:805
[task 2019-12-02T17:58:25.833Z] 17:58:25 INFO - Leaving test bound
[task 2019-12-02T17:58:25.833Z] 17:58:25 INFO - TEST-PASS | devtools/client/shared/test/browser_html_tooltip_screen_edge.js | The main process DebuggerServer has no pending connection when the test ends -
[task 2019-12-02T17:58:25.833Z] 17:58:25 INFO - Restore original window position. 27, 0
[task 2019-12-02T17:58:25.834Z] 17:58:25 INFO - GECKO(5896) | MEMORY STAT | vsize 3263MB | residentFast 436MB | heapAllocated 160MB
[task 2019-12-02T17:58:25.835Z] 17:58:25 INFO - TEST-OK | devtools/client/shared/test/browser_html_tooltip_screen_edge.js | took 155ms
[task 2019-12-02T17:58:25.835Z] 17:58:25 INFO - checking window state
[task 2019-12-02T17:58:25.836Z] 17:58:25 INFO - TEST-START | devtools/client/shared/test/browser_html_tooltip_variable-height.js
[task 2019-12-02T17:58:25.905Z] 17:58:25 INFO - GECKO(5896) | MEMORY STAT | vsize 3263MB | residentFast 430MB | heapAllocated 152MB
[task 2019-12-02T17:58:25.905Z] 17:58:25 INFO - TEST-OK | devtools/client/shared/test/browser_html_tooltip_variable-height.js | took 342ms
[task 2019-12-02T17:58:25.925Z] 17:58:25 INFO - checking window state

This is what I assume is the failure screenshot:
https://firefoxci.taskcluster-artifacts.net/fKiXa-S6QwmnVX45iQK7jA/0/public/test_info//mozilla-test-fail-screenshot_fFlbbC.png

Julian - this is a failure that I am observing consistently on ubuntu1804 test image. Would you be able to take a look, or pass the ni to someone that may be able to comment on why this test may be failing on this platform?

Flags: needinfo?(jdescottes)

Hi Edwin!

I'll try to take a look, but I have a few questions :)

First, can we get an idea of the priority for those ubuntu1804 bugs?
Do we have a target date to start using this image on try?
I guess P5 is the default set by treeherder's tool, don't think it was the intended priority.

So far I've seen two bugs related to tooltips (this and Bug 1600185). I have looked at logs + screenshots, but they are not really telling much. The only thing is that both are relying on XUL panels to show tooltips. By any chance did you see other failures related to XUL panels in those try pushes?

Last question is, beyond doing try pushes, if we want to get an environment close to this locally, is there an image we can download and run in a VM? Otherwise we should just get http://releases.ubuntu.com/18.04/ and try to see if we repro?

Flags: needinfo?(jdescottes) → needinfo?(egao)

(In reply to Julian Descottes [:jdescottes] from comment #2)

First, can we get an idea of the priority for those ubuntu1804 bugs?
Do we have a target date to start using this image on try?
I guess P5 is the default set by treeherder's tool, don't think it was the intended priority.

I am aiming to finish the migration by end of December - there aren't too many serious bugs, so I think the timeline is feasible. This will give me time to work on the fallout of the migration as we head towards the all hands.

So far I've seen two bugs related to tooltips (this and Bug 1600185). I have looked at logs + screenshots, but they are not really telling much. The only thing is that both are relying on XUL panels to show tooltips. By any chance did you see other failures related to XUL panels in those try pushes?

I recall seeing a couple other failures with the XUL file extension, not sure if that is what you're looking for. The overall theme of failures with ubuntu1804 appears to be related to screen resolution, mouse location and clipboard.

Last question is, beyond doing try pushes, if we want to get an environment close to this locally, is there an image we can download and run in a VM? Otherwise we should just get http://releases.ubuntu.com/18.04/ and try to see if we repro?

You can do a try push using the ubuntu1804 image by appending the argument --ubuntu-bionic to try fuzzy selector. I know other devs for whom I've filed issues have generally been able to reproduce issues on their VM using stock image from Canonical, or they run ubuntu natively and reproduce on their workstations.

Let me know if you need any other information!

Flags: needinfo?(egao)

Thanks!

So I managed to reproduce this intermittently on a VM. It seems due to window move/resize being sometimes more async on Linux than on other platforms (not sure why this distro would be impacted more than the previous one though).

So in this test we do:

win.moveTo(screenWidth - win.outerWidth, originalTop);

and then immediately show the tooltip.
The tooltip needs to retrieve the anchor's position before being displayed.
Sometimes what happens is that the position returned for the anchor is incorrect, as if the window had not been resized.

I found similar comments in tests in the codebase that seem to confirm this is a lingering issue: https://searchfox.org/mozilla-central/rev/8bc24752246aeac8a9aed566cf1caccf88d97d11/browser/components/extensions/test/browser/browser_ext_browserAction_popup_resize_bottom.js#23-36

Slightly waiting after the move seems to fix the issue locally. Will push to try

Assignee: nobody → jdescottes
Status: NEW → ASSIGNED

Thanks for your investigation, appreciate it.

With regards to the windowing on ubuntu1804, I may have some relevant information.

In the marionette harness bug I filed over at bug 1600391 I have been working to correct a problematic behavior with ubuntu1804 where marionette always reports a discrepancy with:

  • the maximum permissible window size vs the actual maximized size
  • window position after it has been moved

I think the issue above is probably why this issue is occurring.

I have not been able to figure out why this is the case, or how to fix it. I have tried adding some time delays, specify a different initial (x, y) coordinate to place the window, removing the dock/top menu bar but no solutions yet.

Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2a1894b3cfe3
Wait after moving window in devtools tooltip tests to avoid failures on ubuntu1804 r=daisuke
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 73
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: