1600864 - Remove legacy aboutDialog-appUpdater.js implementation

Status: RESOLVED FIXED

(Toolkit :: Application Update, task, P3)

Description

[Drew Willcoxon :adw]

Bug 1599360 added a new AppUpdater.jsm that we intend to use in an experiment targeted for 72 (bug 1564506). We wanted test coverage for it, so we rewrote aboutDialog-appUpdater.js to use it. But we also didn't want that rewrite landing at the end of a cycle, so we kept around the old aboutDialog-appUpdater.js. The new one is currently preffed off, and our tests test both versions.

Now that we're at the beginning of a new cycle, we should remove the old aboutDialog-appUpdater.js and use the new version always.

Comment 1

[Drew Willcoxon :adw]

Attachment: Bug 1600864 - Remove legacy aboutDialog-appUpdater.js implementation

This patch reverts the relevant parts of D54837

Comment 2

[Robert Strong (they/them - no direct email)]

This will need to be reviewed by someone else. Perhaps mhowell or bytesized

Comment 3

[Nick Alexander :nalexander [he/him]]

adw: could this be a good mentored ticket, a pre-cursor to https://bugzilla.mozilla.org/show_bug.cgi?id=1643309? If yes, could you provide a sketch of what needs to be done?

Comment 4

[Drew Willcoxon :adw]

The patch is done, it just needs to be unbitrotted (if it is bitrotted, hopefully not), and then I need to request review as Robert mentioned in comment 2. I'll go ahead and do that.

Comment 5

[Drew Willcoxon :adw]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=770446046890a776a346f49a4ed4273ee0bb7dd8

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5ce71a4b0949
Remove legacy aboutDialog-appUpdater.js implementation r=bytesized

Comment 7

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/5ce71a4b0949