1600954 - [autoconfig] Re-run config after password changed

Status: RESOLVED FIXED

(Thunderbird :: Account Manager, enhancement)

Description

[Ben Bucksch (:BenB)]

In the account creation dialog:

1. Enter a wrong email address, e.g. [e-mail]
2. Enter a right password
3. Click Continue
4. -> We run the config detection, and get no result
5. Correct the email address to [e-mail]
6. -> We remove the config
7. Click Continue
8. -> We show the right config

This is correct. The case to fix is:

1. Enter a right email address
2. Enter the wrong password
3. Click Continue
4. -> We run the config detection, and show the result
5. Correct the password
6. -> The config stays
7. Click Done
8. -> We show "password wrong"

This is fine for almost all ISPs, where the config does not depend on the password.
Some Exchange configs, the password matters, so there, we should re-run the config process.
We should also make the username field go away in this case, if it's showing and still empty.

Comment 1

[Ben Bucksch (:BenB)]

Attachment: Start over after changing password, v1

This does the same thing for the password as we do for the email address field.
Also, drop the username field (compare bug 1593122). It will show again as needed.

Note that I consider this an edge case. I presume that the user entered the correct password. Esp. given that there is now an eye button to show the password. But just in case, this patch should fix the cases where the user entered the wrong password.

Comment 2

[Alessandro Castellani [:aleca]]

Comment on attachment 9113239 [details] [diff] [review]
Start over after changing password, v1

Review of attachment 9113239 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for taking care of this, indeed if email or password change, the config should happen again.

::: mail/components/accountcreation/content/emailWizard.js
@@ +518,4 @@
>      this.checkStartDone();
> +    if (!this._exchangeUsername) {
> +      _hide("usernameRow");
> +    }

I'm not sure about hiding the username if empty.
We might stumble in a situation where the user is updating the password before filling up the username field, and if we hide it he will be forced to click "continue" again to make it visible, which is a bit weird.

Better to keep this visible if it shows up during an Exchange setup.

Comment 3

[Jorg K (CEST = GMT+2)]

Ben, please address comment #2 so we can move forward.

Comment 4

[Ben Bucksch (:BenB)]

Attachment: Start over after changing password, v2

With Aleca's review comment addressed

Comment 5

[Jorg K (CEST = GMT+2)]

Comment on attachment 9117572 [details] [diff] [review]
Start over after changing password, v2

Looks like Alex is taking his PTO more seriously than me ;-) - This is a simple patch and I think I can approve it. I've tested it, too.

Ben, as a Christmas present, **please** include eight lines of context in your patches. It's really quite impossible to review without it.

Sadly no one has landed anything after the last merge, so I'll do it now before it's too late.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/0ab86bf9ef19
[autoconfig] Re-run config after password changed. r=jorgk

Comment 7

[Ben Bucksch (:BenB)]

Thanks for having landed this.

Comment 8

[Jorg K (CEST = GMT+2)]

Comment on attachment 9117572 [details] [diff] [review]
Start over after changing password, v2

In case we're doing a TB 72 beta 3 before the next branch date on 2020-01-06.

Comment 9

[Alessandro Castellani [:aleca]]

This is good, thanks for landing this Jorg.

Comment 10

[Geoff Lankow (:darktrojan)]

72.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/148cc4c05d832e1f3bbd05cc6965a777949c0e2b

Comment 11

[Geoff Lankow (:darktrojan)]

68.4:
https://hg.mozilla.org/releases/comm-esr68/rev/c139962d61d6d14d69e2e38b3e2aa61866c325a2