Closed Bug 1600956 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 20585 - [LayoutNG] Set column fragments to the actual column size.

Categories

(Core :: Layout: Columns, task, P4)

Product:
Core
Component:
Layout: Columns
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla73
Tracking Flags:
Tracking Status
firefox73 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 20585 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/20585
Details from upstream follow.

Morten Stenshorne <mstensho@chromium.org> wrote:

[LayoutNG] Set column fragments to the actual column size.

Just letting the fragmentation machinery do what it would do if it gets
to treat column boxes as regular column content was no conscious choice,
and it turns out that setting the column fragments to the actual column
size is better, or we get some trouble with overflow, both when it comes
to painting column rules, and the fact that we get spurious empty column
fragments after unbreakable content (new unit test
NGColumnLayoutAlgorithmTest.TallReplacedContent).

Remove fast/multicol/rule-in-nested-with-too-tall-line.html and replace
it with a valid test (that still fails both in legacy and NG; in NG
because we fail to paint text on a general basis).

Bug: 829028
Change-Id: I3656c299c7a87bea29e1790477cf524b9522fa97
Reviewed-on: https://chromium-review.googlesource.com/1948923
WPT-Export-Revision: e78eed43f9f14b4d524a2b977a2fa03969ee1165

Component: web-platform-tests → Layout: Columns
Product: Testing → Core

GitHub CI Results

wpt.fyi PR Results Base Results

Ran 2 tests

Firefox

PASS: 2

Chrome

PASS: 1
FAIL: 1

Safari

PASS: 1
FAIL: 1

Gecko CI Results

Ran 2 tests
PASS : 2

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/29b7257d966c
[wpt PR 20585] - [LayoutNG] Set column fragments to the actual column size., a=testonly

https://hg.mozilla.org/mozilla-central/rev/29b7257d966c

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox73: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
You need to log in before you can comment on or make changes to this bug.