1600963 - tidy up some json serialization stuff

Status: RESOLVED FIXED

(Core :: Security: CAPS, task)

Description

[Nathan Froyd [:froydnj]]

While trying to understand some errors related to jsoncpp, I stumbled across this json serialization code principals have, and we can do things slightly better.

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: Bug 1600963 - reduce boilerplate for serialized keys in principals; r=mccr8

Comment 2

[Nathan Froyd [:froydnj]]

Attachment: Bug 1600963 - reduce size of principal KeyVals; r=mccr8

By declaring the individual enum types to fit in a uint8_t, and
rearranging the templated KeyValT struct, we can pack KeyValT
to save a word of storage.

Depends on D55686

Comment 3

[Nathan Froyd [:froydnj]]

Attachment: Bug 1600963 - don't lookup keys twice in the serialized JSON; r=mccr8

Depends on D55687

Comment 4

[Nathan Froyd [:froydnj]]

Attachment: Bug 1600963 - build fields directly in the returned array; r=mccr8

This change means fewer temporary objects, particularly nsCString objects.

Depends on D55688

Comment 5

[Nathan Froyd [:froydnj]]

Attachment: Bug 1600963 - remove some duplicate includes from ContentPrincipal.cpp; r=mccr8

Depends on D55689

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/80ea7acaee75
reduce boilerplate for serialized keys in principals; r=mccr8
https://hg.mozilla.org/integration/autoland/rev/9a8f628488e8
reduce size of principal KeyVals; r=mccr8
https://hg.mozilla.org/integration/autoland/rev/ed26e312383c
don't lookup keys twice in the serialized JSON; r=mccr8
https://hg.mozilla.org/integration/autoland/rev/9737d57b7fd0
build fields directly in the returned array; r=mccr8
https://hg.mozilla.org/integration/autoland/rev/4c764c0dbfd8
remove some duplicate includes from ContentPrincipal.cpp; r=mccr8

Comment 7

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/80ea7acaee75
https://hg.mozilla.org/mozilla-central/rev/9a8f628488e8
https://hg.mozilla.org/mozilla-central/rev/ed26e312383c
https://hg.mozilla.org/mozilla-central/rev/9737d57b7fd0
https://hg.mozilla.org/mozilla-central/rev/4c764c0dbfd8