Closed
Bug 1600981
Opened 6 years ago
Closed 6 years ago
messaging_example: window.browser is not defined
Categories
(GeckoView :: Extensions, defect)
Tracking
(firefox73 fixed)
RESOLVED
FIXED
mozilla73
| Tracking | Status | |
|---|---|---|
| firefox73 | --- | fixed |
People
(Reporter: agi, Assigned: agi)
Details
Attachments
(1 file)
While looking at https://github.com/mozilla/geckoview/issues/108 I noticed that the messaging_example doesn't work anymore, running it results in:
12-03 08:22:08.974 18158 18173 E Web Content: [JavaScript Error: "TypeError: window.browser is undefined" {file: "moz-extension://4b08f29f-0c5f-4ee7-8139-327930a31961/messaging.js" line: 11}]
And also there's no @Override in here: https://searchfox.org/mozilla-central/rev/04d8e7629354bab9e6a285183e763410860c5006/mobile/android/examples/messaging_example/app/src/main/java/org/mozilla/geckoview/example/messaging/MainActivity.java#33-35 so we missed that the signature changed :(
|
Assignee | |
Comment 1•6 years ago
|
||
|
||
Updated•6 years ago
|
Attachment #9113255 -
Attachment description: Bug 1600981 - use browser instead of window.browser in messaging_example. → Bug 1600981 - use browser instead of window.browser in {port_,}messaging_example.
Pushed by asferro@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1a03be7c9e5b
use browser instead of window.browser in {port_,}messaging_example. r=fluffyemily,snorp
|
||
Comment 3•6 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox73:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
You need to log in
before you can comment on or make changes to this bug.
Description
•