Closed
Bug 1600992
Opened 4 years ago
Closed 4 years ago
Some generated headers are self included
Categories
(Core :: DOM: Bindings (WebIDL), task)
Core
DOM: Bindings (WebIDL)
Tracking
()
RESOLVED
FIXED
mozilla73
| Tracking | Status | |
|---|---|---|
| firefox73 | --- | fixed |
People
(Reporter: calixte, Assigned: calixte)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
For example:
https://searchfox.org/mozilla-central/source/__GENERATED__/dist/include/mozilla/dom/WindowBinding.h#8
https://searchfox.org/mozilla-central/source/__GENERATED__/dist/include/mozilla/dom/MutationObserverBinding.h#7
...
Moving the line:
https://searchfox.org/mozilla-central/source/dom/bindings/Codegen.py#1218
just before the call to CGWrapper ctor (https://searchfox.org/mozilla-central/source/dom/bindings/Codegen.py#1307) seems to fix it.
|
Assignee | |
Updated•4 years ago
|
Blocks: includehell
|
|
Assignee | |
Comment 1•4 years ago
|
||
These self inclusions are useless so just remove them.
Pushed by cdenizet@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/bc197ea8ae32 Remove self header inclusion on generated webidl bindings r=bzbarsky
|
||
Comment 3•4 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox73:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
You need to log in
before you can comment on or make changes to this bug.
Description
•