1601012 - [wpt-sync] Sync PR 20588 - Revert "[LayoutNG] Set ShrinkToFit when determining MinMaxSize via layout"

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 20588 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/20588
Details from upstream follow.

David Grogan <[e-mail]> wrote:

Revert "[LayoutNG] Set ShrinkToFit when determining MinMaxSize via layout"

This reverts commit 4fb5e9ecba28a18c69ef4736cce74664ae82af6a.

Reason for revert: Triggered DCHECK !constraint_space.IsIntermediateLayout() || box_->NeedsLayout()

Original change's description:

[LayoutNG] Set ShrinkToFit when determining MinMaxSize via layout

Bug: 635619
Change-Id: I6f7b1e16098a773aab2ac395b3b23e8b2af2b99e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1920200
Reviewed-by: Morten Stenshorne \<[e-mail]>
Reviewed-by: Christian Biesinger \<[e-mail]>
Commit-Queue: David Grogan \<[e-mail]>
Cr-Commit-Position: refs/heads/master@{#716907}

TBR=[e-mail],[e-mail],[e-mail]

Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 635619, 1027759
Change-Id: I961ca71602f331d2a612d430e9a4ae049e331b1c

Reviewed-on: https://chromium-review.googlesource.com/1948496
WPT-Export-Revision: a6e066ee838ab5fe6dba759be2990137528b9338

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=404c4e9ddbd63763f77cd5638b0fe7a8b536b2f6

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Test result changes from PR not available.

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Test result changes from PR not available.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d40d8e7f2725
[wpt PR 20588] - Revert "[LayoutNG] Set ShrinkToFit when determining MinMaxSize via layout", a=testonly

Comment 5

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/d40d8e7f2725