Debugger "Paused" banner polish: Move info icon from right side to left of text
Categories
(DevTools :: Debugger, enhancement)
Tracking
(firefox79 fixed)
| Tracking | Status | |
|---|---|---|
| firefox79 | --- | fixed |
People
(Reporter: victoria, Assigned: kyleknaggs)
Details
(Keywords: good-first-bug)
Attachments
(2 files)
image.png
When we display this icon by itself anywhere else, it acts as a button. Since in this case, it acts as visual decoration for the banner instead, we should move it to the left of the text.
For the space between the icon and text, use same the spacing as Console's icon/message spacing.
Re: vertical spacing: Icon should remain centered when the banner has multiple lines, as it currently does.
|
Assignee | |
Comment 1•4 years ago
|
||
Hello! I've been looking at this bug for a little bit and I would be very happy to help out with it. I've developed a working solution for this enhancement and would be enthusiastic about submitting a patch to Phabricator at some point during the next couple of days.
|
|
Assignee | |
Comment 2•4 years ago
|
||
I would like to claim this issue if that is possible.
|
||
Comment 3•4 years ago
|
||
Thank you Kyle, you are assigned. Feel free to ask in our Debugger channels if you need any help.
|
|
Assignee | |
Comment 4•4 years ago
|
||
Moved info icon from after text to before text.
Matched the spacing between the icon and text to the spacing between the icon and text in the Console.
Updated relevant WhyPaused snapshot tests.
Pushed by jlaster@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d44e2877a9b3 Moved info icon from right side to left side of WhyPaused text r=jlast
|
||
Comment 6•4 years ago
|
||
| bugherder | ||
Description
•