1601093 - Rename remaining .xul files to .xhtml in toolkit/

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, task, P3)

Description

[Brian Grinstead [:bgrins]]

These files, along with references:

./toolkit/content/resetProfile.xul
./toolkit/content/editMenuKeys.inc.xul
./toolkit/content/resetProfileProgress.xul
./toolkit/components/passwordmgr/content/passwordManager.xul
./toolkit/components/viewconfig/content/config.xul
./toolkit/components/printing/content/printPageSetup.xul
./toolkit/components/printing/content/printPreviewProgress.xul
./toolkit/components/printing/content/printProgress.xul
./toolkit/components/extensions/dummy.xul
./toolkit/components/apppicker/content/appPicker.xul
./toolkit/components/alerts/resources/content/alert.xul
./toolkit/components/prompts/content/commonDialog.xul
./toolkit/components/prompts/content/selectDialog.xul
./toolkit/profile/content/profileDowngrade.xul
./toolkit/profile/content/createProfileWizard.xul
./toolkit/profile/content/profileSelection.xul
./toolkit/modules/win.xul

Comment 1

[Emma Malysz]

Attachment: Bug 1601093, Rename the remaining .xul files to .xhtml in toolkit/

Comment 2

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/integration/autoland/rev/dd809e835f2a8f2c6a1c5269d08b0b90e048c317

Comment 3

[Raul Gurzau (:RaulG)]

Backed out changeset dd809e835f2a (bug 1601093) for eslint failures at alert.xhtml and commonDialog.xhtml on a CLOSED TREE.

Backout link: https://hg.mozilla.org/integration/autoland/rev/096660d5d8b6834c035032d7f82905ebc4592c12

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=dd809e835f2a8f2c6a1c5269d08b0b90e048c317&selectedJob=280708546

Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=280708546&repo=autoland&lineNumber=55

Log snippet:

[vcs 2019-12-11T17:06:59.045Z] 102 files updated, 0 files merged, 17 files removed, 0 files unresolved
[vcs 2019-12-11T17:06:59.177Z] updated to dd809e835f2a8f2c6a1c5269d08b0b90e048c317
[vcs 2019-12-11T17:06:59.180Z] PERFHERDER_DATA: {"framework": {"name": "vcs"}, "suites": [{"extraOptions": ["c3.2xlarge"], "lowerIsBetter": true, "name": "pull", "serverUrl": "us-east-1.hgmointernal.net", "shouldAlert": false, "subtests": [], "value": 10.17494797706604}, {"extraOptions": ["c3.2xlarge"], "lowerIsBetter": true, "name": "purge", "serverUrl": "us-east-1.hgmointernal.net", "shouldAlert": false, "subtests": [], "value": 3.3606410026550293}, {"extraOptions": ["c3.2xlarge"], "lowerIsBetter": true, "name": "update", "serverUrl": "us-east-1.hgmointernal.net", "shouldAlert": false, "subtests": [], "value": 2.4075889587402344}, {"extraOptions": ["c3.2xlarge"], "lowerIsBetter": true, "name": "overall", "serverUrl": "us-east-1.hgmointernal.net", "shouldAlert": false, "subtests": [], "value": 16.383997917175293}, {"extraOptions": ["c3.2xlarge"], "lowerIsBetter": true, "name": "overall_pull", "serverUrl": "us-east-1.hgmointernal.net", "shouldAlert": false, "subtests": [], "value": 16.383997917175293}, {"extraOptions": ["c3.2xlarge"], "lowerIsBetter": true, "name": "overall_pull_fullcheckout", "serverUrl": "us-east-1.hgmointernal.net", "shouldAlert": false, "subtests": [], "value": 16.383997917175293}, {"extraOptions": ["c3.2xlarge"], "lowerIsBetter": true, "name": "overall_pull_populatedwdir", "serverUrl": "us-east-1.hgmointernal.net", "shouldAlert": false, "subtests": [], "value": 16.383997917175293}]}
[vcs 2019-12-11T17:06:59.472Z] TinderboxPrint:<a href=https://us-east-1.hgmointernal.net/integration/autoland/rev/dd809e835f2a8f2c6a1c5269d08b0b90e048c317 title='Built from autoland revision dd809e835f2a8f2c6a1c5269d08b0b90e048c317'>dd809e835f2a8f2c6a1c5269d08b0b90e048c317</a>
[setup 2019-12-11T17:06:59.472Z] GECKO_PATH is /builds/worker/checkouts/gecko
[task 2019-12-11T17:06:59.472Z] executing ['bash', '-cx', 'cp -r /build/node_modules_eslint node_modules && ln -s ../tools/lint/eslint/eslint-plugin-mozilla node_modules && ln -s ../tools/lint/eslint/eslint-plugin-spidermonkey-js node_modules && ./mach lint -l eslint -f treeherder --quiet -f json:/builds/worker/mozlint.json\n']in /builds/worker/checkouts/gecko
[task 2019-12-11T17:06:59.475Z] + cp -r /build/node_modules_eslint node_modules
[task 2019-12-11T17:06:59.806Z] + ln -s ../tools/lint/eslint/eslint-plugin-mozilla node_modules
[task 2019-12-11T17:06:59.807Z] + ln -s ../tools/lint/eslint/eslint-plugin-spidermonkey-js node_modules
[task 2019-12-11T17:06:59.808Z] + ./mach lint -l eslint -f treeherder --quiet -f json:/builds/worker/mozlint.json
[task 2019-12-11T17:07:01.276Z] Using base prefix '/usr'
[task 2019-12-11T17:07:01.276Z] New python executable in /builds/worker/checkouts/gecko/obj-x86_64-pc-linux-gnu/_virtualenvs/init_py3/bin/python3
[task 2019-12-11T17:07:01.277Z] Also creating executable in /builds/worker/checkouts/gecko/obj-x86_64-pc-linux-gnu/_virtualenvs/init_py3/bin/python
[task 2019-12-11T17:07:01.277Z] Installing setuptools, pip, wheel...
[task 2019-12-11T17:07:03.680Z] done.
[task 2019-12-11T17:07:04.886Z] b"running build_ext\nbuilding 'psutil._psutil_linux' extension\ncreating build\ncreating build/temp.linux-x86_64-3.5\ncreating build/temp.linux-x86_64-3.5/psutil\nx86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -g -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -DPSUTIL_POSIX=1 -DPSUTIL_VERSION=563 -DPSUTIL_LINUX=1 -I/usr/include/python3.5m -I/builds/worker/checkouts/gecko/obj-x86_64-pc-linux-gnu/_virtualenvs/init_py3/include/python3.5m -c psutil/_psutil_common.c -o build/temp.linux-x86_64-3.5/psutil/_psutil_common.o\nx86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -g -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -DPSUTIL_POSIX=1 -DPSUTIL_VERSION=563 -DPSUTIL_LINUX=1 -I/usr/include/python3.5m -I/builds/worker/checkouts/gecko/obj-x86_64-pc-linux-gnu/_virtualenvs/init_py3/include/python3.5m -c psutil/_psutil_posix.c -o build/temp.linux-x86_64-3.5/psutil/_psutil_posix.o\nx86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -g -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -DPSUTIL_POSIX=1 -DPSUTIL_VERSION=563 -DPSUTIL_LINUX=1 -I/usr/include/python3.5m -I/builds/worker/checkouts/gecko/obj-x86_64-pc-linux-gnu/_virtualenvs/init_py3/include/python3.5m -c psutil/_psutil_linux.c -o build/temp.linux-x86_64-3.5/psutil/_psutil_linux.o\ncreating build/lib.linux-x86_64-3.5\ncreating build/lib.linux-x86_64-3.5/psutil\nx86_64-linux-gnu-gcc -pthread -shared -Wl,-O1 -Wl,-Bsymbolic-functions -Wl,-Bsymbolic-functions -Wl,-z,relro -Wl,-Bsymbolic-functions -Wl,-z,relro -g -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 build/temp.linux-x86_64-3.5/psutil/_psutil_common.o build/temp.linux-x86_64-3.5/psutil/_psutil_posix.o build/temp.linux-x86_64-3.5/psutil/_psutil_linux.o -o build/lib.linux-x86_64-3.5/psutil/_psutil_linux.cpython-35m-x86_64-linux-gnu.so\nbuilding 'psutil._psutil_posix' extension\nx86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -g -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -DPSUTIL_POSIX=1 -DPSUTIL_VERSION=563 -DPSUTIL_LINUX=1 -I/usr/include/python3.5m -I/builds/worker/checkouts/gecko/obj-x86_64-pc-linux-gnu/_virtualenvs/init_py3/include/python3.5m -c psutil/_psutil_common.c -o build/temp.linux-x86_64-3.5/psutil/_psutil_common.o\nx86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -g -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -DPSUTIL_POSIX=1 -DPSUTIL_VERSION=563 -DPSUTIL_LINUX=1 -I/usr/include/python3.5m -I/builds/worker/checkouts/gecko/obj-x86_64-pc-linux-gnu/_virtualenvs/init_py3/include/python3.5m -c psutil/_psutil_posix.c -o build/temp.linux-x86_64-3.5/psutil/_psutil_posix.o\nx86_64-linux-gnu-gcc -pthread -shared -Wl,-O1 -Wl,-Bsymbolic-functions -Wl,-Bsymbolic-functions -Wl,-z,relro -Wl,-Bsymbolic-functions -Wl,-z,relro -g -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 build/temp.linux-x86_64-3.5/psutil/_psutil_common.o build/temp.linux-x86_64-3.5/psutil/_psutil_posix.o -o build/lib.linux-x86_64-3.5/psutil/_psutil_posix.cpython-35m-x86_64-linux-gnu.so\ncopying build/lib.linux-x86_64-3.5/psutil/_psutil_linux.cpython-35m-x86_64-linux-gnu.so -> psutil\ncopying build/lib.linux-x86_64-3.5/psutil/_psutil_posix.cpython-35m-x86_64-linux-gnu.so -> psutil\n"
[task 2019-12-11T17:07:04.886Z] Error processing command. Ignoring because optional. (optional:packages.txt:comm/build/virtualenv_packages.txt)
[task 2019-12-11T17:20:36.261Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/toolkit/components/alerts/resources/content/alert.xhtml:65:11 | 'prefillAlertInfo' is not defined. (no-undef)
[task 2019-12-11T17:20:36.261Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/toolkit/components/prompts/content/commonDialog.xhtml:28:7 | 'commonDialogOnLoad' is not defined. (no-undef)
[taskcluster 2019-12-11 17:20:36.618Z] === Task Finished ===
[taskcluster 2019-12-11 17:20:37.629Z] Unsuccessful task run with exit code: 1 completed in 836.451 seconds

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3030229d21a4
Rename the remaining .xul files to .xhtml in toolkit/ r=marionette-reviewers,mossop,whimboo

Comment 5

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/3030229d21a4