Closed Bug 1601107 Opened 5 years ago Closed 5 years ago

Don't break test_build_profile for desktop Firefox, when defaulting to using conditioned profiles

Categories

(Testing :: Raptor, defect)

Product:
Testing
Component:
Raptor
Version:
Version 3
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED INVALID

People

(Reporter: stephend, Assigned: stephend)

References

(
URL
)

Details

With my current approach for bug 1600838 (https://hg.mozilla.org/try/rev/04fb0b3f029f12050af255eca49fa5a2a351a3ba), I'm breaking (https://firefoxci.taskcluster-artifacts.net/WFp5ln9PRmagjXEf2dLztQ/0/public/logs/live_backing.log):

testing/raptor/test/test_raptor.py::test_build_profile

[task 2019-12-03T22:09:46.612Z] 1:42.87 =================================== FAILURES ===================================
[task 2019-12-03T22:09:46.612Z] 1:42.87 _______________ test_build_profile[RaptorDesktopFirefox-firefox] _______________
[task 2019-12-03T22:09:46.612Z] 1:42.87
[task 2019-12-03T22:09:46.612Z] 1:42.87 options = {'app': 'firefox', 'binary': 'path/to/dummy/browser'}
[task 2019-12-03T22:09:46.612Z] 1:42.87 perftest_class = <class 'raptor.raptor.RaptorDesktopFirefox'>
[task 2019-12-03T22:09:46.612Z] 1:42.87 app_name = 'firefox', get_prefs = None
[task 2019-12-03T22:09:46.612Z] 1:42.87
[task 2019-12-03T22:09:46.612Z] 1:42.87 @pytest.mark.parametrize("perftest_class, app_name", [
[task 2019-12-03T22:09:46.612Z] 1:42.87 [RaptorDesktopFirefox, "firefox"],
[task 2019-12-03T22:09:46.612Z] 1:42.87 [RaptorDesktopChrome, "chrome"],
[task 2019-12-03T22:09:46.612Z] 1:42.87 [RaptorDesktopChrome, "chromium"],
[task 2019-12-03T22:09:46.612Z] 1:42.87 [RaptorAndroid, "fennec"],
[task 2019-12-03T22:09:46.612Z] 1:42.87 [RaptorAndroid, "geckoview"],
[task 2019-12-03T22:09:46.612Z] 1:42.87 [BrowsertimeDesktop, "firefox"],
[task 2019-12-03T22:09:46.612Z] 1:42.87 [BrowsertimeDesktop, "chrome"],
[task 2019-12-03T22:09:46.612Z] 1:42.87 [BrowsertimeDesktop, "chromium"],
[task 2019-12-03T22:09:46.612Z] 1:42.87 [BrowsertimeAndroid, "fennec"],
[task 2019-12-03T22:09:46.612Z] 1:42.87 [BrowsertimeAndroid, "geckoview"],
[task 2019-12-03T22:09:46.612Z] 1:42.87 ])
[task 2019-12-03T22:09:46.612Z] 1:42.87 def test_build_profile(options, perftest_class, app_name, get_prefs):
[task 2019-12-03T22:09:46.612Z] 1:42.87 options['app'] = app_name
[task 2019-12-03T22:09:46.612Z] 1:42.87 > perftest_instance = perftest_class(**options)
[task 2019-12-03T22:09:46.612Z] 1:42.87
[task 2019-12-03T22:09:46.612Z] 1:42.87 testing/raptor/test/test_raptor.py:58:
[task 2019-12-03T22:09:46.612Z] 1:42.87 _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
[task 2019-12-03T22:09:46.612Z] 1:42.87 testing/raptor/raptor/raptor.py:1037: in init
[task 2019-12-03T22:09:46.612Z] 1:42.87 super(RaptorDesktop, self).init(*args, **kwargs)
[task 2019-12-03T22:09:46.612Z] 1:42.87 testing/raptor/raptor/raptor.py:842: in init
[task 2019-12-03T22:09:46.612Z] 1:42.87 super(Raptor, self).init(*args, **kwargs)
[task 2019-12-03T22:09:46.612Z] 1:42.87 testing/raptor/raptor/raptor.py:177: in init
[task 2019-12-03T22:09:46.613Z] 1:42.87 self.build_browser_profile()
[task 2019-12-03T22:09:46.613Z] 1:42.87 testing/raptor/raptor/raptor.py:939: in build_browser_profile
[task 2019-12-03T22:09:46.613Z] 1:42.87 super(Raptor, self).build_browser_profile()
[task 2019-12-03T22:09:46.613Z] 1:42.87 testing/raptor/raptor/raptor.py:204: in build_browser_profile
[task 2019-12-03T22:09:46.613Z] 1:42.87 self.get_conditioned_profile()
[task 2019-12-03T22:09:46.613Z] 1:42.87 testing/raptor/raptor/raptor.py:188: in get_conditioned_profile
[task 2019-12-03T22:09:46.613Z] 1:42.87 cond_prof_target_dir = get_profile(temp_download_dir, platform, "cold")
[task 2019-12-03T22:09:46.613Z] 1:42.87 testing/condprofile/condprof/client.py:80: in get_profile
[task 2019-12-03T22:09:46.613Z] 1:42.87 size = len(list(tar))
[task 2019-12-03T22:09:46.613Z] 1:42.87 /usr/lib/python2.7/tarfile.py:2508: in next
[task 2019-12-03T22:09:46.613Z] 1:42.87 tarinfo = self.tarfile.next()
[task 2019-12-03T22:09:46.613Z] 1:42.87 /usr/lib/python2.7/tarfile.py:2348: in next
[task 2019-12-03T22:09:46.613Z] 1:42.87 self.fileobj.seek(self.offset - 1)
[task 2019-12-03T22:09:46.613Z] 1:42.87 /usr/lib/python2.7/gzip.py:443: in seek
[task 2019-12-03T22:09:46.613Z] 1:42.87 self.read(1024)
[task 2019-12-03T22:09:46.613Z] 1:42.87 /usr/lib/python2.7/gzip.py:268: in read
[task 2019-12-03T22:09:46.613Z] 1:42.87 self._read(readsize)
[task 2019-12-03T22:09:46.613Z] 1:42.87 /usr/lib/python2.7/gzip.py:315: in _read
[task 2019-12-03T22:09:46.613Z] 1:42.87 self._read_eof()
[task 2019-12-03T22:09:46.613Z] 1:42.87 /usr/lib/python2.7/gzip.py:350: in _read_eof
[task 2019-12-03T22:09:46.613Z] 1:42.87 crc32 = read32(self.fileobj)
[task 2019-12-03T22:09:46.613Z] 1:42.87 _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
[task 2019-12-03T22:09:46.613Z] 1:42.87
[task 2019-12-03T22:09:46.613Z] 1:42.87 input = <closed file '/builds/worker/.condprof-cache/profile-linux64-cold-default.tgz', mode 'rb' at 0x7f9a044cfa50>
[task 2019-12-03T22:09:46.613Z] 1:42.87
[task 2019-12-03T22:09:46.613Z] 1:42.87 def read32(input):
[task 2019-12-03T22:09:46.613Z] 1:42.87 > return struct.unpack("<I", input.read(4))[0]
[task 2019-12-03T22:09:46.613Z] 1:42.87 E error: unpack requires a string argument of length 4
[task 2019-12-03T22:09:46.613Z] 1:42.87
[task 2019-12-03T22:09:46.613Z] 1:42.87 /usr/lib/python2.7/gzip.py:25: error
[task 2019-12-03T22:09:46.613Z] 1:42.87 ----------------------------- Captured stdout call -----------------------------
[task 2019-12-03T22:09:46.613Z] 1:42.87 Getting https://index.taskcluster.net/v1/task/gecko.v2.try.latest.firefox.condprof-linux64/artifacts/public/condprof/profile-linux64-cold-default.tgz
[task 2019-12-03T22:09:46.613Z] 1:42.87 [2019-12-03T22:08:33.909036] Downloading https://index.taskcluster.net/v1/task/gecko.v2.try.latest.firefox.condprof-linux64/artifacts/public/condprof/profile-linux64-cold-default.tgz
[task 2019-12-03T22:09:46.613Z] 1:42.87 Extracting the tarball content in /tmp/tmp4MRgbR
[task 2019-12-03T22:09:46.613Z] 1:42.87 ----------------------------- Captured stderr call -----------------------------
[task 2019-12-03T22:09:46.614Z] 1:42.87 ['path/to/dummy/browser', '--version']
[task 2019-12-03T22:09:46.614Z] 1:42.87 ['path/to/dummy/browser', '--version']
[task 2019-12-03T22:09:46.614Z] 1:42.87 ========== 1 failed, 41 passed, 1 skipped, 2 xfailed in 73.81 seconds ==========
[task 2019-12-03T22:09:46.614Z] 1:42.88 Return code from mach python-test: 1

This (index.taskcluster.net... is the old ROOT_URL and is/will be fixed by bug 1599471, which I'll roll into bug 1600838, by way of whichever more-permanent solution we use for packaging, from bug 1601759.

Need-info?ing myself so I can close this and bug 1601481/bug 1601481.

Flags: needinfo?(stephen.donner)

Please stop creating new bugs for problems in a patch of an existing bug

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → INVALID
Flags: needinfo?(stephen.donner)
You need to log in before you can comment on or make changes to this bug.