Closed Bug 1601150 Opened 4 years ago Closed 4 years ago

Permafailing diff-reproducible-linux32 build differences in libxul.so

Categories

(Core :: JavaScript: WebAssembly, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla73
Tracking Status
firefox-esr68 --- unaffected
firefox71 --- unaffected
firefox72 --- unaffected
firefox73 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

(Regression)

Details

(Keywords: intermittent-failure, regression)

Attachments

(2 files)

Attached file diff

The diff-reproducible tasks are failing because the cranelift update pulled code that generates rust code in a non deterministic way. See attachment for an example of differences between two builds.

Flags: needinfo?(bbouvier)

It's also notable that we apparently build the cranelift-codegen crate twice...

On it; I've taken your commit and tweaked it, here's the corresponding PR.

(In reply to Mike Hommey [:glandium] (high latency) from comment #1)

It's also notable that we apparently build the cranelift-codegen crate twice...

Is this in the context of the Spidermonkey build? It might be a difference in selected features / dependencies. Otherwise, I wonder if this is the sandboxing system using lucet that would build it again.

Flags: needinfo?(bbouvier)

I think it's indirect from different features for serde.

Please note that cranelift being built twice is a regression from bug 1597989

Bug 1601233 made cranelift bump its syn dependency to 1.0, breaking the
workspace hack. Some of the features were also stale from presumably
other updates.

Assignee: nobody → mh+mozilla
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/4a7905b19956
Update cargo workspace hack. r=chmanchester
Flags: needinfo?(mh+mozilla)
See Also: → 1601638

Bug 1601638 was created for the new occurrences mentioned in comment 9

Flags: needinfo?(mh+mozilla)
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.