Permafailing diff-reproducible-linux32 build differences in libxul.so
Categories
(Core :: JavaScript: WebAssembly, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr68 | --- | unaffected |
firefox71 | --- | unaffected |
firefox72 | --- | unaffected |
firefox73 | --- | fixed |
People
(Reporter: glandium, Assigned: glandium)
References
(Regression)
Details
(Keywords: intermittent-failure, regression)
Attachments
(2 files)
The diff-reproducible tasks are failing because the cranelift update pulled code that generates rust code in a non deterministic way. See attachment for an example of differences between two builds.
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 1•4 years ago
|
||
It's also notable that we apparently build the cranelift-codegen crate twice...
Assignee | ||
Comment 2•4 years ago
|
||
https://github.com/glandium/cranelift/commit/4cc02a397a7c928c967a2fddddf62676b72e55c1 should fix the determinism issue.
Comment 3•4 years ago
|
||
On it; I've taken your commit and tweaked it, here's the corresponding PR.
(In reply to Mike Hommey [:glandium] (high latency) from comment #1)
It's also notable that we apparently build the cranelift-codegen crate twice...
Is this in the context of the Spidermonkey build? It might be a difference in selected features / dependencies. Otherwise, I wonder if this is the sandboxing system using lucet that would build it again.
Assignee | ||
Comment 4•4 years ago
|
||
I think it's indirect from different features for serde.
Assignee | ||
Comment 5•4 years ago
|
||
Please note that cranelift being built twice is a regression from bug 1597989
Updated•4 years ago
|
Updated•4 years ago
|
Assignee | ||
Comment 6•4 years ago
|
||
Bug 1601233 made cranelift bump its syn dependency to 1.0, breaking the
workspace hack. Some of the features were also stale from presumably
other updates.
Updated•4 years ago
|
Pushed by mh@glandium.org: https://hg.mozilla.org/integration/autoland/rev/4a7905b19956 Update cargo workspace hack. r=chmanchester
Comment hidden (Intermittent Failures Robot) |
Comment 9•4 years ago
|
||
Mike, there have been other recent occurrences of a similar failure after your patch landed: https://treeherder.mozilla.org/#/jobs?repo=autoland&collapsedPushes=598800&searchStr=diffoscope%2Copt%2Cdiff-reproducible-linux32%2C%28linux32%29&fromchange=3c7dfe06b8492c73c322044fe7a2146414e9c0e5&tochange=1ea03bd6c9ccf4f3742542ddf15f9f624fd30de2&selectedJob=279784558
Should we make a new bug for them or classify them against this one?
Comment 10•4 years ago
|
||
Bug 1601638 was created for the new occurrences mentioned in comment 9
Assignee | ||
Updated•4 years ago
|
Comment 11•4 years ago
|
||
bugherder |
Updated•4 years ago
|
Comment hidden (Intermittent Failures Robot) |
Updated•2 years ago
|
Description
•