1601267 - The keyboard navigation does not work when the “Onboarding” tip is displayed

Status: RESOLVED INVALID

(Firefox :: Address Bar, defect)

Description

[Simona Rosu [:srosu], Ecosystem QA]

Attachment: OnboardingTip_KeyboardNavigation.mp4

[Affected versions]:

• Latest Firefox Nightly 73.0a1 (Build ID: 20191204095640)

[Affected Platforms]:

• Mac 10.14
• Windows 10 x64
• Ubuntu 16.04 x64

[Prerequisites]:

• Have the latest Nightly installed.
• Have the “devtools.chrome.enabled” pref set to “true”.
• Run the “(async function() { let { ProfileAge } = ChromeUtils.import("resource://gre/modules/ProfileAge.jsm"); let age = await ProfileAge(); age._times = { firstUse: 1368255600000, created: 1368255600000 }; await age.writeTimes(); })();” code on the browser console.
• Have access to the stage delivery console.
• Have an active branched add-on recipe.
• Have the “security.content.signature.root_hash” pref set to "DB:74:CE:58:E4:F9:D0:9E:E0:42:36:BE:6C:C5:C4:F6:6A:E7:74:7D:C0:21:42:7A:03:BC:2F:57:0C:8B:9B:90".
• Have the "app.normandy.api_url" pref set to "https://stage.normandy.nonprod.cloudops.mozgcp.net/api/v1".
• Have the "app.normandy.dev_mode" pref set to “true”.
• Have the "app.normandy.logging.level" pref set to “0”.
• Have the "services.settings.server" pref set to "https://settings.stage.mozaws.net/v1".
• Have the "xpinstall.signatures.dev-root" pref set to “true”.
• Create a new pref named “carmentips” and set it as “true”.

[Steps to reproduce]:

1. Open the Firefox browser with the profile from prerequisites.
2. Open a new tab.
3. Press the “Tab” key and observe the behavior.

[Expected result]:

• The”Ok, Got It” button is focused.

[Actual result]:

• Nothing happens. Both the Address bar and the "OK, Got It" button are focused at the same time and the keyboard navigation doesn't work anymore.

[ Notes]:

• Attached a screen recording with the issue.

Comment 1

[Drew Willcoxon :adw]

This is similar to bug 1601268 and is the expected behavior. There are a couple of things going on here. (1) As in bug 1601268, the tab key cycles through all results and then wraps back around to the input. In this case, there's only one result, the tip. (2) Unlike in bug 1601268, here the tip is the preselected "heuristic" result. That means two things: it's selected initially, and a selection is always present in the results. There's only one result, the tip, so it always remains selected.

Like bug 1601268, you can reproduce this before bug 1600325 landed without tips at all. For example, type "@google". There should be only a single "Search with Google" result and it should be selected. Then keep hitting the tab key.