Enable JSON Preview (LONG MODE) by default
Categories
(DevTools :: Netmonitor, enhancement, P3)
Tracking
(firefox75 fixed)
| Tracking | Status | |
|---|---|---|
| firefox75 | --- | fixed |
People
(Reporter: vuonghv.cs, Assigned: vuonghv.cs, Mentored)
References
(Blocks 2 open bugs)
Details
Attachments
(3 files)
After enable JSON preview
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:72.0) Gecko/20100101 Firefox/72.0
Steps to reproduce:
We should enable MODE.LONG on JSON Preview by default. Its is very convenient to preview JSON before opening it, like Google Chrome. I have fix the code on my machine, please check the attachments for demo.
|
Assignee | |
Comment 1•5 years ago
|
||
|
|
Assignee | |
Updated•5 years ago
|
|
||
Comment 2•5 years ago
|
||
:honza, could you please help Vuong Hoang with review?
Sorry for the delay!
I agree with using MODE.LONG
@Vuong: are you still interested in this?
Honza
|
|
Assignee | |
Comment 4•4 years ago
|
||
[:Honza] Thank you for reply, I'm interested in this proposal. So could I push a PR to fix this?
That would be great yes.
Assigned to you.
Some docs you might need
https://firefox-source-docs.mozilla.org/contributing/how_to_contribute_firefox.html
Honza
@Hubert, another patch that might be built on top of your work.
Honza
|
||
Comment 7•4 years ago
•
|
||
Hi vuong,
How is your setup going?
Note:
We are currently doing some refactoring which is here https://phabricator.services.mozilla.com/D63799 which should land soon
and would affect the location of your change slightly.
Any help you need, pls let me know.
Thanks
|
|
||
Updated•4 years ago
|
|
|
Assignee | |
Comment 8•4 years ago
|
||
Hi Hubert,
I need 1 more day to finished submit my patch. Please wait.
Thank you!
|
|
||
Comment 9•4 years ago
|
||
Hi Vuong,
No rush. Take your time.
|
|
Assignee | |
Comment 10•4 years ago
|
||
|
|
Assignee | |
Comment 11•4 years ago
|
||
Hi :honza :bomsy,
I have pushed the fix on Phabricator, please review my work.
And could you tell me what I have to do next?
Thank you
|
||
Comment 12•4 years ago
|
||
Pushed by hmanilla@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7b42dd34f816 Enable LONG MODE JSONPreview by default r=bomsy
|
||
Comment 13•4 years ago
|
||
| bugherder | ||
Description
•