Closed Bug 1601278 Opened 2 years ago Closed 1 year ago

Enable JSON Preview (LONG MODE) by default

Categories

(DevTools :: Netmonitor, enhancement, P3)

Product:
DevTools
Component:
Netmonitor
Version:
71 Branch
Type:
enhancement

Tracking

(firefox75 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 75
Tracking Flags:
Tracking Status
firefox75 --- fixed

People

(Reporter: vuonghv.cs, Assigned: vuonghv.cs, Mentored)

References

(Blocks 2 open bugs)

Details

Attachments

(3 files)

After enable JSON preview
407.38 KB, image/png
Details
Before enable JSON preview
244.65 KB, image/png
Details
Bug 1601278 - Enable LONG MODE JSONPreview by default r=Honza,nchevobbe
47 bytes, text/x-phabricator-request
Details | Review

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:72.0) Gecko/20100101 Firefox/72.0

Steps to reproduce:

We should enable MODE.LONG on JSON Preview by default. Its is very convenient to preview JSON before opening it, like Google Chrome. I have fix the code on my machine, please check the attachments for demo.

OS: Unspecified → All
Hardware: Unspecified → All

:honza, could you please help Vuong Hoang with review?

Flags: needinfo?(odvarko)

Sorry for the delay!

I agree with using MODE.LONG

@Vuong: are you still interested in this?

Honza

Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: needinfo?(odvarko) → needinfo?(vuonghv.cs)
Priority: -- → P3

[:Honza] Thank you for reply, I'm interested in this proposal. So could I push a PR to fix this?

Flags: needinfo?(vuonghv.cs)

That would be great yes.

Assigned to you.

Some docs you might need
https://firefox-source-docs.mozilla.org/contributing/how_to_contribute_firefox.html

Honza

Assignee: nobody → vuonghv.cs
Status: NEW → ASSIGNED

@Hubert, another patch that might be built on top of your work.

Honza

Flags: needinfo?(hmanilla)

Hi vuong,
How is your setup going?

Note:
We are currently doing some refactoring which is here https://phabricator.services.mozilla.com/D63799 which should land soon
and would affect the location of your change slightly.

Any help you need, pls let me know.

Thanks

Flags: needinfo?(hmanilla)
Flags: needinfo?(vuonghv.cs)

Hi Hubert,
I need 1 more day to finished submit my patch. Please wait.
Thank you!

Flags: needinfo?(vuonghv.cs)

Hi Vuong,
No rush. Take your time.

Hi :honza :bomsy,
I have pushed the fix on Phabricator, please review my work.
And could you tell me what I have to do next?
Thank you

Pushed by hmanilla@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7b42dd34f816
Enable LONG MODE JSONPreview by default r=bomsy

https://hg.mozilla.org/mozilla-central/rev/7b42dd34f816

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox75: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 75
You need to log in before you can comment on or make changes to this bug.